Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add flags related methods #272

Merged
merged 9 commits into from
Jul 9, 2024
Merged

feat: add flags related methods #272

merged 9 commits into from
Jul 9, 2024

Conversation

Sherlock-Holo
Copy link
Contributor

this PR allow compio driver and runtime not only return the IO result, but also return the flags

@Sherlock-Holo Sherlock-Holo force-pushed the rawop-with-flag branch 4 times, most recently from 3ca8a0f to 916f480 Compare July 1, 2024 15:24
Berrysoft
Berrysoft requested changes Jul 2, 2024
View reviewed changes
Copy link
Member

@Berrysoft Berrysoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some methods seems redundant... I have no idea yet.

compio-driver/src/iour/mod.rs Outdated Show resolved Hide resolved
compio-driver/src/key.rs Outdated Show resolved Hide resolved
compio-driver/src/lib.rs Outdated Show resolved Hide resolved
@Berrysoft
Copy link
Member

I think it looks OK now. What do you think @George-Miao

@Sherlock-Holo Sherlock-Holo marked this pull request as ready for review July 3, 2024 04:23
@Sherlock-Holo
refactor: add feature gate for set_flags method
34bfd3c 
clippy complain set_flags is unsed when disable io-uring feature
@Sherlock-Holo Sherlock-Holo changed the title (WIP) feat: add flags related methods feat: add flags related methods Jul 3, 2024
Berrysoft
Berrysoft requested changes Jul 5, 2024
View reviewed changes
compio-driver/src/lib.rs Outdated Show resolved Hide resolved
compio-runtime/src/runtime/mod.rs Outdated Show resolved Hide resolved
compio-runtime/src/runtime/mod.rs Show resolved Hide resolved
compio-runtime/src/runtime/op.rs Show resolved Hide resolved
George-Miao
George-Miao approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Berrysoft
Berrysoft approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@Berrysoft Berrysoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Berrysoft Berrysoft merged commit e8f2a16 into compio-rs:master Jul 9, 2024
29 checks passed
@Sherlock-Holo Sherlock-Holo deleted the rawop-with-flag branch July 10, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@George-Miao George-Miao George-Miao approved these changes

@Berrysoft Berrysoft Berrysoft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sherlock-Holo @Berrysoft @George-Miao