Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to split into multiple crates #81

Merged
merged 26 commits into from
Oct 5, 2023

Conversation

Berrysoft
Copy link
Member

@Berrysoft Berrysoft commented Sep 29, 2023

Closes #70

However, I don't think it's easy to do so. Many pub(crate) elements are turned into public.

TODO:

  • Split the tests to multiple crates.
  • Fix the doc tests.
  • Unify the crate metadata.

@George-Miao Do you like this attempt?

@George-Miao
Copy link
Member

BTW I think the branch should be named as refactor/split as it's not adding any new features.

@Berrysoft Berrysoft marked this pull request as ready for review October 3, 2023 12:24
compio-driver/src/iour/mod.rs Show resolved Hide resolved
compio-driver/src/poll/mod.rs Show resolved Hide resolved
@George-Miao
Copy link
Member

George-Miao commented Oct 4, 2023

Also, in compio-signal/src/lb.rs, ctrl_c is shown differently on windows and unix docs. On windows, it's no_inline-d so there's a separate pub use windows::ctrl_c while on unix it's defined in lib.rs. Maybe some consistency is desirable?

Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Berrysoft Berrysoft merged commit 16170f1 into compio-rs:master Oct 5, 2023
11 checks passed
@Berrysoft Berrysoft deleted the dev/split branch October 5, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Split compio into multiple crates
2 participants