Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow returning ready on push #82

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Allow returning ready on push #82

merged 3 commits into from
Oct 5, 2023

Conversation

Berrysoft
Copy link
Member

@Berrysoft Berrysoft commented Oct 5, 2023 •
edited
Loading

Runtime::submit is called after first Future::poll, so it's OK to return ready on push.

George-Miao
George-Miao approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@George-Miao George-Miao merged commit 14cf971 into compio-rs:master Oct 5, 2023
11 checks passed
@Berrysoft Berrysoft deleted the dev/ready-on-push branch October 5, 2023 12:49
@Berrysoft Berrysoft mentioned this pull request Oct 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@George-Miao George-Miao George-Miao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Berrysoft @George-Miao