Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc(cfg()) support #96

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Add doc(cfg()) support #96

merged 3 commits into from
Oct 17, 2023

Conversation

George-Miao
Copy link
Member

No description provided.

@George-Miao George-Miao self-assigned this Oct 15, 2023
@George-Miao George-Miao added the documentation Improvements or additions to documentation label Oct 15, 2023
@SpriteOvO
Copy link

SpriteOvO commented Oct 16, 2023 •
edited
Loading

docs.rs always builds docs with nightly Rust, so another approach is to enable doc_auto_cfg only with nightly builds. You can determine the channel in build.rs with rustc_version crate.

@George-Miao
Copy link
Member Author

George-Miao commented Oct 16, 2023 •
edited
Loading

Run build.rs everytime the doc is built is not really a good idea. I will stick with the manual meta w/ cfg approach.

Berrysoft
Berrysoft reviewed Oct 16, 2023
View reviewed changes
compio-buf/src/lib.rs Outdated Show resolved Hide resolved
compio-driver/src/iour/mod.rs Outdated Show resolved Hide resolved
compio/src/lib.rs Outdated Show resolved Hide resolved
@Berrysoft Berrysoft merged commit eac5bfb into master Oct 17, 2023
9 of 11 checks passed
@George-Miao George-Miao deleted the doc/refurnish branch October 17, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Berrysoft Berrysoft Berrysoft approved these changes

Assignees

@George-Miao George-Miao

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@George-Miao @SpriteOvO @Berrysoft