Coburn/integrate poster #10
Conversation
| @@ -22,7 +22,10 @@ yarn add open-oracle-poster | |||
| To run as a standalone: | |||
|
|
|||
| ``` | |||
| open-oracle-poster --poster-key=0x... | |||
| start reporter | |||
| yarn run start --private_key=0x5763aa1cb4c9cd141a1b409d92e5c5b967a28e18c70eb4cd965374ad75bff356 --script="examples/fixed.js" | |||
There was a problem hiding this comment.
just some notes for starting integration, room for improvement 4 sure
| // afer this timeout | ||
| web3.eth.transactionPollingTimeout = argv.timeout; | ||
|
|
||
| if (argv.web3_provider === "http://127.0.0.1:8545") { |
There was a problem hiding this comment.
If you're curious, truffle does an API call to the server and checks to see if evm_snapshot is an API function, and uses that to determine if the server is ganache. I think this is better-- or even just adding a CLI-option (though it would probably trip users up if they didn't read too carefully). So -- in sum -- I like this simple approach to "detect if ganache"-- this might belong in a different file, though.
poster/src/postWithRetries.ts
Outdated
| } else { | ||
| throw(e); | ||
| throw(e) |
poster/src/poster.ts
Outdated
| senderKey : string, | ||
| viewAddress : string, | ||
| functionName : string, | ||
| web3 ) { |
There was a problem hiding this comment.
web3: Web should work if you import web3
poster/src/poster.ts
Outdated
| functionName : string, | ||
| web3 ) { | ||
| const payloads = await fetchPayloads(sources.split(",")); | ||
| console.log(payloads) |
There was a problem hiding this comment.
If you want to keep the console log, maybe format it? Or just for debugging?
| } | ||
|
|
||
| async function fetchGasPrice() : Promise<number> { | ||
| let source = "https://api.compound.finance/api/gas_prices/get_gas_price"; |
There was a problem hiding this comment.
Maybe catch and return a default if this is down?
| } | ||
|
|
||
| // e.g. findTypes("postPrices(bytes[],bytes[],string[])")-> ["bytes[]","bytes[]","string[]"] | ||
| function findTypes(functionName : string) : string[] { |
There was a problem hiding this comment.
Hm, this is going to be fragile-- though it doesn't look like web3 exposes a "parseAbi" function-- which is kind of lame.
There was a problem hiding this comment.
At least, could be a good case for a regular expression? e.g. (\w+)?\((.*)\) and then return match group 1 (the optional function name) and match group two split by ,?
There was a problem hiding this comment.
I found a library version of this function https://github.com/ethereumjs/ethereumjs-abi/blob/master/lib/index.js#L81, copied it in since it's unexported
| // ABI encoded values to be written to the open oracle data contract. | ||
| message: string, | ||
| encoded: string, |
There was a problem hiding this comment.
I think this needs to be changed in many places
There was a problem hiding this comment.
I think I got them
| function buildTrxData(payloads : DelFiReporterPayload[], functionName : string) : string { | ||
| const types = findTypes(functionName); | ||
|
|
||
| let messages = payloads.map(x => x.encoded); |
a few refactors here.
Added eth_chainId trufflesuite/ganache#419