Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HCOS to list of supported platforms #534

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bwhitchurch
Copy link

Hello,
I have been using conan and cmake to manage my builds and dependencies for projects targeting HCOS (honeycomb OS). I would like to add this name to the list of supported platforms.

@CLAassistant
Copy link

CLAassistant commented Jul 13, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding changes here without adding them first to Conan default settings.yml is useless, because Conan will reject it if not there.

To add a new OS the process is first sending it to Conan client. It really only makes sense if it is quite mainstream, otherwise, customizing your own settings.yml would be enough.
Also, latest Conan is 2.0. This kind of support for new platforms should be targeted for Conan 2.0 directly, not for Conan 1.X (both for Conan client, and for the cmake-conan integration).

Thanks very much!

@bwhitchurch
Copy link
Author

Okay, thank you very much. I had tried adding the entry to our local settings.yml as an option under both os_build and os_target. This works when we call conan and cmake separately, but it does not seem to be picked up by this script.

@memsharded
Copy link
Member

``Okay, thank you very much. I had tried adding the entry to our local settings.yml as an option under both os_build and os_target.```

os_build and os_target are legacy, and shouldn't be used anymore. Cross-build scenarios should use the 2 profiles, with the "build" profile specified with -pr:b=mybuildprofile (can be the default one)

@bwhitchurch
Copy link
Author

bwhitchurch commented Jul 13, 2023

customizing your own settings.yml would be enough.

So where should I add a new supported OS if entries under os_build, os_target, and os sections aren't getting picked up?
I have a profile for this target already as well. I would appreciate if you could take a quick look and tell me what I have missed. Regardless, even with these configurations setup I still get

CMake Error at build/hcos_default/conan.cmake:105 (message):
cmake system HCOS is not supported by conan.
Use one of
Windows;Linux;Macos;Android;iOS;FreeBSD;WindowsStore;WindowsCE;watchOS;tvOS;FreeBSD;SunOS;AIX;Arduino;Emscripten;Neutrino

because the SUPPORTED_PLATFORMS list is not formed from the information in any of these local configuration files.
hcos_profile

@memsharded
Copy link
Member

So where should I add a new supported OS if entries under os_build, os_target, and os sections aren't getting picked up?
I have a profile for this target already as well. I would appreciate if you could take a quick look and tell me what I have missed. Regardless, even with these configurations setup I still get

It should be added to the os section.

because the SUPPORTED_PLATFORMS list is not formed from the information in any of these local configuration files.
hcos_profile

Yes, I am not saying that this wouldn't need an addition, but without adding it to Conan settings.yml first, it is pointless.
Also, this kind of new features and support for 1.X series will typically not be considered. New things should target Conan 2.0 branches (also cmake-conan 2 branch, that will not have any constraint in the OS)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants