Skip to content

Commit

Permalink
pcl: update patches
Browse files Browse the repository at this point in the history
  • Loading branch information
valgur committed Jan 4, 2024
1 parent 8134ad2 commit 558de56
Show file tree
Hide file tree
Showing 7 changed files with 54 additions and 12 deletions.
18 changes: 7 additions & 11 deletions recipes/pcl/all/conandata.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,30 +7,26 @@ sources:
sha256: "8ab98a9db371d822de0859084a375a74bdc7f31c96d674147710cf4101b79621"
patches:
"1.14.0":
- patch_file: "patches/0001-cmake_use_conan_targets.patch"
- patch_file: "patches/1.14.0/0001-cmake_use_conan_targets.patch"
patch_description: "Update PCL CMake files to work with Conan"
patch_type: "conan"
- patch_file: "patches/0001-fix-FindOpenNI-bug.patch"
- patch_file: "patches/1.13.1/0001-fix-FindOpenNI-bug.patch"
patch_description: "Fix a libusb detection bug in FindOpenNI.cmake"
patch_type: "bugfix"

Check warning on line 15 in recipes/pcl/all/conandata.yml

View workflow job for this annotation

GitHub Actions / Lint changed files (YAML files)

conandata.yml schema warning

'patch_type' should have 'patch_source' as per https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/conandata_yml_format.md#patch_type it is expected to have a source (e.g. a URL) to where it originates from to help with reviewing and consumers to evaluate patches
- patch_file: "patches/0001-Add-Eigen3-Eigen-target-in-pcl_common-target.patch"
- patch_file: "patches/1.13.1/0001-Add-Eigen3-Eigen-target-in-pcl_common-target.patch"
patch_description: "Add Eigen3::Eigen target to pcl_common target"
patch_type: "conan"
- patch_file: "patches/0001-ReportFixAboutMemoryConsumptionDuringBuild.patch"
patch_description: "MovingLeastSquares: reduce the number of instantiations to reduce compile time"
patch_source: "https://github.com/PointCloudLibrary/pcl/pull/5764"
patch_type: "conan"
"1.13.1":
- patch_file: "patches/0001-cmake_use_conan_targets.patch"
- patch_file: "patches/1.13.1/0001-cmake_use_conan_targets.patch"
patch_description: "Update PCL CMake files to work with Conan"
patch_type: "conan"
- patch_file: "patches/0001-fix-FindOpenNI-bug.patch"
- patch_file: "patches/1.13.1/0001-fix-FindOpenNI-bug.patch"
patch_description: "Fix a libusb detection bug in FindOpenNI.cmake"
patch_type: "bugfix"

Check warning on line 25 in recipes/pcl/all/conandata.yml

View workflow job for this annotation

GitHub Actions / Lint changed files (YAML files)

conandata.yml schema warning

'patch_type' should have 'patch_source' as per https://github.com/conan-io/conan-center-index/blob/master/docs/adding_packages/conandata_yml_format.md#patch_type it is expected to have a source (e.g. a URL) to where it originates from to help with reviewing and consumers to evaluate patches
- patch_file: "patches/0001-Add-Eigen3-Eigen-target-in-pcl_common-target.patch"
- patch_file: "patches/1.13.1/0001-Add-Eigen3-Eigen-target-in-pcl_common-target.patch"
patch_description: "Add Eigen3::Eigen target to pcl_common target"
patch_type: "conan"
- patch_file: "patches/0001-ReportFixAboutMemoryConsumptionDuringBuild.patch"
- patch_file: "patches/1.13.1/0001-ReportFixAboutMemoryConsumptionDuringBuild.patch"
patch_description: "MovingLeastSquares: reduce the number of instantiations to reduce compile time"
patch_source: "https://github.com/PointCloudLibrary/pcl/pull/5764"
patch_type: "conan"
1 change: 0 additions & 1 deletion recipes/pcl/all/conanfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,6 @@ def generate(self):
tc.generate()

deps = CMakeDeps(self)
deps.set_property("eigen", "cmake_file_name", "EIGEN")
deps.set_property("flann", "cmake_file_name", "FLANN")
deps.set_property("flann", "cmake_target_name", "FLANN::FLANN")
deps.set_property("libpcap", "cmake_file_name", "PCAP")
Expand Down
47 changes: 47 additions & 0 deletions recipes/pcl/all/patches/1.14.0/0001-cmake_use_conan_targets.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -297,7 +297,7 @@
# OpenMP (optional)
option(WITH_OPENMP "Build with parallelization using OpenMP" TRUE)
if(WITH_OPENMP)
- find_package(OpenMP COMPONENTS C CXX)
+ find_package(OpenMP REQUIRED COMPONENTS C CXX)
endif()
if(OpenMP_FOUND)
string(APPEND CMAKE_C_FLAGS " ${OpenMP_C_FLAGS}")
@@ -319,7 +319,7 @@
find_package(Threads REQUIRED)

# Eigen3 (required)
-find_package(Eigen3 3.3 REQUIRED NO_MODULE)
+find_package(Eigen3 REQUIRED CONFIG)
if(NOT EIGEN3_FOUND AND Eigen3_FOUND)
set(EIGEN3_FOUND ${Eigen3_FOUND})
endif()
@@ -365,7 +365,7 @@
# LibPNG
option(WITH_PNG "PNG file support" TRUE)
if(WITH_PNG)
- find_package(PNG)
+ find_package(PNG REQUIRED CONFIG)
if(PNG_FOUND)
set(HAVE_PNG ON)
include_directories(SYSTEM "${PNG_INCLUDE_DIR}")
@@ -375,7 +375,7 @@
# Qhull
option(WITH_QHULL "Include convex-hull operations" TRUE)
if(WITH_QHULL)
- find_package(Qhull)
+ find_package(QHULL REQUIRED CONFIG)
if(NOT (${QHULL_LIBRARY_TYPE} MATCHES ${PCL_QHULL_REQUIRED_TYPE}) AND NOT (${PCL_QHULL_REQUIRED_TYPE} MATCHES "DONTCARE"))
message(FATAL_ERROR "Qhull was selected with ${PCL_QHULL_REQUIRED_TYPE} but found as ${QHULL_LIBRARY_TYPE}")
endif()
@@ -410,7 +410,7 @@
#Find PCAP
option(WITH_PCAP "pcap file capabilities in Velodyne HDL driver" TRUE)
if(WITH_PCAP)
- find_package(Pcap)
+ find_package(PCAP REQUIRED CONFIG)
endif()

# OpenGL and GLUT

0 comments on commit 558de56

Please sign in to comment.