Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[package] raylib/5.0: Missing rcamera.h header #24368

Open
Ezbob opened this issue Jun 17, 2024 · 6 comments · May be fixed by #24472
Open

[package] raylib/5.0: Missing rcamera.h header #24368

Ezbob opened this issue Jun 17, 2024 · 6 comments · May be fixed by #24472
Assignees
Labels
bug Something isn't working

Comments

@Ezbob
Copy link

Ezbob commented Jun 17, 2024

Description

I've tried to run the 3d camera examples from the RayLib package, but it seems that the rcamera.h header is missing from the package's include path. I've managed to find it in the RayLib's source so it seems like it still around. Furthermore it seems that the raudio.h header is also missing.

Package and Environment Details

  • Package Name/Version: raylib/5.0
  • Operating System+version: Windows 10 19045.4529
  • Compiler+version: MSVC 17
  • Conan version: conan 2.4.1
  • Python version: Python 3.12.0

Conan profile

[settings]
arch=x86_64
build_type=Release
compiler=msvc
compiler.cppstd=14
compiler.runtime=dynamic
compiler.version=193
os=Windows

[options]
[conf]
[build_requires]
[env]

Steps to reproduce

Put:

[requires]
raylib/5.0

[generators]
CMakeDeps
CMakeToolchain

[layout]
cmake_layout

in a conanfile.txt.
Run conan install . -pr:h=default -pr:b=default --build=missing to install depedencies.

Try and compile this program with the using the conan_toolchain.cmake:

#include "raylib.h"
#include "rcamera.h"

int main(void)
{
  return 0;
}

Logs

Click to expand log
MSBuild version 17.7.2+d6990bcfa for .NET Framework

  Checking Build System
  Building Custom Rule H:/c++/pewpew/CMakeLists.txt
  main.c
H:\c++\pewpew\src\main.c(15,10): fatal  error C1083: Cannot open include file: 'rcamera.h': No such file or directory [H:\c++\pewpew\build\pewpew.vcxproj]
@Ezbob Ezbob added the bug Something isn't working label Jun 17, 2024
@AbrilRBS
Copy link
Member

Hi @Ezbob thanks a lot for taking the time to report your issue, we appreciate it :)

I don't think this is a recipe issue, as per the upstream cmakelist in https://github.com/raysan5/raylib/blob/master/src/CMakeLists.txt#L24, you can see that they set a minimal collection of headers as part of their public API, so it's not clear to me if the expectations are to be able to use such headers externally

As you mention, to confuse things even more, they do show up in the examples, so maybe we need to ask upstream first?

@AbrilRBS AbrilRBS self-assigned this Jun 17, 2024
@Ezbob
Copy link
Author

Ezbob commented Jun 19, 2024

Hello, and thanks for your quick response, and sorry for my slow one.
Hmm... Yes I can see that it looks like they don't expose rcamera.h as a public header...
I can see that others also had the problem (Discussion). I'll check try and check with the raylib guys.

@AbrilRBS
Copy link
Member

Thanks! Please feel free to ping me once you get some insight into the issue, would be happy to quickly act on it :)

@Ezbob
Copy link
Author

Ezbob commented Jun 25, 2024

Hello @RubenRBS ,
I've made an issue on the upstream repository, but they have closed it as a no-fix.
While I don't get their conclusion, it seems that for the getting the examples to work (those who use rcamera.h or rgestures.h), you'll need to copy the missing headers from their repository to your own.

@AbrilRBS
Copy link
Member

Thanks for the follow up @Ezbob! I think I might have a solution for this that might satisfy us all, I'll submit a PR in a bit where we can discuss it :)

@Ezbob
Copy link
Author

Ezbob commented Jun 26, 2024

Cool! Thanks @RubenRBS :)

@AbrilRBS AbrilRBS linked a pull request Jun 29, 2024 that will close this issue
@AbrilRBS AbrilRBS linked a pull request Jun 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants