-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raylib: Add some useful headers to res folder #24472
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
Hey @AbrilRBS , big thanks for this. |
This comment has been minimized.
This comment has been minimized.
Hi @Ezbob, not a noob question at all, I should have been more clear as to how to proceed, sorry about that! We're going to make this available thru a conf as @uilianries suggested - I'll post a how-to after I commit the changes :) |
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ✔️
All green in build 3 ( |
With the current approach (pending dismissal from someone on the team if they don't like it) would be for you to compile your package as normal, but add the
This will make it so the recipe adds the new include path to your project, giving you access to those files. The alternative approach if you don't need everything, or only need certain files, would be NOT to define the conf, and instead in your recipe's def generate(self):
# ... The rest of your generate method ...
copy(self, pattern="rcamera.h", src=self.dependencies["raylib"].cpp_info.resdirs[0], dst=os.path.join(self.build_folder, "path-where-you-want-thefiles") This would only copy rcamera.h and would give you the liberty of moving it to a place of your liking - hope this helps :) |
@AbrilRBS Oh that look nice! Huge thanks for this! |
Summary
Changes to recipe: raylib/[*]
Motivation
As explained in #24368, the library does not package some useful files that users might want to use as part of their build. This is similar to the imgui situation, so the solution is also similar: Add those files to the res folder, where users can then copy them from
Details
The linked issue and subsequent upstream issue have all the relevant info
As a draft until I get a chance to update the hook that will fail
cc @Ezbob