Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements in meta information - Fast-DDS/2.3.2 #6137

Closed
dotChris90 opened this issue Jul 2, 2021 · 2 comments
Closed

Improvements in meta information - Fast-DDS/2.3.2 #6137

dotChris90 opened this issue Jul 2, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@dotChris90
Copy link
Contributor

dotChris90 commented Jul 2, 2021 •
edited
Loading

After PR #5968 was merged and Fast-DDS is part of CCI noticed some meta data are incorrect.

  • self.cpp_info.components["fast-discovery"].name = "fast-discovery" must be fast-discovery server
  • using names["cmake_find_package"] instead of name for components
@dotChris90 dotChris90 added the bug Something isn't working label Jul 2, 2021
@dotChris90
Copy link
Contributor Author

@dotChris90 i would do this on my own since i bring it to CCI.

@dotChris90
Copy link
Contributor Author

already did some changes to meta information and added version 2.3.3 - changes in fork repo - PR will be done next week.

@dotChris90 dotChris90 mentioned this issue Jul 20, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dotChris90