Tiny Changes for Fast-DDS + Add version 2.3.3 #6429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotChris90
commented
Jul 20, 2021
| patches: | ||
| "2.3.2": | ||
| - base_path: "source_subfolder" | ||
| patch_file: "patches/2.3.2-0001-fix-find-asio-and-tinyxml2.patch" | ||
| "2.3.3": | ||
| - base_path: "source_subfolder" |
There was a problem hiding this comment.
not sure what is here official process - 2.3.3 dont need patch - so i just gave the base_path but not the patch_file
There was a problem hiding this comment.
Ha, didn't know that works. Nice hack.
Anyway, the normal/official way is to don't add the version in patches and do the following in conanfile.py.
for patch in self.conan_data.get("patches", {}).get(self.version, []):
tools.patch(**patch)There was a problem hiding this comment.
thanks for info - but i found out i have to patch again - i was missing my checks inside container .... so it took tinyxml from system .... so still have to add patch. ^^'
This comment has been minimized.
This comment has been minimized.
|
my fault - i should have checked them in container ... tinyxml is on my system -.- |
This was referenced Jul 20, 2021
This comment has been minimized.
This comment has been minimized.
madebr
approved these changes
Jul 21, 2021
| self.env_info.PATH.append(bin_path) | ||
| # component tools | ||
| self.cpp_info.components["tools"].name = "tools" | ||
| self.cpp_info.components["tools"].names["cmake_find_package"] = "tools" |
There was a problem hiding this comment.
The name here is a little generic... maybe?
Suggested change
| self.cpp_info.components["tools"].names["cmake_find_package"] = "tools" | |
| self.cpp_info.components["fast-dds-tools"].names["cmake_find_package"] = "tools" |
SSE4
approved these changes
Jul 28, 2021
uilianries
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: fast-dds/2.3.2 + fast-dds/2.3.3
related to the issue Improvements in meta information - Fast-DDS/2.3.2 #6137
--> removed name and used names["cmake_find_package"] to make clear its for cmake
--> changed targetname to dds-discovery-server
add version 2.3.3
I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.