libcurl iOS build added #1008

a4z · 2020-03-01T09:49:19Z

libcurl/7.78.0 iOS build added ( and Android build checked)

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

see #955 ,
maybe wait for possible feedback from the issue

conan-center-bot · 2020-03-01T11:45:10Z

All green in build 1 (0fccc036da1d5409acfa71a1081174b427b00426)! 😊

libcurl/7.68.0: Generated 82 packages. All logs here
libcurl/7.67.0: Generated 82 packages. All logs here
libcurl/7.66.0: Generated 82 packages. All logs here
libcurl/7.64.1: Generated 82 packages. All logs here

recipes/libcurl/all/conanfile.py

a4z · 2020-03-01T18:04:53Z

thanks a lot for the feedback (so far)!
will update the PR according to the notes tomorrow morning

recipes/libcurl/all/conanfile.py

SSE4 · 2020-03-02T10:24:23Z

recipes/libcurl/all/conanfile.py

+                params.append("--enable-threaded-resolver") 
+                params.append("--disable-verbose")
+                # if there is anything special for arm or simulator, add it here
+                if "arm" in self.settings.arch:


I don't think it's nice to leave code blocks doing nothing right now

maybe for documentation purpose it is OK ?

recipes/libcurl/all/conanfile.py

SSE4 · 2020-03-02T10:26:19Z

recipes/libcurl/all/conanfile.py

+                    raise ConanInvalidConfiguration("Unsuported iOS arch {}".format(self.settings.arch)) 
+
+                cc = tools.XCRun(self.settings, iphoneos).cc
+                sysroot = "-isysroot {}".format(tools.XCRun(self.settings, iphoneos).sdk_path)


there is a helper method to get sysroot flag

what do you mean? I thought I use it ?
tools.XCRun(self.settings, iphoneos).sdk_path

SSE4 · 2020-03-02T10:26:47Z

recipes/libcurl/all/conanfile.py

+                arch_flag = "-arch {}".format(configure_arch)
+                ios_min_version = "-miphoneos-version-min={}".format(ios_dev_target)
+                bitcode =  "-fembed-bitcode" if self.options.enable_bitcode else ""
+                extra_flag = "-Werror=partial-availability"


why do we need -Werror?

maybe we don't, but if we have a build config that is incorrect by using something not available on all deployment targets, maybe the build shall fail?

SSE4 · 2020-03-02T10:27:06Z

recipes/libcurl/all/conanfile.py

+                autotools_vars['LDFLAGS'] = "{} {}".format(arch_flag, sysroot)
+                autotools_vars['CPPFLAGS'] += extra_def
+
+            elif self.settings.os == "Android":


same, pls avoid adding empty code blocks

shall I also remove the system_requirements. function?

yes, if it does nothing

if there is documentation, like, it should be like this, or hey, for Android, its tested but there is nothing to do, I think I prefer having this in the file, since it is documentation

But I removed the parts that did nothing and had no docu purpose

SSE4 · 2020-03-02T10:28:04Z

recipes/libcurl/all/conanfile.py

+
+            if self.settings.os == "iOS" and self.settings.arch == "x86_64":
+                # please do not autodetect --build for the iOS simulator, thanks!
+                self._autotools.configure(vars=autotools_vars, args=configure_args, build=False)


is there a bug in conan that it doesn't properly deduce build for iOS simulator?
I am asking cause we already had similar PR for another package in the past

maybe a bug, I do not know,
it will generate a wrong --build argument for configure run, the default (auto detection) from automake gets it right , so it is better to not let conan detect the --build argument for the simulator, since it will get it wrong

recipes/libcurl/all/test_package/conanfile.py

recipes/libcurl/all/conanfile.py

SSE4 · 2020-03-02T10:31:27Z

recipes/libcurl/all/conanfile.py

+                autotools_vars['CFLAGS'] = "{} {} {} {} {}".format(
+                    sysroot, arch_flag, ios_min_version, bitcode, extra_flag
+                ) 
+                autotools_vars['LDFLAGS'] = "{} {}".format(arch_flag, sysroot)


I guess it would be better to manipulate the properties of AutoToolsBuildEnvironment (cflags, link_flags) instead of overriding environment variables. the primary reason that user may have set CFLAGS/LDFLAGS within his conan profile, and such flags would be lost here.

will check what is possible, thanks!

does not work, with not using the environment variables

reduced to the smallest example, using the -isysroot flag

having it in the environment

configure:4717: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -c -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS13.2.sdk -arch armv7 -miphoneos-version-min=10 -Werror=partial-availability -DHAVE_SOCKET -DHAVE_FCNTL_O_NONBLOCK conftest.c >&5 configure:4717: $? = 0 configure:4730: result: none needed

using self._autotools.flags.append(sysroot) , where sysroot is the exact same path

configure:4717: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -c -arch armv7 -miphoneos-version-min=10 -Werror=partial-availability -DHAVE_SOCKET -DHAVE_FCNTL_O_NONBLOCK conftest.c >&5 conftest.c:10:10: fatal error: 'stdio.h' file not found #include <stdio.h> ^~~~~~~~~ 1 error generated. configure:4717: $? = 1 configure: failed program was: ......

so obviously, this is not the same for configure, the values are not passed on

I have now invested some hours in this and will not continue not using the env_var, if you think you can improve, please provide a working example

recipes/libcurl/all/conanfile.py

SSE4 · 2020-03-02T10:32:15Z

recipes/libcurl/all/conanfile.py

+
+        if tools.cross_building(self.settings):
+            if self.settings.os == "iOS": 
+                ios_dev_target = str(self.settings.os.version).split(".")[0]


dangerous, as settings.os.version is not always there. use self.settings.get_safe("os.version").

will it not 'just crash' ?
but ok, what to do if get_safe returns None
raise a configuration error ?

Yes, raise a ConanInvalidConfiguration.

conan-center-bot · 2020-03-02T12:02:43Z

All green in build 2 (63dc9f552783fa0d14a57b6f824b795a3506ad15)! 😊

libcurl/7.68.0: Generated 82 packages. All logs here
libcurl/7.67.0: Generated 82 packages. All logs here
libcurl/7.66.0: Generated 82 packages. All logs here
libcurl/7.64.1: Generated 82 packages. All logs here

* remove code doing nothing * use inbuild tools instead of self made functionality

conan-center-bot · 2020-03-02T15:23:47Z

An unexpected error happened and has been reported. Help is on its way! 🏇

danimtb · 2020-03-02T15:27:54Z

There was an error contacting the server. Relaunching the CI...

conan-center-bot · 2020-03-02T17:33:36Z

An unexpected error happened and has been reported. Help is on its way! 🏇

a4z · 2020-03-03T07:32:10Z

I assume the not successful check, for which I can not see any details due to permissions, are a side effect of #1020 , yes?

conan-center-bot · 2020-03-05T09:59:47Z

All green in build 6 (4496ea8df31c906017799d16113a365833fb4c31)! 😊

libcurl/7.68.0: Generated 82 packages. All logs here
libcurl/7.67.0: Generated 82 packages. All logs here
libcurl/7.66.0: Generated 82 packages. All logs here
libcurl/7.64.1: Generated 82 packages. All logs here

recipes/libcurl/all/conanfile.py

…is one day

conan-center-bot · 2020-03-06T15:08:04Z

An unexpected error happened and has been reported. Help is on its way! 🏇

conan-center-bot · 2020-03-06T16:04:49Z

An unexpected error happened and has been reported. Help is on its way! 🏇

danimtb · 2020-03-06T16:13:04Z

Sorry, we are experiencing some networking issues today. I have relaunched once again the job.

conan-center-bot · 2020-03-06T17:43:44Z

All green in build 9 (3aaa3b7fd5a1da3ff2ef1aeb24085a5f1818cb01)! 😊

libcurl/7.68.0: Generated 82 packages. All logs here
libcurl/7.67.0: Generated 82 packages. All logs here
libcurl/7.66.0: Generated 82 packages. All logs here
libcurl/7.64.1: Generated 82 packages. All logs here

conan-center-bot · 2020-03-15T00:29:27Z

All green in build 10 (0fbc9110e428170977da7506b266e12e8f9f46bf)! 😊

libcurl/7.68.0: Generated 82 packages. All logs here
libcurl/7.67.0: Generated 82 packages. All logs here
libcurl/7.66.0: Generated 82 packages. All logs here
libcurl/7.64.1: Generated 82 packages. All logs here

a4z added 2 commits February 29, 2020 10:19

make curl build for iOS, validate Android build

8265a51

some cleanup

0fccc03

a4z mentioned this pull request Mar 1, 2020

[request] libcurl , build for iOS and Andriod #955

Closed

SSE4 reviewed Mar 1, 2020

View reviewed changes

recipes/libcurl/all/conanfile.py Outdated Show resolved Hide resolved

madebr reviewed Mar 1, 2020

View reviewed changes

recipes/libcurl/all/conanfile.py Outdated Show resolved Hide resolved

theirix reviewed Mar 1, 2020

View reviewed changes

recipes/libcurl/all/conanfile.py Outdated Show resolved Hide resolved

recipes/libcurl/all/conanfile.py Outdated Show resolved Hide resolved

adoptions according to review comments

63dc9f5

SSE4 reviewed Mar 2, 2020

View reviewed changes

recipes/libcurl/all/conanfile.py Outdated Show resolved Hide resolved

SSE4 reviewed Mar 2, 2020

View reviewed changes

recipes/libcurl/all/conanfile.py Show resolved Hide resolved

SSE4 reviewed Mar 2, 2020

View reviewed changes

recipes/libcurl/all/test_package/conanfile.py Outdated Show resolved Hide resolved

SSE4 reviewed Mar 2, 2020

View reviewed changes

recipes/libcurl/all/test_package/conanfile.py Show resolved Hide resolved

SSE4 reviewed Mar 2, 2020

View reviewed changes

recipes/libcurl/all/conanfile.py Outdated Show resolved Hide resolved

SSE4 reviewed Mar 2, 2020

View reviewed changes

recipes/libcurl/all/conanfile.py Outdated Show resolved Hide resolved

SSE4 reviewed Mar 2, 2020

View reviewed changes

madebr mentioned this pull request Mar 2, 2020

Libcurl: update to msys2/20190524 + fix mingw build on Windows #862

Closed

4 tasks

a4z added 4 commits March 2, 2020 15:56

remove debug part

4c62603

changes from review

11f4259

* remove code doing nothing * use inbuild tools instead of self made functionality

remove bitcode option

fea1c47

use with tools.chdir

4496ea8

conan-center-bot added the Unexpected Error label Mar 2, 2020

danimtb mentioned this pull request Mar 2, 2020

[service] Not enough permissions to delete artifact #1020

Closed

conan-center-bot removed the Unexpected Error label Mar 5, 2020

a4z requested a review from SSE4 March 5, 2020 12:20

uilianries reviewed Mar 6, 2020

View reviewed changes

recipes/libcurl/all/conanfile.py Outdated Show resolved Hide resolved

uilianries reviewed Mar 6, 2020

View reviewed changes

recipes/libcurl/all/conanfile.py Outdated Show resolved Hide resolved

uilianries reviewed Mar 6, 2020

View reviewed changes

recipes/libcurl/all/conanfile.py Outdated Show resolved Hide resolved

uilianries reviewed Mar 6, 2020

View reviewed changes

recipes/libcurl/all/conanfile.py Outdated Show resolved Hide resolved

a4z added 2 commits March 6, 2020 14:39

use tools.rmdir for deleting directories

3b728f7

remove chdir to source folder in the hope conan-io#5165 will solve th…

3aaa3b7

…is one day

conan-center-bot added the Unexpected Error label Mar 6, 2020

conan-center-bot removed the Unexpected Error label Mar 6, 2020

build also with openssl on iOS

0fbc911

SSE4 approved these changes Mar 16, 2020

View reviewed changes

uilianries approved these changes Mar 25, 2020

View reviewed changes

SSE4 approved these changes Mar 25, 2020

View reviewed changes

danimtb approved these changes Mar 26, 2020

View reviewed changes

danimtb merged commit c63f9e9 into conan-io:master Mar 26, 2020

SSE4 mentioned this pull request Mar 26, 2020

Bugfix: change GNU triplet for iOS, watchOS, tvOS to allow simulator builds conan-io/conan#6748

Merged

5 tasks

a4z deleted the curlios branch April 7, 2020 06:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libcurl iOS build added #1008

libcurl iOS build added #1008

a4z commented Mar 1, 2020 •

edited

Loading

conan-center-bot commented Mar 1, 2020

a4z commented Mar 1, 2020

SSE4 Mar 2, 2020

a4z Mar 6, 2020

SSE4 Mar 2, 2020

a4z Mar 2, 2020

SSE4 Mar 2, 2020

a4z Mar 2, 2020

SSE4 Mar 2, 2020

a4z Mar 2, 2020

SSE4 Mar 2, 2020

a4z Mar 2, 2020

SSE4 Mar 2, 2020

a4z Mar 2, 2020

SSE4 Mar 2, 2020

a4z Mar 2, 2020

a4z Mar 2, 2020

SSE4 Mar 2, 2020

a4z Mar 2, 2020

uilianries Mar 18, 2020

conan-center-bot commented Mar 2, 2020

conan-center-bot commented Mar 2, 2020

danimtb commented Mar 2, 2020

conan-center-bot commented Mar 2, 2020

a4z commented Mar 3, 2020

conan-center-bot commented Mar 5, 2020

conan-center-bot commented Mar 6, 2020

conan-center-bot commented Mar 6, 2020

danimtb commented Mar 6, 2020

conan-center-bot commented Mar 6, 2020

conan-center-bot commented Mar 15, 2020

libcurl iOS build added #1008

libcurl iOS build added #1008

Conversation

a4z commented Mar 1, 2020 • edited Loading

conan-center-bot commented Mar 1, 2020

a4z commented Mar 1, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conan-center-bot commented Mar 2, 2020

conan-center-bot commented Mar 2, 2020

danimtb commented Mar 2, 2020

conan-center-bot commented Mar 2, 2020

a4z commented Mar 3, 2020

conan-center-bot commented Mar 5, 2020

conan-center-bot commented Mar 6, 2020

conan-center-bot commented Mar 6, 2020

danimtb commented Mar 6, 2020

conan-center-bot commented Mar 6, 2020

conan-center-bot commented Mar 15, 2020

a4z commented Mar 1, 2020 •

edited

Loading