gtest: Add support for Conan V2 #12326

jwillikers · 2022-08-18T02:37:29Z

Specify library name and version: gtest/*

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

jwillikers · 2022-08-18T11:51:05Z

Fails to build shared due to issue conan-io/conan#11840.

uilianries · 2022-08-18T14:36:40Z

@jwillikers You can use same workaround: https://github.com/conan-io/conan-center-index/pull/12110/files#diff-0d190e2175005f8bc838045b75be04ba9b92627a199259d8b056d7a8f236a858R59

jwillikers · 2022-08-18T15:07:49Z

@uilianries Thanks!

github-actions · 2022-08-18T15:19:44Z

Hooks produced the following warnings for commit fcad296

gtest/1.11.0

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock_main.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest_main.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock.so' links to system library 'm' but it is not in cpp_info.system_libs.

uilianries · 2022-08-19T07:49:44Z

I just re-triggered again. I could be a runtime error, that's why we don't see a message error.

github-actions · 2022-08-19T08:02:01Z

Hooks produced the following warnings for commit fcad296

gtest/cci.20210126

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock_maind.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest_maind.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmockd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtestd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock_main.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest_main.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock.so' links to system library 'm' but it is not in cpp_info.system_libs.

uilianries · 2022-08-19T10:20:07Z

It failed again, but no clue about.

github-actions · 2022-08-19T21:59:11Z

Hooks produced the following warnings for commit 55b5a59

gtest/1.10.0

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock_maind.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest_maind.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmockd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtestd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock_main.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest_main.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock.so' links to system library 'm' but it is not in cpp_info.system_libs.

github-actions · 2022-08-19T22:46:05Z

Hooks produced the following warnings for commit 4c57244

gtest/1.8.1

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock_main.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest_main.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock_maind.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest_maind.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmockd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtestd.so' links to system library 'm' but it is not in cpp_info.system_libs.

github-actions · 2022-08-19T23:11:16Z

Hooks produced the following warnings for commit 4987162

gtest/cci.20210126

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock_maind.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest_maind.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmockd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtestd.so' links to system library 'm' but it is not in cpp_info.system_libs.

jwillikers · 2022-08-20T22:04:46Z

It failed again, but no clue about.

@uilianries I fixed that issue, but now I've hit a weird one both here and in updates to the gtest Conan package in PR #12411.
There's a link error in the test package step when building with Clang and libstdc++.
I'm able to reproduce the link error locally with Conan 1.51.3, too.

github-actions · 2022-08-20T23:41:07Z

Hooks produced the following warnings for commit 56c6465

gtest/1.11.0

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtestd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock_main.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest_main.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock_maind.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest_maind.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmockd.so' links to system library 'm' but it is not in cpp_info.system_libs.

gtest/1.12.1

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock_main.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest_main.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock.so' links to system library 'm' but it is not in cpp_info.system_libs.

gtest/1.10.0

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock_main.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest_main.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock_maind.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest_maind.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmockd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtestd.so' links to system library 'm' but it is not in cpp_info.system_libs.

gtest/cci.20210126

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtestd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock_main.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest_main.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock_maind.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest_maind.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmockd.so' links to system library 'm' but it is not in cpp_info.system_libs.

gtest/1.8.1

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock_main.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest_main.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmock_maind.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtest_maind.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgmockd.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libgtestd.so' links to system library 'm' but it is not in cpp_info.system_libs.

uilianries

cache_variables is not needed in most cases.

recipes/gtest/all/conanfile.py

uilianries · 2022-08-22T13:19:35Z

It failed again, but no clue about.

@uilianries I fixed that issue, but now I've hit a weird one both here and in updates to the gtest Conan package in PR #12411. There's a link error in the test package step when building with Clang and libstdc++. I'm able to reproduce the link error locally with Conan 1.51.3, too.

Which error? Log?

jwillikers · 2022-08-22T16:13:54Z

It failed again, but no clue about.

@uilianries I fixed that issue, but now I've hit a weird one both here and in updates to the gtest Conan package in PR #12411. There's a link error in the test package step when building with Clang and libstdc++. I'm able to reproduce the link error locally with Conan 1.51.3, too.

Which error? Log?

Nvm, that was due to my incorrect change.

This reverts commit 5a34721.

conan-center-bot · 2022-08-23T17:07:17Z

All green in build 11 (729f25373a4f804a72f2f5de7f58515e0e4b5783):

gtest/1.12.1@:
All packages built successfully! (All logs)
gtest/1.11.0@:
All packages built successfully! (All logs)
gtest/cci.20210126@:
All packages built successfully! (All logs)
gtest/1.8.1@:
All packages built successfully! (All logs)
gtest/1.10.0@:
All packages built successfully! (All logs)

gtest/*: Add support for Conan V2

d92c84f

jwillikers changed the title ~~gtest/*: Add support for Conan V2~~ gtest: Add support for Conan V2 Aug 18, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Aug 18, 2022

jwillikers mentioned this pull request Aug 18, 2022

[bug] CMakeToolchain: BUILD_SHARED_LIBS & CMAKE_POSITION_INDEPENDENT_CODE not honored if CMP0077 OLD (or not set) and turned as options in upstream CMakeLists conan-io/conan#11840

Closed

jwillikers added 2 commits August 18, 2022 10:05

Work around BUILD_SHARED_LIBS issue

37c6201

Use src directory for source folder in CMake layout

fcad296

conan-center-bot removed the Failed label Aug 18, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Aug 18, 2022

conan-center-bot removed the Failed label Aug 19, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Aug 19, 2022

Fix minimum CMake version

55b5a59

conan-center-bot removed the Failed label Aug 19, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Aug 19, 2022

Fix preprocessor definitions

4c57244

conan-center-bot removed the Failed label Aug 19, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Aug 19, 2022

Fix more preprocessor definitions

4987162

conan-center-bot removed the Failed label Aug 19, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Aug 19, 2022

Revert configure options

56c6465

conan-center-bot removed the Failed label Aug 20, 2022

github-actions bot mentioned this pull request Aug 20, 2022

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This comment has been minimized.

Sign in to view

Require the system library libm

d0116df

This comment has been minimized.

Sign in to view

Enclose ANY option value in a list

ff11b2a

This comment has been minimized.

Sign in to view

uilianries reviewed Aug 22, 2022

View reviewed changes

recipes/gtest/all/conanfile.py Show resolved Hide resolved

recipes/gtest/all/conanfile.py Show resolved Hide resolved

recipes/gtest/all/conanfile.py Show resolved Hide resolved

recipes/gtest/all/conanfile.py Show resolved Hide resolved

Use toolchain variables instead of cache_variables

5a34721

This comment has been minimized.

Sign in to view

uilianries previously approved these changes Aug 23, 2022

View reviewed changes

jcar87 mentioned this pull request Aug 23, 2022

[question] CMakeToolchain: When use cached_variables vs variables conan-io/conan#11937

Open

1 task

Revert "Use toolchain variables instead of cache_variables"

729f253

This reverts commit 5a34721.

jwillikers dismissed uilianries’s stale review via 729f253 August 23, 2022 13:20

uilianries approved these changes Aug 23, 2022

View reviewed changes

toge approved these changes Aug 26, 2022

View reviewed changes

conan-center-bot merged commit 6a041d2 into conan-io:master Aug 26, 2022

jwillikers deleted the gtest-conan-v2 branch August 26, 2022 18:07

prince-chrismc mentioned this pull request Sep 9, 2022

Conan 2.0 Migration Effort #12888

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gtest: Add support for Conan V2 #12326

gtest: Add support for Conan V2 #12326

jwillikers commented Aug 18, 2022

This comment has been minimized.

jwillikers commented Aug 18, 2022

uilianries commented Aug 18, 2022

jwillikers commented Aug 18, 2022

This comment has been minimized.

github-actions bot commented Aug 18, 2022

uilianries commented Aug 19, 2022

This comment has been minimized.

github-actions bot commented Aug 19, 2022

uilianries commented Aug 19, 2022

This comment has been minimized.

github-actions bot commented Aug 19, 2022

This comment has been minimized.

github-actions bot commented Aug 19, 2022

This comment has been minimized.

github-actions bot commented Aug 19, 2022

jwillikers commented Aug 20, 2022

This comment has been minimized.

github-actions bot commented Aug 20, 2022

This comment has been minimized.

This comment has been minimized.

uilianries left a comment

uilianries commented Aug 22, 2022

jwillikers commented Aug 22, 2022

This comment has been minimized.

conan-center-bot commented Aug 23, 2022

gtest: Add support for Conan V2 #12326

gtest: Add support for Conan V2 #12326

Conversation

jwillikers commented Aug 18, 2022

This comment has been minimized.

jwillikers commented Aug 18, 2022

uilianries commented Aug 18, 2022

jwillikers commented Aug 18, 2022

This comment has been minimized.

github-actions bot commented Aug 18, 2022

uilianries commented Aug 19, 2022

This comment has been minimized.

github-actions bot commented Aug 19, 2022

uilianries commented Aug 19, 2022

This comment has been minimized.

github-actions bot commented Aug 19, 2022

This comment has been minimized.

github-actions bot commented Aug 19, 2022

This comment has been minimized.

github-actions bot commented Aug 19, 2022

jwillikers commented Aug 20, 2022

This comment has been minimized.

github-actions bot commented Aug 20, 2022

This comment has been minimized.

This comment has been minimized.

uilianries left a comment

Choose a reason for hiding this comment

uilianries commented Aug 22, 2022

jwillikers commented Aug 22, 2022

This comment has been minimized.

conan-center-bot commented Aug 23, 2022