Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pango] use v2 toolchains #12382

Closed
wants to merge 19 commits into from

Conversation

planetmarshall
Copy link
Contributor

Specify library name and version: pango/

v2 linting and use of set_property_name


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

@planetmarshall please, update glib version to the latest. I regenerated harfbuzz and passed from the last failed step.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

def rename_msvc_libs():
lib_folder = os.path.join(self.package_folder, "lib")
for filename_old in glob.glob(os.path.join(lib_folder, "*.a")):
filename_new = filename_old[3:-2] + ".lib"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
filename_new = filename_old[3:-2] + ".lib"
filename_new = os.path.join(lib_folder, os.path.basename(filename_old)[3:-2] + ".lib")

@db4
Copy link
Contributor

db4 commented Apr 17, 2023

@planetmarshall, are you planning to complete this?

@CLAassistant
Copy link

CLAassistant commented May 18, 2023

CLA assistant check
All committers have signed the CLA.

@ghost ghost mentioned this pull request May 22, 2023
3 tasks
@ghost
Copy link

ghost commented May 22, 2023

I detected other pull requests that are modifying pango/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@stale
Copy link

stale bot commented Jun 23, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 25 (d25e120f8aae698ef79ae5f92946cf51e86ba589):

  • pango/1.48.9@:
    Didn't run or was cancelled before finishing

  • pango/1.50.7@:
    CI failed to create some packages (All logs)

    Logs for packageID a0021f252badfeb4938e774c37148fd6583deb2d:
    [settings]
    arch=x86_64
    build_type=Debug
    compiler=apple-clang
    compiler.libcxx=libc++
    compiler.version=13.0
    os=Macos
    [options]
    pango:shared=False
    
    [...]
    [12/45] Compiling C object pango/libpango-1.0.a.p/pango-attributes.c.o
    [13/45] Compiling C object pango/libpango-1.0.a.p/pango-coverage.c.o
    [14/45] Compiling C object pango/libpango-1.0.a.p/pango-context.c.o
    [15/45] Compiling C object pango/libpango-1.0.a.p/pango-emoji.c.o
    [16/45] Compiling C object pango/libpango-1.0.a.p/pango-engine.c.o
    [17/45] Compiling C object pango/libpango-1.0.a.p/pango-fontset-simple.c.o
    [18/45] Compiling C object pango/libpango-1.0.a.p/pango-fontset.c.o
    [19/45] Compiling C object pango/libpango-1.0.a.p/pango-fontmap.c.o
    [20/45] Compiling C object pango/libpango-1.0.a.p/pango-glyph-item.c.o
    [21/45] Compiling C object pango/libpango-1.0.a.p/pango-gravity.c.o
    [22/45] Compiling C object pango/libpango-1.0.a.p/pango-item.c.o
    [23/45] Compiling C object pango/libpango-1.0.a.p/pango-matrix.c.o
    [24/45] Compiling C object pango/libpango-1.0.a.p/pango-markup.c.o
    [25/45] Compiling C object pango/libpango-1.0.a.p/pango-language.c.o
    [26/45] Compiling C object pango/libpango-1.0.a.p/pango-script.c.o
    [27/45] Compiling C object pango/libpango-1.0.a.p/pango-renderer.c.o
    [28/45] Compiling C object pango/libpango-1.0.a.p/pango-layout.c.o
    [29/45] Compiling C object pango/libpango-1.0.a.p/pango-tabs.c.o
    [30/45] Compiling C object pango/libpango-1.0.a.p/pango-utils.c.o
    [31/45] Compiling C object pango/libpango-1.0.a.p/reorder-items.c.o
    [32/45] Compiling C object pango/libpango-1.0.a.p/shape.c.o
    [33/45] Compiling C object pango/libpango-1.0.a.p/serializer.c.o
    [34/45] Compiling C object pango/libpango-1.0.a.p/json_gtkjsonprinter.c.o
    [35/45] Compiling C object pango/libpango-1.0.a.p/json_gtkjsonparser.c.o
    [36/45] Linking static target pango/libpango-1.0.a
    [37/45] Compiling C object pango/libpangocairo-1.0.a.p/pangocairo-context.c.o
    [38/45] Compiling C object pango/libpangocairo-1.0.a.p/pangocairo-font.c.o
    [39/45] Compiling C object pango/libpangocairo-1.0.a.p/pangocairo-render.c.o
    [40/45] Compiling C object pango/libpangocairo-1.0.a.p/pangocoretext.c.o
    FAILED: pango/libpangocairo-1.0.a.p/pangocoretext.c.o 
    clang -Ipango/libpangocairo-1.0.a.p -Ipango -I../src/pango -I. -I../src -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/bzip2/1.0.8/_/_/package/a354ec84d9aa7012cfbeb01b59c5daa2780bb252/include -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/glib/2.75.2/_/_/package/f7e06d8bb9b376a5458cccda75aacd93afa8c007/include -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/glib/2.75.2/_/_/package/f7e06d8bb9b376a5458cccda75aacd93afa8c007/include/glib-2.0 -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/glib/2.75.2/_/_/package/f7e06d8bb9b376a5458cccda75aacd93afa8c007/lib/glib-2.0/include -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/libiconv/1.17/_/_/package/f0ce0f189afed95b41fb2faad2f2225a7eca0d22/include -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/pcre2/10.42/_/_/package/bfe27188ce1586f299c1a16f76982ce58c188ee2/include -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/zlib/1.2.13/_/_/package/f0ce0f189afed95b41fb2faad2f2225a7eca0d22/include -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/libgettext/0.21/_/_/package/37b273fdb3cb050132a55c416d3ca02f66d01df5/include -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/libffi/3.4.4/_/_/package/f0ce0f189afed95b41fb2faad2f2225a7eca0d22/include -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/fribidi/1.0.12/_/_/package/13f489dc6b85075acc4dea40c390189130f3631a/include -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/fribidi/1.0.12/_/_/package/13f489dc6b85075acc4dea40c390189130f3631a/include/fribidi -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/libelf/0.8.13/_/_/package/f0ce0f189afed95b41fb2faad2f2225a7eca0d22/include -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/libelf/0.8.13/_/_/package/f0ce0f189afed95b41fb2faad2f2225a7eca0d22/include/libelf -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/glib/2.75.2/_/_/package/f7e06d8bb9b376a5458cccda75aacd93afa8c007/include/gio-unix-2.0 -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/harfbuzz/6.0.0/_/_/package/7bae546a60cc63a1c0c39d40470d4b1382971c95/include -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/harfbuzz/6.0.0/_/_/package/7bae546a60cc63a1c0c39d40470d4b1382971c95/include/harfbuzz -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/freetype/2.13.0/_/_/package/41f5f66f7d00992efb1870bcfaf56b01c679aed8/include -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/freetype/2.13.0/_/_/package/41f5f66f7d00992efb1870bcfaf56b01c679aed8/include/freetype2 -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/libpng/1.6.39/_/_/package/93d0d0ac1c261471eea08ce1f0d5d7aaf2b280ca/include -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/brotli/1.0.9/_/_/package/7b13aac265b6cd52c8312b07b2769a17e970b036/include -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/brotli/1.0.9/_/_/package/7b13aac265b6cd52c8312b07b2769a17e970b036/include/brotli -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/fontconfig/2.14.2/_/_/package/dc65abfe99a711449f2a3c63f1cc57414799cb5d/include -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/pixman/0.40.0/_/_/package/f0ce0f189afed95b41fb2faad2f2225a7eca0d22/include -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/pixman/0.40.0/_/_/package/f0ce0f189afed95b41fb2faad2f2225a7eca0d22/include/pixman-1 -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/cairo/1.17.6/_/_/package/4947144c63aec1938407a20e3470015ee4e7a2e6/include/cairo -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/cairo/1.17.6/_/_/package/4947144c63aec1938407a20e3470015ee4e7a2e6/include -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/lzo/2.10/_/_/package/f0ce0f189afed95b41fb2faad2f2225a7eca0d22/include -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/lzo/2.10/_/_/package/f0ce0f189afed95b41fb2faad2f2225a7eca0d22/include/lzo -I/Users/jenkins/w/prod/BuildSingleReference/.conan/data/expat/2.5.0/_/_/package/a2fdc7f179bbe8c5db4c842ce67a3799914f233c/include -fcolor-diagnostics -Wall -Winvalid-pch -std=gnu99 -O0 -g -D_POSIX_C_SOURCE=200809L -D_POSIX_THREAD_SAFE_FUNCTIONS -D_GNU_SOURCE -isysroot /Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk -arch x86_64 -DXML_STATIC -DFRIBIDI_LIB_STATIC -DFFI_BUILDING -DPCRE2_STATIC -Wno-c++11-extensions -Wno-missing-include-dirs -Wno-typedef-redefinition -Wformat=2 -Wformat-nonliteral -Wformat-security -Wignored-qualifiers -Wimplicit-function-declaration -Wmisleading-indentation -Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wnested-externs -Wold-style-definition -Wpointer-arith -Wshadow -Wstrict-prototypes -Wswitch-default -Wswitch-enum -Wundef -Wuninitialized -Wunused -Werror=address -Werror=array-bounds -Werror=empty-body -Werror=implicit -Werror=implicit-fallthrough -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=missing-declarations -Werror=missing-prototypes -Werror=nonnull -Werror=pointer-to-int-cast -Werror=redundant-decls -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=vla -Werror=write-strings -fno-strict-aliasing -Wpointer-arith -Wmissing-declarations -Wformat=2 -Wformat-nonliteral -Wformat-security -Wunused -Wcast-align -Wmissing-noreturn -Wmissing-format-attribute -Wmissing-include-dirs -Wno-uninitialized -Wno-shadow -Werror=implicit-fallthrough -Werror=nonnull -Werror=init-self -Werror=main -Werror=missing-braces -Werror=sequence-point -Werror=return-type -Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address -Werror=int-to-pointer-cast -Werror=empty-body -Werror=write-strings -Wundef -Werror=redundant-decls -DPANGO_ENABLE_DEBUG '-DG_LOG_DOMAIN="Pango"' -DG_LOG_USE_STRUCTURED=1 -DPANGO_COMPILATION '-DSYSCONFDIR="/Users/jenkins/w/prod/BuildSingleReference/.conan/data/pango/1.50.7/_/_/package/a0021f252badfeb4938e774c37148fd6583deb2d/etc"' '-DLIBDIR="/Users/jenkins/w/prod/BuildSingleReference/.conan/data/pango/1.50.7/_/_/package/a0021f252badfeb4938e774c37148fd6583deb2d/lib"' -DPANGO_DISABLE_DEPRECATION_WARNINGS -MD -MQ pango/libpangocairo-1.0.a.p/pangocoretext.c.o -MF pango/libpangocairo-1.0.a.p/pangocoretext.c.o.d -o pango/libpangocairo-1.0.a.p/pangocoretext.c.o -c ../src/pango/pangocoretext.c
    ../src/pango/pangocoretext.c:27:10: fatal error: 'hb-coretext.h' file not found
    #include <hb-coretext.h>
             ^~~~~~~~~~~~~~~
    1 error generated.
    [41/45] Compiling C object pango/libpangocairo-1.0.a.p/pangocairo-fontmap.c.o
    [42/45] Compiling C object pango/libpangocairo-1.0.a.p/pangocoretext-fontmap.c.o
    [43/45] Compiling C object pango/libpangocairo-1.0.a.p/pangocairo-coretextfont.c.o
    ninja: build stopped: subcommand failed.
    INFO: autodetecting backend as ninja
    INFO: calculating backend command to run: /Users/jenkins/w/prod/BuildSingleReference/.conan/data/ninja/1.11.1/_/_/package/907cb07dbeb8f7bacd51a5119560f14986d21b20/bin/ninja -j 4
    pango/1.50.7: 
    
    Generating targets:   0%|                                                     | 0/4 [00:00<?, ?it/s]
                                                                                                        
    
    Writing build.ninja:   0%|                                                   | 0/73 [00:00<?, ?it/s]
                                                                                                        
    WARN: cairo/1.17.6: requirement glib/2.76.3 overridden by pango/1.50.7 to glib/2.75.2 
    WARN: harfbuzz/6.0.0: requirement glib/2.76.3 overridden by pango/1.50.7 to glib/2.75.2 
    pango/1.50.7: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    pango/1.50.7: ERROR: Package 'a0021f252badfeb4938e774c37148fd6583deb2d' build failed
    pango/1.50.7: WARN: Build folder /Users/jenkins/w/prod/BuildSingleReference/.conan/data/pango/1.50.7/_/_/build/a0021f252badfeb4938e774c37148fd6583deb2d/build-debug
    ERROR: pango/1.50.7: Error in build() method, line 151
    	meson.build()
    	ConanException: Error 1 while executing meson compile -C "/Users/jenkins/w/prod/BuildSingleReference/.conan/data/pango/1.50.7/_/_/build/a0021f252badfeb4938e774c37148fd6583deb2d/build-debug" -j4
    
  • pango/1.49.3@:
    Didn't run or was cancelled before finishing

  • pango/1.50.10@:
    Didn't run or was cancelled before finishing

  • pango/1.50.8@:
    Didn't run or was cancelled before finishing

  • pango/1.50.12@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 22 (d25e120f8aae698ef79ae5f92946cf51e86ba589):

  • pango/1.50.8@:
    Error running command conan graph info --requires pango/1.50.8@#8fa7c96377a627e49fec42461be10a06 -f json -pr:h /home/conan/w/prod-v2_cci_PR-12382/22/16637f97-fbaf-40b7-9439-32bcd4f9b662/profile_linux_11_libstdcpp11_gnu17_gcc_release_64.-shared-False.txt -pr:b /home/conan/w/prod-v2_cci_PR-12382/22/16637f97-fbaf-40b7-9439-32bcd4f9b662/profile_linux_11_libstdcpp11_gnu17_gcc_release_64.-shared-False.txt:

    ======== Computing dependency graph ========
    ERROR: pango/1.50.8: Error in configure() method, line 64
    	self.options.with_xft = self.settings.os in ["Linux", "FreeBSD"]
    	ConanException: Incorrect attempt to modify option 'with_xft' from 'auto' to 'True'
    
  • pango/1.49.3@:
    Error running command conan graph info --requires pango/1.49.3@#6b953dce7ad9ed7104a361879ee3cd28 -f json -pr:h /home/conan/w/prod-v2_cci_PR-12382/22/0eebc134-5d14-4c4d-b013-d5c4e64424cd/profile_linux_11_libstdcpp11_gnu17_gcc_release_64.-shared-False.txt -pr:b /home/conan/w/prod-v2_cci_PR-12382/22/0eebc134-5d14-4c4d-b013-d5c4e64424cd/profile_linux_11_libstdcpp11_gnu17_gcc_release_64.-shared-False.txt:

    ======== Computing dependency graph ========
    ERROR: pango/1.49.3: Error in configure() method, line 64
    	self.options.with_xft = self.settings.os in ["Linux", "FreeBSD"]
    	ConanException: Incorrect attempt to modify option 'with_xft' from 'auto' to 'True'
    
  • pango/1.48.9@:
    Error running command conan graph info --requires pango/1.48.9@#c2fc3dc64baca83e2f9e14f40f92783b -f json -pr:h /home/conan/w/prod-v2_cci_PR-12382/22/d7e1c5cb-d72c-4b6b-adfe-24c30b4dd8da/profile_linux_11_libstdcpp11_gnu17_gcc_release_64.-shared-False.txt -pr:b /home/conan/w/prod-v2_cci_PR-12382/22/d7e1c5cb-d72c-4b6b-adfe-24c30b4dd8da/profile_linux_11_libstdcpp11_gnu17_gcc_release_64.-shared-False.txt:

    ======== Computing dependency graph ========
    ERROR: pango/1.48.9: Error in configure() method, line 64
    	self.options.with_xft = self.settings.os in ["Linux", "FreeBSD"]
    	ConanException: Incorrect attempt to modify option 'with_xft' from 'auto' to 'True'
    
  • pango/1.50.12@:
    Error running command conan graph info --requires pango/1.50.12@#f77761f7785ca09d1823807f2d85ea26 -f json -pr:h /home/conan/w/prod-v2_cci_PR-12382/22/5da599b2-5f50-436e-b793-8f1e56a637f1/profile_linux_11_libstdcpp11_gnu17_gcc_release_64.-shared-False.txt -pr:b /home/conan/w/prod-v2_cci_PR-12382/22/5da599b2-5f50-436e-b793-8f1e56a637f1/profile_linux_11_libstdcpp11_gnu17_gcc_release_64.-shared-False.txt:

    ======== Computing dependency graph ========
    ERROR: pango/1.50.12: Error in configure() method, line 64
    	self.options.with_xft = self.settings.os in ["Linux", "FreeBSD"]
    	ConanException: Incorrect attempt to modify option 'with_xft' from 'auto' to 'True'
    
  • pango/1.50.10@:
    Error running command conan graph info --requires pango/1.50.10@#f77ac2f7977e19caa92439da298d3ee4 -f json -pr:h /home/conan/w/prod-v2_cci_PR-12382/22/71cc2de2-f8b6-44aa-9528-4d476f15121e/profile_linux_11_libstdcpp11_gnu17_gcc_release_64.-shared-False.txt -pr:b /home/conan/w/prod-v2_cci_PR-12382/22/71cc2de2-f8b6-44aa-9528-4d476f15121e/profile_linux_11_libstdcpp11_gnu17_gcc_release_64.-shared-False.txt:

    ======== Computing dependency graph ========
    ERROR: pango/1.50.10: Error in configure() method, line 64
    	self.options.with_xft = self.settings.os in ["Linux", "FreeBSD"]
    	ConanException: Incorrect attempt to modify option 'with_xft' from 'auto' to 'True'
    
  • pango/1.50.7@:
    Error running command conan graph info --requires pango/1.50.7@#c34e8c7bb56b452e4b9d09b5677d13b6 -f json -pr:h /home/conan/w/prod-v2_cci_PR-12382/22/372ca65d-221a-4056-ba10-55aa83f2a982/profile_linux_11_libstdcpp11_gnu17_gcc_release_64.-shared-False.txt -pr:b /home/conan/w/prod-v2_cci_PR-12382/22/372ca65d-221a-4056-ba10-55aa83f2a982/profile_linux_11_libstdcpp11_gnu17_gcc_release_64.-shared-False.txt:

    ======== Computing dependency graph ========
    ERROR: pango/1.50.7: Error in configure() method, line 64
    	self.options.with_xft = self.settings.os in ["Linux", "FreeBSD"]
    	ConanException: Incorrect attempt to modify option 'with_xft' from 'auto' to 'True'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@ghost ghost mentioned this pull request Jul 9, 2023
3 tasks
@ghost ghost mentioned this pull request Jul 24, 2023
@ghost ghost mentioned this pull request Aug 31, 2023
3 tasks
@ghost ghost mentioned this pull request Oct 28, 2023
3 tasks
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 13, 2024
@ghost ghost mentioned this pull request Mar 4, 2024
2 tasks
@planetmarshall planetmarshall deleted the pango-modernize branch March 4, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants