Approvaltests conan v2

[rockdreamer]

Specify library name and version: approvaltests/

Migration to v2 after workshop with @prince-chrismc

---

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the conan-center hook activated.

[conan-center-bot]

Conan v1 pipeline

Failure in build 1 (ad1a8318f9d085553fb330761488be83d6d5825c):

• approvaltests.cpp/9.0.0@:
  Didn't run or was cancelled before finishing

• approvaltests.cpp/10.12.0@:
  CI failed to create some packages (All logs)

  Logs for packageID 5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9:

  [settings]
  arch=x86_64
  build_type=Release
  compiler=gcc
  compiler.libcxx=libstdc++11
  compiler.version=5
  os=Linux
  

  [...]
  > cd '/home/conan/w/prod/BuildSingleReference/conan-center-index/recipes/approvaltests.cpp/all/test_v1_package/build/aa812f66cc25d52e62cde1f093beffcc1fbfe3f8' && cmake -G "Unix Makefiles" -DCMAKE_BUILD_TYPE="Release" -DCONAN_IN_LOCAL_CACHE="OFF" -DCONAN_COMPILER="gcc" -DCONAN_COMPILER_VERSION="5" -DCONAN_CXX_FLAGS="-m64" -DCONAN_SHARED_LINKER_FLAGS="-m64" -DCONAN_C_FLAGS="-m64" -DCONAN_LIBCXX="libstdc++11" -DCMAKE_INSTALL_PREFIX="/home/conan/w/prod/BuildSingleReference/conan-center-index/recipes/approvaltests.cpp/all/test_v1_package/build/aa812f66cc25d52e62cde1f093beffcc1fbfe3f8/package" -DCMAKE_INSTALL_BINDIR="bin" -DCMAKE_INSTALL_SBINDIR="bin" -DCMAKE_INSTALL_LIBEXECDIR="bin" -DCMAKE_INSTALL_LIBDIR="lib" -DCMAKE_INSTALL_INCLUDEDIR="include" -DCMAKE_INSTALL_OLDINCLUDEDIR="include" -DCMAKE_INSTALL_DATAROOTDIR="share" -DCMAKE_PREFIX_PATH="/home/conan/w/prod/BuildSingleReference/conan-center-index/recipes/approvaltests.cpp/all/test_v1_package/build/aa812f66cc25d52e62cde1f093beffcc1fbfe3f8" -DCMAKE_MODULE_PATH="/home/conan/w/prod/BuildSingleReference/conan-center-index/recipes/approvaltests.cpp/all/test_v1_package/build/aa812f66cc25d52e62cde1f093beffcc1fbfe3f8" -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY="ON" -DCONAN_EXPORTED="1" -Wno-dev '/home/conan/w/prod/BuildSingleReference/conan-center-index/recipes/approvaltests.cpp/all/test_v1_package'
  -----------------
  -- The C compiler identification is GNU 5.4.0
  -- The CXX compiler identification is GNU 5.4.0
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - done
  -- Check for working C compiler: /usr/bin/gcc - skipped
  -- Detecting C compile features
  -- Detecting C compile features - done
  -- Detecting CXX compiler ABI info
  -- Detecting CXX compiler ABI info - done
  -- Check for working CXX compiler: /usr/bin/g++ - skipped
  -- Detecting CXX compile features
  -- Detecting CXX compile features - done
  -- Conan: called by CMake conan helper
  -- Conan: Adjusting output directories
  -- Conan: Using cmake targets configuration
  -- Conan: Adjusting default RPATHs Conan policies
  -- Conan: Adjusting language standard
  -- Conan: Compiler GCC>=5, checking major version 5
  -- Conan: Checking correct version: 5
  -- Conan: C++ stdlib: libstdc++11
  -- Configuring done
  -- Generating done
  -- Build files have been written to: /home/conan/w/prod/BuildSingleReference/conan-center-index/recipes/approvaltests.cpp/all/test_v1_package/build/aa812f66cc25d52e62cde1f093beffcc1fbfe3f8
  
  ----Running------
  > cmake --build '/home/conan/w/prod/BuildSingleReference/conan-center-index/recipes/approvaltests.cpp/all/test_v1_package/build/aa812f66cc25d52e62cde1f093beffcc1fbfe3f8' '--' '-j3'
  -----------------
  Scanning dependencies of target test_package
  [ 50%] Building CXX object CMakeFiles/test_package.dir/home/conan/w/prod/BuildSingleReference/conan-center-index/recipes/approvaltests.cpp/all/test_package/test_package.cpp.o
  [100%] Linking CXX executable bin/test_package
  [100%] Built target test_package
  approvaltests.cpp/10.12.0 (test package): Running test()
  
  ----Running------
  > bin/test_package
  -----------------
  42
  CMake Warning:
    Manually-specified variables were not used by the project:
  
      CMAKE_EXPORT_NO_PACKAGE_REGISTRY
      CMAKE_INSTALL_BINDIR
      CMAKE_INSTALL_DATAROOTDIR
      CMAKE_INSTALL_INCLUDEDIR
      CMAKE_INSTALL_LIBDIR
      CMAKE_INSTALL_LIBEXECDIR
      CMAKE_INSTALL_OLDINCLUDEDIR
      CMAKE_INSTALL_SBINDIR
  

• approvaltests.cpp/10.12.2@:
  Didn't run or was cancelled before finishing

• approvaltests.cpp/10.9.1@:
  Didn't run or was cancelled before finishing

• approvaltests.cpp/8.9.2@:
  Didn't run or was cancelled before finishing

• approvaltests.cpp/10.10.0@:
  Didn't run or was cancelled before finishing

• approvaltests.cpp/10.11.0@:
  Didn't run or was cancelled before finishing

• approvaltests.cpp/10.12.1@:
  Didn't run or was cancelled before finishing

---

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

[prince-chrismc]

🤔 ill need to ask how to do this not sure myself

[uilianries]

it's not possible 😞 : conan-io/conan#12411

[prince-chrismc]

Option A but I doubt this is exposed

Suggested change

	return Version(self.dependencies["approvaltests.cpp"].ref.version) >= "8.6.0"
	return Version(self.tested_reference_str) >= "8.6.0"

We can always save the value during requires then reuse it here 🤔

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.