Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch2: add console_width parameter #14475

Merged
merged 7 commits into from
Dec 15, 2022

Conversation

agilemapper
Copy link
Contributor

Specify library name and version: catch2/3.x

catch2 has a build parameter which can set the width of the console. By default it is 80, but in some cases it might be good to make this wider. I set up an arbitrary upper bound in this PR.

I am not sure if for such a small change I need to Request access - as it is also not a new package. But in any case let me know.


@CLAassistant
Copy link

CLAassistant commented Nov 28, 2022

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Nov 28, 2022

I detected other pull requests that are modifying catch2/3.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updated conventions :)

recipes/catch2/3.x.x/conanfile.py Outdated Show resolved Hide resolved
recipes/catch2/3.x.x/conanfile.py Outdated Show resolved Hide resolved
recipes/catch2/3.x.x/conanfile.py Outdated Show resolved Hide resolved
@agilemapper
Copy link
Contributor Author

Just updated conventions :)

Thanks for the review @prince-chrismc! I'll check locally if everything works as intended with your proposed changes.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments but this looks really good!

@ghost ghost mentioned this pull request Dec 12, 2022
4 tasks
@agilemapper
Copy link
Contributor Author

Two small comments but this looks really good!

Thanks for the review again and sorry for delay in responding. Nice improvements. Let me know if something else needs to be done.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline

All green in build 7 (754ab4c286e59866336e23696dc1f84c5bd133e8):

  • catch2/3.2.1@:
    All packages built successfully! (All logs)

  • catch2/3.2.0@:
    All packages built successfully! (All logs)

  • catch2/3.0.1@:
    All packages built successfully! (All logs)

  • catch2/3.1.0@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 91c2d31 into conan-io:master Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants