Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limereport: add library #17841

Merged
merged 32 commits into from
Jun 17, 2024
Merged

limereport: add library #17841

merged 32 commits into from
Jun 17, 2024

Conversation

xakod
Copy link
Contributor

@xakod xakod commented Jun 6, 2023

Specify library name and version: limereport/1.7.4


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Jul 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 15, 2023
@xakod xakod closed this Jul 19, 2023
@xakod xakod reopened this Jul 19, 2023
@stale stale bot removed the stale label Jul 19, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

perseoGI
perseoGI previously approved these changes Jun 11, 2024
@perseoGI perseoGI requested a review from uilianries June 11, 2024 12:50
Signed-off-by: Uilian Ries <[email protected]>
@conan-center-bot

This comment has been minimized.

Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Copy link
Member

Just add a new update in the recipe: 2793e6f

The zint project is marked as private by limereport because is built as vendorized project and as static library. Still, it's a regular requirement, not a build requirement. Also, zint has an option to generate QZint, it requires Qt as dependency, but is not enabled by default.

@conan-center-bot

This comment has been minimized.

Signed-off-by: Uilian Ries <[email protected]>
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 12 (d34c4a8328edf273e55a34c9ee73bf85cc6b88d9):

  • limereport/1.7.4:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 12 (d34c4a8328edf273e55a34c9ee73bf85cc6b88d9):

  • limereport/1.7.4:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Checked locally. This package will not be building in ConanCenterIndex CI because requires custom options for Qt that are not enable by default.

In case zint is requires (optional), it will require Qt as well. In CCI the zint package is not built with Qt, but there is an option.

@uilianries uilianries requested a review from AbrilRBS June 17, 2024 08:55
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @uilianries getting this PR thru to the finish line, I know it's been quite hard :)

@conan-center-bot conan-center-bot merged commit 3e8615e into conan-io:master Jun 17, 2024
13 checks passed
@uilianries
Copy link
Member

Finally merged. Thank you @Jihadist for all your effort!

@xakod xakod deleted the limereport branch June 18, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants