-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
limereport: add library #17841
limereport: add library #17841
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <[email protected]>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <[email protected]>
Just add a new update in the recipe: 2793e6f The zint project is marked as private by limereport because is built as vendorized project and as static library. Still, it's a regular requirement, not a build requirement. Also, zint has an option to generate QZint, it requires Qt as dependency, but is not enabled by default. |
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <[email protected]>
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 12 (
Conan v2 pipeline ✔️
All green in build 12 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Checked locally. This package will not be building in ConanCenterIndex CI because requires custom options for Qt that are not enable by default.
In case zint is requires (optional), it will require Qt as well. In CCI the zint package is not built with Qt, but there is an option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @uilianries getting this PR thru to the finish line, I know it's been quite hard :)
Finally merged. Thank you @Jihadist for all your effort! |
Specify library name and version: limereport/1.7.4