Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add package for the rocket library #20151

Merged
merged 10 commits into from
Jun 18, 2024

Conversation

Slashcash
Copy link
Contributor

rocket/2.0

This PR adds a Conan Package for the rocket C++ library. It is a library that implements the observer pattern with a single-header approach. I am not the author of the library.

Testing with the conan hooks activated doesn't seem to work for Conan 2


@CLAassistant
Copy link

CLAassistant commented Sep 25, 2023

CLA assistant check
All committers have signed the CLA.

@AbrilRBS
Copy link
Member

Thanks for your contribution! The bot run twice per week to give you access to the CI, but it's skipped the last few due to the current maintenance, you'll be added in the next one, thanks a lot for your patience :)

@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

AbrilRBS commented Oct 2, 2023

You updated the PR top fast, it's now properly running :)

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@Slashcash
Copy link
Contributor Author

What's happening here? I have requested and have been given access but v2 pipeline still continuously failing on me because apparently I miss access? :(

@perseoGI perseoGI self-requested a review June 14, 2024 11:09
@perseoGI perseoGI self-assigned this Jun 14, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

perseoGI
perseoGI previously approved these changes Jun 17, 2024
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally... It works! 🚀 man!

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

recipes/rocket/all/conandata.yml Show resolved Hide resolved
recipes/rocket/all/conanfile.py Outdated Show resolved Hide resolved
recipes/rocket/all/test_v1_package/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Only following @RubenRBS comments.

rocket

recipes/rocket/all/conanfile.py Show resolved Hide resolved
@Slashcash
Copy link
Contributor Author

I was surprised to see this one brought back to life!
Thanks a lot guys <3

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 9 (9f748a6987037be474eb3363827e4bde89bebc0b):

  • rocket/cci.20200603:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 10 (9f748a6987037be474eb3363827e4bde89bebc0b):

  • rocket/cci.20200603:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 2874bcd into conan-io:master Jun 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants