Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libsystemd: Include libudev #20290

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

jwillikers
Copy link
Contributor

Specify library name and version: libsystemd/*

Include the udev library as a component of the libsystemd package.
Update Meson version.
Add provides = "libudev" to allow other providers of the libudev library, i.e. eudev.
It seems like the provides should be related to the libudev component instead of the entire package.
Is this possible?

I wasn't sure whether to add a separate package for libudev, i.e. something under libudev/all, or to include it as part of the libsystemd package.
In light of the fact that a separate package requires more resources to maintain, I opted for including it in the libsystemd package.
This will require only updating one package in CCI instead of two, at the cost of flexibility for managing libudev and libsystemd in distinct ways, i.e. trying to build one shared and the other static.


@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Hooks produced the following warnings for commit 58e8085
libsystemd/253.6@#0e9ee2ad078aeeb072105d299b038ec3
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Running objdump on './lib/libudev.so' failed. Is the environment variable OBJDUMP correctly configured?

@jwillikers jwillikers mentioned this pull request Oct 4, 2023
6 tasks
@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

AbrilRBS commented Oct 5, 2023

It seems like the provides should be related to the libudev component instead of the entire package.
Is this possible?

Not as far as I know, no. I've added this recipe to our next team review meeting, will let you

@AbrilRBS AbrilRBS self-assigned this Oct 5, 2023
@conan-center-bot

This comment has been minimized.

@jwillikers
Copy link
Contributor Author

Looks like it is most likely a compiler bug causing the compilation error and not an actual issue with the project. I wonder if it's the version of GCC 9 in CI causing problems.

@jwillikers
Copy link
Contributor Author

Yep, works with GCC 9.4. I'll add a workaround similar to Qt 6.

@conan-center-bot

This comment has been minimized.

Copy link

stale bot commented Dec 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@jwillikers
Copy link
Contributor Author

This PR is necessary for #20358, which requires a newer version of libudev than is available in CI.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 23 (d55b0aa6241ee521f1073ccaf1f611bc91d2c1f9):

  • libsystemd/255.7:
    All packages built successfully! (All logs)

  • libsystemd/255:
    All packages built successfully! (All logs)

  • libsystemd/253.6:
    All packages built successfully! (All logs)

  • libsystemd/255.2:
    All packages built successfully! (All logs)

  • libsystemd/253.14:
    All packages built successfully! (All logs)

  • libsystemd/253.10:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 23 (d55b0aa6241ee521f1073ccaf1f611bc91d2c1f9):

  • libsystemd/255.7:
    All packages built successfully! (All logs)

  • libsystemd/255.2:
    All packages built successfully! (All logs)

  • libsystemd/255:
    All packages built successfully! (All logs)

  • libsystemd/253.14:
    All packages built successfully! (All logs)

  • libsystemd/253.10:
    All packages built successfully! (All logs)

  • libsystemd/253.6:
    All packages built successfully! (All logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants