Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add v8 #2067

Closed
wants to merge 2 commits into from
Closed

feat: add v8 #2067

wants to merge 2 commits into from

Conversation

gocarlos
Copy link
Contributor

@gocarlos gocarlos commented Jun 27, 2020

copied from https://github.com/extcpp/conan-v8

this is a WIP as v8 seems pretty complex to package and its not clear how to do it with the current conan workflow:

as per microsoft/vcpkg#372 (comment) we would need to download two artifacts, in conan you have to specify one in the conandata.yml file

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

closes #995

cc/ @ObiWahn

sources:
"8.2.49":
sha256: bf61bc7ffe556b30464ac0734e18d975fe6a8676d9c2fcb7c215981a46381847
url: https://github.com/bacnet-stack/bacnet-stack/archive/4a916468c63de478b84ef4d0c67d541cd84da27e.zip
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

@conan-center-bot
Copy link
Collaborator

Some configurations of 'v8/8.2.49' failed in build 1 (3bbb2977bc35ee036537f209049ac4bb8bf5aef5):

  • Linux x86_64, Release, gcc 5, libstdc++
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [NO FINAL ENDLINE (KB-H041)] File '/tmp/c3ipr/co_pr_2067_1_0_0/recipes/v8/all/test_package/test_package.cpp' does not end with an endline (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H041)
    • Log download
    • Log error Download
    • Profile
  • Access to all the logs

@conan-center-bot
Copy link
Collaborator

Some configurations of 'v8/8.2.49' failed in build 2 (338a56fa6ba90c6653a101a27b0683693515aeda):

@Croydon
Copy link
Contributor

Croydon commented Jun 27, 2020

I'm not sure if it works at all or how good the quality is, but here is another v8 recipe: https://github.com/inexorgame/conan-v8

@prince-chrismc
Copy link
Contributor

we would need to download two artifacts, in conan you have to specify one in the conandata.yml file

I came across doxygen recipe which actually downloads four artifacts! Something similar might be possible here

@gocarlos
Copy link
Contributor Author

I'm not sure if it works at all or how good the quality is, but here is another v8 recipe: https://github.com/inexorgame/conan-v8

https://github.com/extcpp/conan-v8 is a fork of this one

@ObiWahn
Copy link

ObiWahn commented Jun 30, 2020

I think it was working ok, but I ran out of build time on travis. Therefore I gave up for the time. If somebody is willing to provide me with CI time I would look into it again.

@gocarlos
Copy link
Contributor Author

I think it was working ok, but I ran out of build time on travis. Therefore I gave up for the time. If somebody is willing to provide me with CI time I would look into it again.

you could try to contribute to CCI as we do not have this issue here :)
furthermore, in the long term, this is the place to put it :D

@Croydon
Copy link
Contributor

Croydon commented Jul 7, 2020

@stale
Copy link

stale bot commented Dec 1, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 1, 2020
@stale
Copy link

stale bot commented Dec 31, 2020

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@stale stale bot closed this Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] v8/latest
5 participants