Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simd: add recipe #20909

Merged
merged 19 commits into from
Jun 18, 2024
Merged

simd: add recipe #20909

merged 19 commits into from
Jun 18, 2024

Conversation

toge
Copy link
Contributor

@toge toge commented Nov 3, 2023

Specify library name and version: simd/*


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Hooks produced the following warnings for commit be2c891
simd/5.3.131@#a882a020dee85b683a59754ce5a1e813
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libSimd.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @toge

Thanks a lot for this contribution, and sorry for the delay in reviewing it.

Before continuing with the revision, please, check my comment below.

recipes/simd/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but CMP0077 must definitely be added for options to work correctly.

recipes/simd/all/conanfile.py Show resolved Hide resolved

class SimdConan(ConanFile):
name = "simd"
description = "C++ image processing and machine learning library with using of SIMD"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description = "C++ image processing and machine learning library with using of SIMD"
description = "C++ image processing and machine learning library with using of SIMD"

"with using of SIMD" is not grammatically correct. Maybe you can rephrase it.

recipes/simd/all/test_package/test_package.cpp Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (384a17de7402ace09d74f4bcd5e71fc6da07cfb5):

  • simd/6.1.138:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (384a17de7402ace09d74f4bcd5e71fc6da07cfb5):

  • simd/6.1.138:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 1aa7b56 into conan-io:master Jun 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants