Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rmlui: add v5.1, simplify patching, merge v3.3 subdir into v4.x #21647

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Dec 6, 2023

The 3.3 and 4.x were virtually identical when the same patches are used. I only restored the enable_rtti_and_exceptions from v3.3 for later versions.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@leha-bot
Copy link
Contributor

@valgur , hello, sorry for ping, may you update the PR please? Thanks in advance :)

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 1 (dc86347ec276bcf5442fc004dea05e25afd2b831):

  • rmlui/5.1:
    CI failed to create some packages (All logs)

    Logs for packageID f91e44c7c4748b08f0af707bea93145b954667b6:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=5
    os=Linux
    [options]
    rmlui:shared=False
    
    [...]
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/Pool.inl:154:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
      reinterpret_cast<PoolType*>(object->object)->~PoolType();
      ^
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/Pool.inl:154:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/Pool.inl: In instantiation of ‘void Rml::Pool<PoolType>::DestroyAndDeallocate(Rml::Pool<PoolType>::Iterator&) [with PoolType = Rml::ElementText]’:
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/Pool.inl:197:22:   required from ‘void Rml::Pool<PoolType>::DestroyAndDeallocate(PoolType*) [with PoolType = Rml::ElementText]’
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/ElementInstancer.cpp:77:75:   required from here
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/Pool.inl:154:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
    In file included from /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/Pool.h:158:0,
                     from /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/LayoutEngine.cpp:39:
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/Pool.inl: In instantiation of ‘void Rml::Pool<PoolType>::DestroyAndDeallocate(Rml::Pool<PoolType>::Iterator&) [with PoolType = Rml::LayoutChunk<72ul>]’:
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/Pool.inl:197:22:   required from ‘void Rml::Pool<PoolType>::DestroyAndDeallocate(PoolType*) [with PoolType = Rml::LayoutChunk<72ul>]’
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/LayoutEngine.cpp:153:83:   required from here
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/Pool.inl:154:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
      reinterpret_cast<PoolType*>(object->object)->~PoolType();
      ^
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/Pool.inl: In instantiation of ‘void Rml::Pool<PoolType>::DestroyAndDeallocate(Rml::Pool<PoolType>::Iterator&) [with PoolType = Rml::LayoutChunk<200ul>]’:
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/Pool.inl:197:22:   required from ‘void Rml::Pool<PoolType>::DestroyAndDeallocate(PoolType*) [with PoolType = Rml::LayoutChunk<200ul>]’
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/LayoutEngine.cpp:155:85:   required from here
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/Pool.inl:154:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/Pool.inl: In instantiation of ‘void Rml::Pool<PoolType>::DestroyAndDeallocate(Rml::Pool<PoolType>::Iterator&) [with PoolType = Rml::LayoutChunk<288ul>]’:
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/Pool.inl:197:22:   required from ‘void Rml::Pool<PoolType>::DestroyAndDeallocate(PoolType*) [with PoolType = Rml::LayoutChunk<288ul>]’
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/LayoutEngine.cpp:157:79:   required from here
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/Pool.inl:154:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
    In file included from /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/Pool.h:158:0,
                     from /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/ObserverPtr.cpp:30:
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/Pool.inl: In instantiation of ‘void Rml::Pool<PoolType>::DestroyAndDeallocate(Rml::Pool<PoolType>::Iterator&) [with PoolType = Rml::ObserverPtrBlock]’:
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/Pool.inl:197:22:   required from ‘void Rml::Pool<PoolType>::DestroyAndDeallocate(PoolType*) [with PoolType = Rml::ObserverPtrBlock]’
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/ObserverPtr.cpp:53:39:   required from here
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/Pool.inl:154:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
      reinterpret_cast<PoolType*>(object->object)->~PoolType();
      ^
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/StyleSheetNode.cpp: In member function ‘void Rml::StyleSheetNode::CalculateAndSetSpecificity()’:
    /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/src/Source/Core/StyleSheetNode.cpp:418:53: error: ‘const struct Rml::StructuralSelector’ has no member named ‘structural_selectors’
      for (const StructuralSelector& selector : selector.structural_selectors)
                                                         ^
    make[2]: *** [src/CMakeFiles/RmlCore.dir/Source/Core/StyleSheetNode.cpp.o] Error 1
    make[2]: *** Waiting for unfinished jobs....
    make[1]: *** [src/CMakeFiles/RmlCore.dir/all] Error 2
    make: *** [all] Error 2
    WARN: *** Conan 1 is legacy and on a deprecation path ***
    WARN: *** Please upgrade to Conan 2 ***
    WARN: libpng/1.6.43: requirement zlib/[>=1.2.11 <2] overridden by freetype/2.13.2 to zlib/1.3.1 
    rmlui/5.1: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    rmlui/5.1: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    rmlui/5.1: ERROR: Package 'f91e44c7c4748b08f0af707bea93145b954667b6' build failed
    rmlui/5.1: WARN: Build folder /home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/build/Release
    ERROR: rmlui/5.1: Error in build() method, line 134
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build "/home/conan/workspace/prod-v1/bsr/92466/feaab/.conan/data/rmlui/5.1/_/_/build/f91e44c7c4748b08f0af707bea93145b954667b6/build/Release" '--' '-j3'
    
  • rmlui/3.3:
    Didn't run or was cancelled before finishing

  • rmlui/4.4:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants