Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geos: add v3.12.1, simplify patching #21665

Merged
merged 3 commits into from
Aug 1, 2024
Merged

geos: add v3.12.1, simplify patching #21665

merged 3 commits into from
Aug 1, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Dec 6, 2023

No description provided.

@prince-chrismc prince-chrismc mentioned this pull request Dec 6, 2023
Open
This was referenced Dec 7, 2023
Open
Closed
@ericLemanissier ericLemanissier mentioned this pull request Dec 7, 2023
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@AbrilRBS AbrilRBS self-assigned this Jan 6, 2024
AbrilRBS
AbrilRBS reviewed Jan 6, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Question about the new patch method, otherwise looks good!

recipes/geos/all/conanfile.py Outdated Show resolved Hide resolved
@valgur valgur requested a review from AbrilRBS January 7, 2024 09:35
@conan-center-bot

This comment has been minimized.

Sign in to view
@jcar87 jcar87 self-assigned this Jun 13, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
@perseoGI
Copy link
Contributor

Hi @valgur, there is a new release https://github.com/libgeos/geos/releases/tag/3.12.2
Could you update this PR te reflect new changes.
The patch simplification LGTM btw

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 2 (ad4aabf3e10bd740d0dd5695c0df2898ea687b72):

  • geos/3.12.0:
    All packages built successfully! (All logs)

  • geos/3.11.2:
    All packages built successfully! (All logs)

  • geos/3.10.2:
    All packages built successfully! (All logs)

  • geos/3.11.0:
    All packages built successfully! (All logs)

  • geos/3.10.3:
    All packages built successfully! (All logs)

  • geos/3.12.2:
    All packages built successfully! (All logs)

  • geos/3.11.1:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (ad4aabf3e10bd740d0dd5695c0df2898ea687b72):

  • geos/3.12.0:
    All packages built successfully! (All logs)

  • geos/3.10.3:
    All packages built successfully! (All logs)

  • geos/3.11.2:
    All packages built successfully! (All logs)

  • geos/3.11.0:
    All packages built successfully! (All logs)

  • geos/3.11.1:
    All packages built successfully! (All logs)

  • geos/3.12.2:
    All packages built successfully! (All logs)

  • geos/3.10.2:
    All packages built successfully! (All logs)

perseoGI
perseoGI approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AbrilRBS
AbrilRBS approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@conan-center-bot conan-center-bot merged commit 8882a5b into conan-io:master Aug 1, 2024
36 checks passed
uilianries pushed a commit to uilianries/conan-center-index that referenced this pull request Aug 7, 2024
@valgur @uilianries
(conan-io#21665) geos: add v3.12.1, simplify patching
dc50d5b 
* geos: add v3.12.1, simplify patching

* geos: don't use strict=False for patching

* geos: bump to v3.12.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perseoGI perseoGI perseoGI approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@franramirez688 franramirez688 Awaiting requested review from franramirez688

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@valgur @conan-center-bot @perseoGI @AbrilRBS @jcar87