Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtlab-logging: Initial support for the gtlab-logging library (4.4.1) #21740

Merged
merged 13 commits into from
Jun 27, 2024

Conversation

rainman110
Copy link
Contributor

Specify library name and version: gtlab-logging/4.4.1

We are the developers of the gtlab-logging library. We just open sourced our gtlab ecosystem with libraries etc and now want to support a smooth build experience for the users.
Therefore, we want to use conan for our builds and we need to provide all libraries as conan packages.


Closes #21739

@CLAassistant
Copy link

CLAassistant commented Dec 13, 2023

CLA assistant check
All committers have signed the CLA.

@rainman110 rainman110 changed the title Initial support for the gtlab-logging library DRAFT: Initial support for the gtlab-logging library Dec 13, 2023
@rainman110 rainman110 marked this pull request as draft December 13, 2023 09:39
@rainman110 rainman110 changed the title DRAFT: Initial support for the gtlab-logging library gtlab-logging: Initial support for the gtlab-logging library Dec 13, 2023
@rainman110 rainman110 changed the title gtlab-logging: Initial support for the gtlab-logging library gtlab-logging: Initial support for the gtlab-logging library (4.4.1) Dec 13, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@rainman110
Copy link
Contributor Author

@prince-chrismc How do we proceed here? Was the built intentionally aborted? I cannot see any feedback regarding the build status.

@prince-chrismc
Copy link
Contributor

I am no longer on the Cona team, so you will need to wait for one of them to check :)

Hopefully one of the more active community members will be able to help

@rainman110
Copy link
Contributor Author

I am no longer on the Cona team, so you will need to wait for one of them to check :)

Hopefully one of the more active community members will be able to help

Oh... I just wrote you because of the comment above, which was probably automatically generated. Good luck with your new job!

@uilianries uilianries self-assigned this Jan 8, 2024
@uilianries
Copy link
Member

@rainman110 Hello! Please, ping @conan-io/barbarians when needing support, just like commented above.

I just restarted your PR in the CI. It's looking good.

I have a question related to Qt support, I see you need to pass GT_LOG_USE_QT_BINDINGS to activate Qt. Is it possible to add it as option? We have Qt available in Conan Center.

recipes/gtlab-logging/all/conanfile.py Outdated Show resolved Hide resolved
recipes/gtlab-logging/all/conanfile.py Outdated Show resolved Hide resolved
recipes/gtlab-logging/all/conanfile.py Outdated Show resolved Hide resolved
@rainman110
Copy link
Contributor Author

@uilianries I ping you here, since this PR is ready for final review.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, only small requests.

recipes/gtlab-logging/all/conanfile.py Outdated Show resolved Hide resolved
recipes/gtlab-logging/all/conanfile.py Outdated Show resolved Hide resolved
AbrilRBS
AbrilRBS previously approved these changes May 9, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your patience while this one got reviewed, I lost the initial ping notification, my bad

We really appreciate you taking the time to submit the PR with the recipe anyhow, thanks a lot!

uilianries
uilianries previously approved these changes May 9, 2024
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution!

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

github-actions bot commented May 9, 2024

Hooks produced the following warnings for commit d276956
gtlab-logging/4.4.1@#9d4ab56ff393d21bba23daec6950d013
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/logging/libGTlabLogging.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/logging/libGTlabLogging-d.so' links to system library 'm' but it is not in cpp_info.system_libs.

@rainman110
Copy link
Contributor Author

@uilianries I intentionally wanted the qt version to be flexible,as the package does not link against qt but uses qt only in one single header.

In fact, we'd like to use the package with a different qt version (5.12,). Can we have the flexibility back?

@rainman110 rainman110 dismissed stale reviews from uilianries and AbrilRBS via 4c390fa June 24, 2024 14:13
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 4c390fa
gtlab-logging/4.4.1@#cfbd902697e169edd4e513c524a5bf7a
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/logging/libGTlabLogging.so' links to system library 'm' but it is not in cpp_info.system_libs.

uilianries
uilianries previously approved these changes Jun 24, 2024
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uilianries
Copy link
Member

I tried to build locally with Qt, but failed to build Qt here due my environment 😞

Thank you for your PR again, and sorry the delay.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your patience @rainman110 :)

recipes/gtlab-logging/all/conanfile.py Show resolved Hide resolved
@AbrilRBS AbrilRBS requested a review from uilianries June 25, 2024 07:40
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 5 (043bc4ac008c884e07dd19cb7872010e3e3eefc7):

  • gtlab-logging/4.4.1:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 5 (043bc4ac008c884e07dd19cb7872010e3e3eefc7):

  • gtlab-logging/4.4.1:
    All packages built successfully! (All logs)

Copy link
Contributor

Hooks produced the following warnings for commit 043bc4a
gtlab-logging/4.4.1@#3dfb1f17dde539b07fed4f192006c467
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/logging/libGTlabLogging.so' links to system library 'm' but it is not in cpp_info.system_libs.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 698ded7 into conan-io:master Jun 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] gtlab-logging/4.4.1
9 participants