-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gtlab-logging: Initial support for the gtlab-logging library (4.4.1) #21740
gtlab-logging: Initial support for the gtlab-logging library (4.4.1) #21740
Conversation
e93e4b7
to
a21bcd6
Compare
This comment has been minimized.
This comment has been minimized.
a21bcd6
to
df82752
Compare
This comment has been minimized.
This comment has been minimized.
df82752
to
c0254ad
Compare
This comment has been minimized.
This comment has been minimized.
c0254ad
to
db40686
Compare
This comment has been minimized.
This comment has been minimized.
db40686
to
ca95d91
Compare
This comment has been minimized.
This comment has been minimized.
ca95d91
to
c84476b
Compare
@prince-chrismc How do we proceed here? Was the built intentionally aborted? I cannot see any feedback regarding the build status. |
I am no longer on the Cona team, so you will need to wait for one of them to check :) Hopefully one of the more active community members will be able to help |
Oh... I just wrote you because of the comment above, which was probably automatically generated. Good luck with your new job! |
@rainman110 Hello! Please, ping I just restarted your PR in the CI. It's looking good. I have a question related to Qt support, I see you need to pass |
@uilianries I ping you here, since this PR is ready for final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, only small requests.
Co-authored-by: Uilian Ries <[email protected]>
Co-authored-by: Uilian Ries <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your patience while this one got reviewed, I lost the initial ping notification, my bad
We really appreciate you taking the time to submit the PR with the recipe anyhow, thanks a lot!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your contribution!
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit d276956gtlab-logging/4.4.1@#9d4ab56ff393d21bba23daec6950d013
|
@uilianries I intentionally wanted the qt version to be flexible,as the package does not link against qt but uses qt only in one single header. In fact, we'd like to use the package with a different qt version (5.12,). Can we have the flexibility back? |
Co-authored-by: Uilian Ries <[email protected]>
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 4c390fagtlab-logging/4.4.1@#cfbd902697e169edd4e513c524a5bf7a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I tried to build locally with Qt, but failed to build Qt here due my environment 😞 Thank you for your PR again, and sorry the delay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your patience @rainman110 :)
Conan v1 pipeline ✔️All green in build 5 (
Conan v2 pipeline ✔️
All green in build 5 (
|
Hooks produced the following warnings for commit 043bc4agtlab-logging/4.4.1@#3dfb1f17dde539b07fed4f192006c467
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Specify library name and version: gtlab-logging/4.4.1
We are the developers of the gtlab-logging library. We just open sourced our gtlab ecosystem with libraries etc and now want to support a smooth build experience for the users.
Therefore, we want to use conan for our builds and we need to provide all libraries as conan packages.
(Conan 1.59.0, Conan 2.0.14)
(Shared, Static, debug, release, Windows only)
Closes #21739