Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vk-bootstrap: add v1.3.268 #22367

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

vk-bootstrap: add v1.3.268 #22367

wants to merge 2 commits into from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jan 15, 2024

No description provided.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (bb3c834690face3c653ffab00bce02d00aa9082c):

  • vk-bootstrap/0.6:
    All packages built successfully! (All logs)

  • vk-bootstrap/1.3.268:
    All packages built successfully! (All logs)

  • vk-bootstrap/0.7:
    All packages built successfully! (All logs)

  • vk-bootstrap/0.5:
    All packages built successfully! (All logs)

  • vk-bootstrap/0.3.1:
    All packages built successfully! (All logs)

  • vk-bootstrap/0.4:
    All packages built successfully! (All logs)

  • vk-bootstrap/0.2:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (bb3c834690face3c653ffab00bce02d00aa9082c):

  • vk-bootstrap/0.7:
    All packages built successfully! (All logs)

  • vk-bootstrap/1.3.268:
    All packages built successfully! (All logs)

  • vk-bootstrap/0.6:
    All packages built successfully! (All logs)

  • vk-bootstrap/0.5:
    All packages built successfully! (All logs)

  • vk-bootstrap/0.3.1:
    All packages built successfully! (All logs)

  • vk-bootstrap/0.4:
    All packages built successfully! (All logs)

  • vk-bootstrap/0.2:
    All packages built successfully! (All logs)

@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit bb3c834
vk-bootstrap/0.6@#cc67be2e6bb03461d9cbd0536bdd2952 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libvk-bootstrap.so' links to system library 'm' but it is not in cpp_info.system_libs.
vk-bootstrap/1.3.268@#894569e7335e01e918d7b70fd9820685 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libvk-bootstrap.so' links to system library 'm' but it is not in cpp_info.system_libs.
vk-bootstrap/0.7@#48c3f764a10f5cc3672ea3a1f2ccdac7 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libvk-bootstrap.so' links to system library 'm' but it is not in cpp_info.system_libs.
vk-bootstrap/0.5@#1668f1b953f442b2687f6b466b1d310c 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libvk-bootstrap.so' links to system library 'm' but it is not in cpp_info.system_libs.
vk-bootstrap/0.3.1@#7b18f4206af8b012001450fd55315622 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libvk-bootstrap.so' links to system library 'm' but it is not in cpp_info.system_libs.
vk-bootstrap/0.4@#2453051bfd78e569922f719d1a66f41c 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libvk-bootstrap.so' links to system library 'm' but it is not in cpp_info.system_libs.
vk-bootstrap/0.2@#7c3f66839d8f41df47c34cac4781b3a8 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libvk-bootstrap.so' links to system library 'm' but it is not in cpp_info.system_libs.

@prince-chrismc prince-chrismc mentioned this pull request Jan 16, 2024
Open
AbrilRBS
AbrilRBS reviewed Jan 22, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

recipes/vk-bootstrap/all/conanfile.py
@@ -57,21 +68,24 @@ def configure(self):
def layout(self):
cmake_layout(self, src_folder="src")

@property
def _headers_version(self):
return {}.get(self.version, f"{self.version}.0")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the mapping missing here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping @valgur

@AbrilRBS AbrilRBS self-assigned this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perseoGI perseoGI perseoGI left review comments

@AbrilRBS AbrilRBS AbrilRBS left review comments

@danimtb danimtb Awaiting requested review from danimtb

@jcar87 jcar87 Awaiting requested review from jcar87

At least 2 approving reviews are required to merge this pull request.

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@valgur @conan-center-bot @AbrilRBS @danimtb @perseoGI