Add catalyst library #22415
Add catalyst library #22415
Conversation
This comment has been minimized.
This comment has been minimized.
|
How do I fix the CMake minimum required version? catalyst requires 3.26, but CI apparently only has 3.15 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
recipes/catalyst/all/conanfile.py
Outdated
| tc.variables["CATALYST_BUILD_REPLAY"] = False | ||
| tc.variables["CATALYST_BUILD_TESTING"] = False | ||
| tc.variables["CATALYST_BUILD_SHARED_LIBS"] = self.options.shared | ||
| tc.variables["CATALYST_USE_MPI"] = self.options.use_mpi |
There was a problem hiding this comment.
You should also probably add a conditional self.requires("openmpi/x.y.z").
The OpenMPI recipe is currently not yet migrated to Conan 2.0, but you can give this version a try: #18980.
There was a problem hiding this comment.
If its okay, I will remove the option to use MPI and wait until the openmpi recipe is ported.
There was a problem hiding this comment.
I would leave the option and add a if self.options.use_mpi: raise ConanException("MPI is not yet supported by the recipe") to def validate(self). Plus a TODO comment mentioning that OpenMPI is not yet Conan 2.0-compatible.
| find_package(catalyst REQUIRED CONFIG) | ||
|
|
||
| add_executable(${PROJECT_NAME} test_package.cpp) | ||
| target_link_libraries(${PROJECT_NAME} PUBLIC catalyst::catalyst ${CMAKE_DL_LIBS}) |
There was a problem hiding this comment.
| target_link_libraries(${PROJECT_NAME} PUBLIC catalyst::catalyst ${CMAKE_DL_LIBS}) | |
| target_link_libraries(${PROJECT_NAME} PUBLIC catalyst::catalyst) |
Add a system_libs dependency instead.
if self.settings.os in ["Linux", "FreeBSD"]:
self.cpp_info.system_libs.append("dl")There was a problem hiding this comment.
Will this work in Windows?
There was a problem hiding this comment.
Yes. Windows does not require linking against an additional library for loading of dynamic libraries.
There was a problem hiding this comment.
@jjcasmar please take a look at the comment above. I think it is the only thing missing in this PR
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 9 (
Conan v2 pipeline ✔️
All green in build 9 (
|
Hooks produced the following warnings for commit ee25f38catalyst/2.0.0-rc4@#87353bc6e5a883c335f9d08958d4d414 |
Specify library name and version: catalyst/2.0.0-rc4
Catalyst is an API specification developed for simulations (and other scientific data producers) to analyze and visualize data in situ.