-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqlcipher: Add 4.5.6 #22710
sqlcipher: Add 4.5.6 #22710
Conversation
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying sqlcipher/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
7ad04e1
to
aedb10d
Compare
This comment has been minimized.
This comment has been minimized.
…n-center-index into sqlcipher-4.5.6 # Conflicts: # recipes/sqlcipher/all/patches/Makefile.in-v4.5.6.patch
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Uilian Ries <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add new version and add SQLITE_ENABLE_COLUMN_METADATA option feature flag. The add of this flag made the use of sqlcipher usable by sqlitecpp.
@Alex-PLACET what error do you have when not using that define? Is
tools.build:cflags
not enough for your case?
https://docs.conan.io/2/reference/config_files/global_conf.html
This comment has been minimized.
This comment has been minimized.
I got this error when trying to compile SqliteCpp with sqlcipher as sqlite lib:
This is a build with a SqliteCPP recipe that I modified to be able to use encryption which will come in another PR. |
Co-authored-by: Uilian Ries <[email protected]>
@Alex-PLACET Yes, please. I'm not sure how this could affect the package behavior, like breaking users. |
@uilianries Ok done |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 8 (
Conan v2 pipeline ✔️
All green in build 8 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Alex-PLACET Thank you for your contribution, we just need another review now: https://github.com/conan-io/conan-center-index/blob/master/docs/review_process.md#getting-your-pull-request-reviewed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Specify library name and version: sqlcipher/4.5.6
Add new version and add SQLITE_ENABLE_COLUMN_METADATA option feature flag. The add of this flag made the use of sqlcipher usable by sqlitecpp.