Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlcipher: Add 4.5.6 #22710

Merged
merged 9 commits into from
Feb 14, 2024
Merged

Conversation

Alex-PLACET
Copy link
Contributor

@Alex-PLACET Alex-PLACET commented Feb 7, 2024

Specify library name and version: sqlcipher/4.5.6

Add new version and add SQLITE_ENABLE_COLUMN_METADATA option feature flag. The add of this flag made the use of sqlcipher usable by sqlitecpp.

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Feb 7, 2024

I detected other pull requests that are modifying sqlcipher/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new version and add SQLITE_ENABLE_COLUMN_METADATA option feature flag. The add of this flag made the use of sqlcipher usable by sqlitecpp.

@Alex-PLACET what error do you have when not using that define? Is
tools.build:cflags not enough for your case?

https://docs.conan.io/2/reference/config_files/global_conf.html

recipes/sqlcipher/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@uilianries uilianries self-assigned this Feb 8, 2024
@Alex-PLACET
Copy link
Contributor Author

Add new version and add SQLITE_ENABLE_COLUMN_METADATA option feature flag. The add of this flag made the use of sqlcipher usable by sqlitecpp.

@Alex-PLACET what error do you have when not using that define? Is tools.build:cflags not enough for your case?

https://docs.conan.io/2/reference/config_files/global_conf.html

I got this error when trying to compile SqliteCpp with sqlcipher as sqlite lib:

SQLiteCpp.lib(Statement.obj) : error LNK2019: unresolved external symbol sqlite3_column_origin_name referenced in fun
ction "public: char const * __cdecl SQLite::Statement::getColumnOriginName(int)const " (?getColumnOriginName@Statemen 
t@SQLite@@QEBAPEBDH@Z) [\conan-center-index\recipes\sqlitecpp\all\test_package\build\msvc 
-193-x86_64-20-release\test_package.vcxproj]
SQLiteCpp.lib(Column.obj) : error LNK2001: unresolved external symbol sqlite3_column_origin_name [\conan-center-index\recipes\sqlitecpp\all\test_package\build\msvc-193-x86_64-20-release\test_package.vcxproj 
]

This is a build with a SqliteCPP recipe that I modified to be able to use encryption which will come in another PR.
Do you prefer that I activate it through an option ?

@uilianries
Copy link
Member

This is a build with a SqliteCPP recipe that I modified to be able to use encryption which will come in another PR.
Do you prefer that I activate it through an option ?

@Alex-PLACET Yes, please. I'm not sure how this could affect the package behavior, like breaking users.

@Alex-PLACET
Copy link
Contributor Author

@uilianries Ok done

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (5a694cc613f2ce5557bec44e319fb525a0aa1f12):

  • sqlcipher/4.5.0:
    All packages built successfully! (All logs)

  • sqlcipher/4.5.1:
    All packages built successfully! (All logs)

  • sqlcipher/4.5.6:
    All packages built successfully! (All logs)

  • sqlcipher/4.4.2:
    All packages built successfully! (All logs)

  • sqlcipher/4.4.3:
    All packages built successfully! (All logs)

  • sqlcipher/4.4.0:
    All packages built successfully! (All logs)

  • sqlcipher/4.3.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (5a694cc613f2ce5557bec44e319fb525a0aa1f12):

  • sqlcipher/4.5.1:
    All packages built successfully! (All logs)

  • sqlcipher/4.5.0:
    All packages built successfully! (All logs)

  • sqlcipher/4.5.6:
    All packages built successfully! (All logs)

  • sqlcipher/4.4.3:
    All packages built successfully! (All logs)

  • sqlcipher/4.4.2:
    All packages built successfully! (All logs)

  • sqlcipher/4.4.0:
    All packages built successfully! (All logs)

  • sqlcipher/4.3.0:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uilianries
Copy link
Member

@Alex-PLACET Thank you for your contribution, we just need another review now: https://github.com/conan-io/conan-center-index/blob/master/docs/review_process.md#getting-your-pull-request-reviewed

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@conan-center-bot conan-center-bot merged commit 02ff9d0 into conan-io:master Feb 14, 2024
43 checks passed
@Alex-PLACET Alex-PLACET deleted the sqlcipher-4.5.6 branch February 15, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants