Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unleash-client-cpp: add version 1.3.0, support conan v2 #22894

Merged
merged 9 commits into from
May 30, 2024
Merged

unleash-client-cpp: add version 1.3.0, support conan v2 #22894

merged 9 commits into from
May 30, 2024

Conversation

toge
Copy link
Contributor

@toge toge commented Feb 26, 2024 •
edited
Loading

Specify library name and version: unleash-client-cpp/*

@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Feb 26, 2024
Closed
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced Feb 26, 2024
Open
Closed
@ericLemanissier ericLemanissier mentioned this pull request Feb 26, 2024
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@toge @valgur
fix msvc version
3c477bd 
Co-authored-by: Martin Valgur <[email protected]>
@conan-center-bot

This comment has been minimized.

Sign in to view
AbrilRBS
AbrilRBS reviewed Feb 26, 2024
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! I've seen that @valgur opened a similar PR a few months back (Which fell thru the cracks, sorry!) so let's work on merging both with they corresponding improvements :)

recipes/unleash-client-cpp/all/patches/0002-include-sstream.patch Outdated Show resolved Hide resolved
recipes/unleash-client-cpp/all/conanfile.py Show resolved Hide resolved
@AbrilRBS AbrilRBS self-assigned this Feb 26, 2024
AbrilRBS
AbrilRBS previously approved these changes May 30, 2024
View reviewed changes
perseoGI
perseoGI previously approved these changes May 30, 2024
View reviewed changes
@AbrilRBS AbrilRBS dismissed stale reviews from perseoGI and themself via 06a381b May 30, 2024 12:36
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (06a381bcb61019e3ea298c8aacf85daa61f104de):

  • unleash-client-cpp/1.3.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (06a381bcb61019e3ea298c8aacf85daa61f104de):

  • unleash-client-cpp/1.3.0:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 1fc297a into conan-io:master May 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perseoGI perseoGI perseoGI approved these changes

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@valgur valgur valgur approved these changes

Assignees

@AbrilRBS AbrilRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@toge @conan-center-bot @valgur @AbrilRBS @perseoGI