Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abseil: Add 20240116.1, remove old versions #22982

Merged
merged 8 commits into from
Mar 14, 2024

Conversation

Ahajha
Copy link
Contributor

@Ahajha Ahajha commented Mar 5, 2024

Specify library name and version: abseil/20240116.1

I've removed some of the older versions, mainly out of date "patch" versions (for example, keeping 20230125.3 but removing .2/.1/.0).


Copy link
Contributor

github-actions bot commented Mar 5, 2024

🤖 Beep Boop! This pull request is making changes to 'recipes/abseil//'.

👋 @Hopobcn you might be interested. 😉

@ghost
Copy link

ghost commented Mar 5, 2024

I detected other pull requests that are modifying abseil/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@Ahajha Ahajha changed the title abseil: Add 20240116.1 abseil: Add 20240116.1, remove old versions Mar 5, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@Ahajha Ahajha mentioned this pull request Mar 5, 2024
3 tasks
@conan-center-bot

This comment has been minimized.

@Ahajha
Copy link
Contributor Author

Ahajha commented Mar 6, 2024

Note to self: I don't like the way the edge case is handled, I think it should either be an invalid configuration, or just patch the problem.

@franramirez688 franramirez688 self-assigned this Mar 6, 2024
@AbrilRBS
Copy link
Member

AbrilRBS commented Mar 6, 2024

Just a heads up that tensorflow-lite uses one of the removed options

@Ahajha
Copy link
Contributor Author

Ahajha commented Mar 6, 2024

Just a heads up that tensorflow-lite uses one of the removed options

I also noticed this, after this I can put in a PR to bump it to this new version (or at least to the .3 patch).

@AbrilRBS
Copy link
Member

AbrilRBS commented Mar 6, 2024

I've asked the current tensorflow PR to do that for you :)

@Ahajha
Copy link
Contributor Author

Ahajha commented Mar 6, 2024

I've reported the GCC7/C++17 issue upstream here: abseil/abseil-cpp#1635. I'm hoping it's a simple fix that could be backported, as that would be the simplest solution rather than the hack I have in place.

@Ahajha
Copy link
Contributor Author

Ahajha commented Mar 12, 2024

There was a std::result_of workaround (it was removed in C++20) added in #6383, it was fixed as of abseil/abseil-cpp@e19260f, which was late 2020. None of the versions at this point need these extra defines to work. I also tested locally with an MSVC/C++20 build.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 7 (bbe55c8dea33379212ad74a36dd434ede43ff9c6):

  • abseil/20240116.1:
    All packages built successfully! (All logs)

  • abseil/20230802.1:
    All packages built successfully! (All logs)

  • abseil/20211102.0:
    All packages built successfully! (All logs)

  • abseil/20220623.1:
    All packages built successfully! (All logs)

  • abseil/20230125.3:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 7 (bbe55c8dea33379212ad74a36dd434ede43ff9c6):

  • abseil/20230125.3:
    All packages built successfully! (All logs)

  • abseil/20240116.1:
    All packages built successfully! (All logs)

  • abseil/20230802.1:
    All packages built successfully! (All logs)

  • abseil/20220623.1:
    All packages built successfully! (All logs)

  • abseil/20211102.0:
    All packages built successfully! (All logs)

@Ahajha
Copy link
Contributor Author

Ahajha commented Mar 12, 2024

This should be good to go now, we now have the proper upstream fix backported so no need for any hacky workarounds.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to ghet the new version out asap, will bump tensorflow in a bit :) Thanks a lot

@conan-center-bot conan-center-bot merged commit b0546ef into conan-io:master Mar 14, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants