-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python-packaging 24.0 #23091
python-packaging 24.0 #23091
Conversation
This comment has been minimized.
This comment has been minimized.
The build is now finished. You can take a look at the results here |
This comment has been minimized.
This comment has been minimized.
The build is now finished. You can take a look at the results here |
I have a branch with this package here: https://github.com/uilianries/conan-center-index/tree/package/python-packaging/recipes/python-packaging Still under study with the Conan team. Please, be patient, there are many points to be considered. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The build is now finished. You can take a look at the results here |
Conan v1 pipeline ❌Failure in build 6 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Failure in build 6 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
|
||
|
||
class PackageConan(ConanFile): | ||
name = "python_packaging" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have consistence naming. #23098 used a hypen instead of underscore.
Personally, I would prefer a hypen. It is also closer to how we handle double package names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used a hyphen to stay as close as possible to how Linux distributions manage Python packages, fyi.
|
||
|
||
class PackageConan(ConanFile): | ||
name = "python_packaging" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name = "python_packaging" | |
name = "python-packaging" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python packages are not allowed in CCI for now. Still under discussion with Conan team to have a better insight. Thank you for investigating.
Specify library name and version: python-packaging/24.0