Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lielab: new package and v0.1.1 #23113

Merged
merged 11 commits into from
Jun 21, 2024
Merged

Conversation

msparapa
Copy link
Contributor

Adding new package to ConanCenter: Lielab.

lielab/0.1.1

I am the author of this library.


@CLAassistant
Copy link

CLAassistant commented Mar 16, 2024

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

@valgur valgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few minor tweaks required. Thanks!

recipes/lielab/all/conanfile.py Show resolved Hide resolved
recipes/lielab/all/conanfile.py Outdated Show resolved Hide resolved
@uilianries uilianries self-assigned this Mar 21, 2024
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msparapa Thank you for your PR! Could you please sign the CLA commented in this PR? Also, your username is listed already in the authorized users.

@msparapa
Copy link
Contributor Author

@msparapa Thank you for your PR! Could you please sign the CLA commented in this PR? Also, your username is listed already in the authorized users.

On it. Sorry, my institution has a fairly slow turnaround with these things.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@msparapa
Copy link
Contributor Author

msparapa commented May 3, 2024

Hi @uilianries . I did not try locally with any of the conan-center hooks but I think otherwise it's good to go now.

@uilianries
Copy link
Member

@msparapa Thank you for checking locally. I see this is a new recipe and missing the test package part. Would mind adding the test package folder and adding a very minimum test to validate the package? We have a template for header-only projects, so you don't start it from the scratch: https://github.com/conan-io/conan-center-index/tree/master/docs/package_templates/header_only/all

@msparapa
Copy link
Contributor Author

msparapa commented May 4, 2024

I added the test package. Question though, as of v0.3.0, the way Lielab gets imported changes so the #include <lielab/lielab> becomes #include <Lielab.hpp>. In the future, how would I set up the recipe so that there's a different test_package for versions < 0.3.0 and versions >= 0.3.0?

@conan-center-bot

This comment has been minimized.

- Hopefully clean up the relative file import path errors.
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@msparapa
Copy link
Contributor Author

Hi @uilianries . I think this is good to go now. I fixed some of the errors on the main branch and changed the version to 0.4.0 since it was the easiest thing to do. I think the remaining failures are from Conan v1 not using the validate() method to make sure it's using C++ 20 or higher which causes it to not compile, but let me know if there's other things I need to fix.

@msparapa msparapa marked this pull request as ready for review May 11, 2024 15:13
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 13 (feb7c2e0e8d714ad30b18300ebf9c9cafcdc9f7f):

  • lielab/0.4.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 12 (feb7c2e0e8d714ad30b18300ebf9c9cafcdc9f7f):

  • lielab/0.4.0:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry the delay to review. I pushed a small fix to the test package.

Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 05de5ac into conan-io:master Jun 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants