-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
open62541pp: new recipe #23291
base: master
Are you sure you want to change the base?
open62541pp: new recipe #23291
Conversation
This comment has been minimized.
This comment has been minimized.
I used the same MPL-2.0 license as the original open62541pp-library and I believe that license allows that. For the 0.12.0 version of the library you might need some of the changes from here: |
This comment has been minimized.
This comment has been minimized.
Build failed in C3I with IPO enabled.
The open62541 requirement is currently pinned to version |
@lukasberbuer CCI does not generally allow version ranges for dependencies, unfortunately. However, consumers can still always add |
Ok, thanks @valgur 👍 |
Conan v1 pipeline ❌Failure in build 4 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ✔️
All green in build 4 (
|
Hi @valgur, can I support you with the IPO issue? |
|
||
|
||
int main() { | ||
opcua::Server server(4840 /* port */); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's simplify the test package not to have to use server classes - reads like this could be hitting the network layer :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it does. The example is similar to the open62541 one: https://github.com/conan-io/conan-center-index/blob/master/recipes/open62541/all/test_package/test_package.c
I could provide a test without any server/client connection if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'd be ace yes :) thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ops, I was wrong. The example seems to be fine. The actual server connection is only instantiated if server.run()
is called.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can simply move the test code to a dummy function that does not get called from main().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual server connection is only instantiated if server.run() is called.
Having this as a comment in the code itself then should be enough :)
@lukasberbuer Yes, your assistance on the IPO issue would be very welcome. |
Is someone still working on this? |
@AbrilRBS The GCC build fails in CI with:
My guess is that this might be fixed by regenerating the |
There are a few versions of that package to be built, will update this branch when the binaries have been built, thanks for the heads-up @valgur! |
Seems like some configurations are having a few issues running the tests https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/prod-v1/TapaholesRepo/135-linux-gcc11/open62541/1.2.6//summary.json but it's progressing nicely otherwise |
Looks like the problem @valgur mentioned is still there?
But only in profiles with
|
What happened? |
Based on https://github.com/ErikTempelaarVO/open62541pp/blob/feat/conan-recipe/conanfile.py by @ErikTempelaarVO.
@ErikTempelaarVO, I assume you are ok with me copying parts of your recipe for this PR?