Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netpbm: new recipe #23402

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

netpbm: new recipe #23402

wants to merge 12 commits into from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Apr 6, 2024

Adds Netpbm: https://netpbm.sourceforge.net/

Netpbm is a toolkit for manipulation of graphic images, including conversion of images between a variety of different formats. There are over 350 separate tools in the package including converters for about 100 graphics formats. Examples of the sort of image manipulation we're talking about are: Shrinking an image by 10%; Cutting the top half off of an image; Making a mirror image; Creating a sequence of images that fade from one image to another.

Packaging status

@conan-center-bot

This comment has been minimized.

To match the VERSION file info installed with the package.
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 12 (2d5cc7daba6c53d62bd802168a24005ec85d0d8b):

  • netpbm/11.6.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 12 (2d5cc7daba6c53d62bd802168a24005ec85d0d8b):

  • netpbm/11.6.0:
    All packages built successfully! (All logs)

@AbrilRBS AbrilRBS self-assigned this Apr 8, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I want to know more in a few places, but besides that, it looks good :)

Comment on lines +173 to +175
# Fix FILE not being defined in jpeglib.h
replace_in_file(self, os.path.join(self.source_folder, "converter", "other", "cameratopam", "camera.c"),
"#include <jpeglib.h>", "#include <stdio.h>\n#include <jpeglib.h>")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HAs this been reported upstream?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, and the missing #include <stdio.h> appears to be a bug in libjpeg, surprisingly enough. I'll have to investigate it a bit further.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RubenRBS Indeed, libjpeg itself is buggy. #23428

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. it's apparently by design for libjpeg. I'll try to submit a patch upstream for Netpbm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on it, really appreciated! Let me know once this has been reported upstream :)

recipes/netpbm/all/conanfile.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] libnetpbm/10.86.41
3 participants