Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openni2: new recipe #23790

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

openni2: new recipe #23790

wants to merge 8 commits into from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Apr 27, 2024

Adds OpenNI2: https://github.com/structureio/OpenNI2

The OpenNI 2.0 API provides access to PrimeSense-compatible depth sensors.

Packaging status

An optional dependency for the following packages on CCI:

  • libfreenect
  • libfreenect2
  • librealsense
  • opencv
  • pangolin
  • pcl

@conan-center-bot

This comment has been minimized.

valgur added a commit to valgur/conan-center-index that referenced this pull request Apr 27, 2024
valgur added a commit to valgur/conan-center-index that referenced this pull request Apr 27, 2024
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 2a7f72a
openni2/2.2.0.33@#5456def82afbdb5f0c3f109c9e012bbe
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libOpenNI2.so' links to system library 'rt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/OpenNI2/Drivers/libPS1080.so' links to system library 'rt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/OpenNI2/Drivers/libDummyDevice.so' links to system library 'rt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/OpenNI2/Drivers/libPSLink.so' links to system library 'rt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/OpenNI2/Drivers/libOniFile.so' links to system library 'rt' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit df26ce5
openni2/2.2.0.33@#1cc08ebe904ca7d397c4dc25ada30fe2
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libOpenNI2.so' links to system library 'rt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/OpenNI2/Drivers/libPS1080.so' links to system library 'rt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/OpenNI2/Drivers/libDummyDevice.so' links to system library 'rt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/OpenNI2/Drivers/libPSLink.so' links to system library 'rt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/OpenNI2/Drivers/libOniFile.so' links to system library 'rt' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 6dd9d3e
openni2/2.2.0.33@#fecc3dcc0deb22ae24e9061841a8fcda
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libOpenNI2.dylib

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (4e316660951b0b9193d1c07c8bb42d4e9452fd2e):

  • openni2/2.2.0.33:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (4e316660951b0b9193d1c07c8bb42d4e9452fd2e):

  • openni2/2.2.0.33:
    All packages built successfully! (All logs)

Copy link
Contributor

@czoido czoido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks a lot for the contribution.
This looks like a fork of https://github.com/OpenNI/OpenNI2 so I think it should be named structureio-openni2

@valgur
Copy link
Contributor Author

valgur commented May 9, 2024

That's a fair point, but the old repo is pretty much dead and the fork is used as the main repo by all other package managers, including Debian/Ubuntu: https://repology.org/project/openni2/information

@czoido
Copy link
Contributor

czoido commented May 9, 2024

That's a fair point, but the old repo is pretty much dead and the fork is used as the main repo by all other package managers, including Debian/Ubuntu: https://repology.org/project/openni2/information

Hi @valgur, thanks for the info, I was digging a bit and looks like the own owners of the original repo recommend using the fork, so I think it's ok for the recipe to be named openni2 but please let's keep a comment in the recipe stating that this is the recommended fork from the original repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants