Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongo-cxx-driver: add version 3.10.1, update mongo-c-driver #23926

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

toge
Copy link
Contributor

@toge toge commented May 8, 2024

Specify library name and version: mongo-cxx-driver/3.10.1

mongodb/mongo-cxx-driver@r3.8.1...r3.10.1


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (230bd00eded92202e0df9542d890a5a65203ff4c):

  • mongo-cxx-driver/3.10.1:
    All packages built successfully! (All logs)

  • mongo-cxx-driver/3.8.1:
    All packages built successfully! (All logs)

  • mongo-cxx-driver/3.8.0:
    All packages built successfully! (All logs)

  • mongo-cxx-driver/3.6.7:
    All packages built successfully! (All logs)

  • mongo-cxx-driver/3.6.6:
    All packages built successfully! (All logs)

  • mongo-cxx-driver/3.6.1:
    All packages built successfully! (All logs)

  • mongo-cxx-driver/3.7.0:
    All packages built successfully! (All logs)

  • mongo-cxx-driver/3.6.2:
    All packages built successfully! (All logs)

  • mongo-cxx-driver/3.7.2:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (230bd00eded92202e0df9542d890a5a65203ff4c):

  • mongo-cxx-driver/3.8.1:
    All packages built successfully! (All logs)

  • mongo-cxx-driver/3.7.2:
    All packages built successfully! (All logs)

  • mongo-cxx-driver/3.10.1:
    All packages built successfully! (All logs)

  • mongo-cxx-driver/3.7.0:
    All packages built successfully! (All logs)

  • mongo-cxx-driver/3.8.0:
    All packages built successfully! (All logs)

  • mongo-cxx-driver/3.6.7:
    All packages built successfully! (All logs)

  • mongo-cxx-driver/3.6.1:
    All packages built successfully! (All logs)

  • mongo-cxx-driver/3.6.6:
    All packages built successfully! (All logs)

  • mongo-cxx-driver/3.6.2:
    All packages built successfully! (All logs)

@bisht2050
Copy link

Could this be merged sooner please?

@bisht2050
Copy link

@uilianries Could you please help review / merge this?

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked mongodb/mongo-cxx-driver@r3.8.1...r3.10.1. I saw several changes in cmake files, but most is formatting, nothing really breaking.

@uilianries uilianries self-assigned this Jul 4, 2024
@bisht2050
Copy link

Thank you @uilianries! Could you please suggest a second reviewer that can review (and merge) this PR?

@uilianries
Copy link
Member

Thank you @uilianries! Could you please suggest a second reviewer that can review (and merge) this PR?

@bisht2050 It's marked already (internal) to other team member review the PR, so don't worry. 😄

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@conan-center-bot conan-center-bot merged commit 451a568 into conan-io:master Jul 4, 2024
53 checks passed
@mrbald
Copy link

mrbald commented Jul 5, 2024

This commit retrospectively changes the dependency graph of 3.8.1 and others (the version of the mongo-c-driver), this looks wrong (and broke a few of my projects). It should be a fundamental rule to not update dependency trees of published versions. Before the change 3.8.1 was dependent on 1.24.3 and now it thinks it depends on a newer version.

@uilianries
Copy link
Member

@mrbald Sorry hear that!

Before the change 3.8.1 was dependent on 1.24.3 and now it thinks it depends on a newer version.

Do you have a reference about mongo-cxx-driver/3.8.1 requiring that old version? Is it incompatible with this new release?

As workaround, you can enforce to use any specific version by adding replace_requires in your profile.

It should be a fundamental rule to not update dependency trees of published versions.

It's true when only bumping a version (touching only conandata.yml and config.yml), but this PR has changes in the recipe conanfile.py too, which results building all versions again. It's a general CI rule.

In case you need to isolate your environment to avoid changes from CCI that could break you, there is a documented recommendation here: https://github.com/conan-io/conan-center-index/blob/master/docs/faqs.md#how-to-protect-my-project-from-breaking-changes-in-recipes. Basically, you can use a Fork of CCI and a local Artifactory, or, a lockfile that guarantees the very same graph always.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants