-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mongo-cxx-driver: add version 3.10.1, update mongo-c-driver #23926
mongo-cxx-driver: add version 3.10.1, update mongo-c-driver #23926
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline ✔️
All green in build 3 (
|
Could this be merged sooner please? |
@uilianries Could you please help review / merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked mongodb/mongo-cxx-driver@r3.8.1...r3.10.1. I saw several changes in cmake files, but most is formatting, nothing really breaking.
Thank you @uilianries! Could you please suggest a second reviewer that can review (and merge) this PR? |
@bisht2050 It's marked already (internal) to other team member review the PR, so don't worry. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This commit retrospectively changes the dependency graph of 3.8.1 and others (the version of the mongo-c-driver), this looks wrong (and broke a few of my projects). It should be a fundamental rule to not update dependency trees of published versions. Before the change 3.8.1 was dependent on 1.24.3 and now it thinks it depends on a newer version. |
@mrbald Sorry hear that!
Do you have a reference about mongo-cxx-driver/3.8.1 requiring that old version? Is it incompatible with this new release? As workaround, you can enforce to use any specific version by adding replace_requires in your profile.
It's true when only bumping a version (touching only conandata.yml and config.yml), but this PR has changes in the recipe conanfile.py too, which results building all versions again. It's a general CI rule. In case you need to isolate your environment to avoid changes from CCI that could break you, there is a documented recommendation here: https://github.com/conan-io/conan-center-index/blob/master/docs/faqs.md#how-to-protect-my-project-from-breaking-changes-in-recipes. Basically, you can use a Fork of CCI and a local Artifactory, or, a lockfile that guarantees the very same graph always. |
Specify library name and version: mongo-cxx-driver/3.10.1
mongodb/mongo-cxx-driver@r3.8.1...r3.10.1