Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcpcat library publish #24062

Merged
merged 17 commits into from
Jul 1, 2024
Merged

tcpcat library publish #24062

merged 17 commits into from
Jul 1, 2024

Conversation

ydcpp
Copy link
Contributor

@ydcpp ydcpp commented May 21, 2024

Specify library name and version: ydcpp-tcpcat/1.0.4

Hi,

I'm the author of tcpcat library. tcpcat is a simple and easy to use C++ TCP Client and Server library.
Just released the project and wanted to publish package also in conan center.
Thanks in advance!


@CLAassistant
Copy link

CLAassistant commented May 21, 2024

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ydcpp ydcpp mentioned this pull request May 21, 2024
@AbrilRBS AbrilRBS self-assigned this May 22, 2024
@conan-center-bot

This comment has been minimized.

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ydcpp thanks a lot for taking the time to submit your recipe, we appreciate it :)

I've taken the liberty to update the recipe with some improvements, and I've also left some comments - happy to hear your insight on those when you have a chance!

recipes/tcpcat/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/tcpcat/all/conanfile.py Outdated Show resolved Hide resolved
recipes/tcpcat/all/conanfile.py Outdated Show resolved Hide resolved
recipes/tcpcat/all/conanfile.py Outdated Show resolved Hide resolved
recipes/tcpcat/all/conanfile.py Outdated Show resolved Hide resolved
recipes/tcpcat/all/test_package/test_package.cpp Outdated Show resolved Hide resolved
@ydcpp ydcpp changed the title tcpcat 1.0.0 publish tcpcat 1.0.1 publish May 26, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ydcpp ydcpp changed the title tcpcat 1.0.1 publish tcpcat 1.0.2 publish May 26, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ydcpp ydcpp changed the title tcpcat 1.0.2 publish tcpcat library publish May 26, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ydcpp
Copy link
Contributor Author

ydcpp commented May 27, 2024

@RubenRBS I updated upstream and library name, please check again. thanks in advance!

@AbrilRBS
Copy link
Member

@ydcpp oh my, I missed the ping from 20 days ago, I'm so sorry for the delay, will get to this tomorrow first thing in the morning :)

@AbrilRBS
Copy link
Member

Alas, I needed @uilianries to double check for me. The remaining failing in Conan 2 in Windows comes from the fact that no symbols are exported. Do you plan on supporting windows shared builds, or should we validate it out?

@ydcpp
Copy link
Contributor Author

ydcpp commented Jun 19, 2024

@ydcpp oh my, I missed the ping from 20 days ago, I'm so sorry for the delay, will get to this tomorrow first thing in the morning :)

hi @RubenRBS thanks for the reply, I also need some assistance for the build error on macOS, Clang (M1/arm64) (build is successful but test is failing). Could you please check it when you have time?

@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

Hi @ydcpp sorry for the delay: We have now pushed the last fixes needed to get the recipe working. Note that as I explained in #24062 (comment), the current Windows shared builds have been disabled, as the current issue that no symbols are exported from your side in the library - let us know if you need any help with that, we can probably provide some hints as to how to better handle that on your side if needed :)

Other than that, we can merge the recipe after the current build succeeds, will keep an eye on it to ensure it gets thru to the finish line quickly. Again, thanks for your patience and follow-ups in this process

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 8b5b463
ydcpp-tcpcat/1.0.4@#3202abece933231c4dcd02c9d166ad06
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libydcpp-tcpcat.so' links to system library 'm' but it is not in cpp_info.system_libs.

AbrilRBS
AbrilRBS previously approved these changes Jun 29, 2024
@conan-center-bot

This comment has been minimized.

deps.generate()
tc = CMakeToolchain(self)
if not self.settings.get_safe("compiler.cppstd"):
tc.variables["CMAKE_CXX_STANDARD"] = self._min_cppstd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing something, because the project already does it: https://github.com/ydcpp/tcpcat/blob/1.0.4/CMakeLists.txt#L16

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I actually didn't catch that - let's just try with your test package changes, see if that fixes everything :)

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 17 (b841ae2167c86f842ad619ea8deba996b9607f2a):

  • ydcpp-tcpcat/1.0.4:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 17 (b841ae2167c86f842ad619ea8deba996b9607f2a):

  • ydcpp-tcpcat/1.0.4:
    All packages built successfully! (All logs)

@AbrilRBS AbrilRBS requested a review from uilianries June 30, 2024 07:01
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @ydcpp !!!

@conan-center-bot conan-center-bot merged commit eb5a081 into conan-io:master Jul 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants