-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove myself from the repository #24165
Conversation
Conan v1 pipeline ❌Sorry, the build is only launched for Access Request users. You can request access writing in this issue. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping See details:Sorry, the build is only launched for Access Request users. You can request access writing in this issue. |
Hi @ericLemanissier , we respect your decision and allow me to extend the thanks from the team for your long # contributions to the project. Since its inception, Conan Center has grown significantly. These days the remote receives request at a rate of 180 million per month, and this is also reflected in the pull request traffic. This puts a strain on our resources as maintainers, both at a human level and an infrastructure level.
When it comes to the contribution process, this is feedback that we have been receiving, continually, for the past two years - not only in the repository itself, not only in private, but also in person in conferences. There has been very consistent feedback that the contribution process to Conan center and the automations around it are noisy and confusing, and we continually notice users confused about who are the maintainers of the repository. Currently, PRs get messages from automations from up to 5 different bots, some of which are not maintained by us. Some are pull requests comments, some are GitHub actions that make code annotations, in some the information is duplicated (I suspect we have two automations that track recipes that are “ready to review”). Similar feedback was provided to us by new members of the team that have joined in the past year: that it is not clear what is mandatory, and who amongst the reviewers are decision makers. This led us to review the contribution process of similar repositories - and indeed we agree as a team that the contribution process is not welcoming to new and casual contributors. This tends to contribute to the noise and in the vast majority of cases, and in most cases the mentioned users never interact. There is also no process to identify which users are or are not actively contributing, and this has caused misleading CI alerts in the past (failed workflows send emails to the contributor, IIRC). This has confused users, since it alerts, in the PR, users that are not affiliated with the project, sending a rather confusing message about ownership. The team has also felt “less empowered” to make decisions - despite the fact that they are the maintainers of the repository. I personally think it's important the team feels empowered to make decisions, even if they are the wrong ones. Mistakes can happen, but the team will learn from them to provide a better experience to our users. If widely use recipes present problems, we will be the ones that are contacted, and we will be the ones to respond (under pressure). We have not seen examples of other repositories operating this way. We are very happy for contributors to keep an eye out for recipes they are interested in, I suspect the automation can be repurposed and run on a separate GitHub repository. What we ask is that it does not leave comments in the pull request. If the notified users want to comment on the PR themselves, they are welcome to.
The “v2” linter is an unfortunate piece of code. Our colleague that maintained it has since left the team, it recently this has been posting flat out wrong diagnostics on pull requests - confusing our contributors, and hindering our job as reviewers. When the linter was introduced, I remember explicitly that this was done with the understanding that it was limited in time (While CI was not checking recipes for v2), and that everything was shown as warnings that were optional (because v2 was not mandatory back then). It has since transpired that despite having an expiration date, a more generic python linter was also added as part of the functionality. For what it is worth, we have been monitoring the failures - and the true positive rates of issues that are otherwise not caught by the proper CI run - is actually quite low. So in the short term we have determined that it is a relatively low risk to remove, until we repurpose the useful bits in the new redesigned pipeline. I am grateful for your PR to remove the v2 aspect of it and keep the generic linter, but we don’t currently have the resources to maintain this piece of code - this also means reviewing any contributions to the
I wholeheartedly sympathize with users and contributors who find that their pull requests and reported issues are not being resolved quickly enough. After all, they are using their own time and efforts to contribute to the project. On the one hand, as projects grow larger in user base, so do the number of requests, reaching a point where maintainers are unable to resolve them as quickly as they come. This has made us analyze how we work and how we can improve this.
On the other hand, the volume is such that we need to prioritize - and we believe it makes sense to align ourselves with the demands of the users of Conan Center, which is a much larger group than both maintainers and community contributors. Oftentimes receive PRs with unclear motivations, or where it is unclear if it benefits users (consumers of Conan Center packages via the remote, or the repository). Please also keep in mind that some users are enterprise users, running their own infrastructure, operating with their own forks of Conan Center - that reach out to us directly. So we have a broader visibility to help us understand the pain points of our users.
This is also part of our efforts to focus on what matters. For #23662, the user already had a locally served fork of the recipe, as well as publicly available versions in Conan Center that had the fix they needed. There was nothing else to discuss - and locking discussions is a useful mechanism to avoid unfruitful discussions. For #23662, the discussion around the test package has happened in 3 different pull requests if I’m not mistaken - we are asking that if there are actual issues, that these are reported and discussed in a separate issue. Worth mentioning that we have added more testing to the protobuf test package as a result of these discussions. We do have plans to reinstate or have the ability to include more complex tests, which will be rolled out in the coming months For #23594 - we had a look at what was going on under the hood and determined that the proposed changes had no effect. It’s an internal discussion as far as I’m concerned, and I apologize that the PR description led you (or anyone) to believe that it would improve the issue. As for the point of adapting our infrastructure and resources, this is what we have been working on in the past few months - the following is the changelog for our new CI features that are ready to be rolled out in the next quarter, and most of the bullet points are already working in the current implementation:
Our focus is to make sure that the widest possible user base benefits from what we offer in Conan Center, and that pull requests are prioritized and reviewed as quickly as possible, where resources allow. Additionally, we want to make sure the PRs we prioritize are aligned with that goal, and that contributors have a better and more friendly interaction with all the automations in the CI system. Thank you for your continued contributions, and the Conan Center community will be here should you decide to come back. |
You have been an incredible contributor to Bincrafters and CCI, and in general with all of your recipes, tooling and ideas for the Conan ecosystem. I hope that this is a "see you later" instead of a goodbye @ericLemanissier ❤️ I also feel somewhat alienated by some decisions in the last months. I think that part of this situation is the shift from having discussions on GitHub in the open, where everyone can contribute to finding a solution, towards more and more team internal meetings where only the finalized decisions are getting presented ( |
I've been away from the conan world for the last few months so I feel like I've missed a lot of the recent struggles. I'm not a full time tooling guy, so I drift back and forth between different development modes. I've personally burned a lot of my time tooling up with conan v1 and upgrading to conan v2, but I kept going with the belief that It Would All Work Out In The End. I would've burned a lot more time and gotten completely stuck without @ericLemanissier's help and efforts along the way. JFrog has effectively had a valuable unpaid employee in Eric for a long time now, and conan will be worse off without him. I see his comments and I subscribe to track PRs and issues, I branch and merge the patches that are still pending (for long periods of time). I don't send a lot of messages of support and "this affects me too" because I didn't want to spam everyone, but perhaps I should've to make it known what problems were blockers for more people than just one guy. The scale is increasing, and we are going to need more people with the skills and experience in fixing the difficult recipe problems. Eric (and other high-volume contributors) are like a canary in a coal mine. If he is happy, chances are many other package users and maintainers are happy (but we won't hear from them as there are no problems). |
Well I found some of those bots handy. The fact that the bot was written should tell the team that we need something like this for people like me. |
Hi @Croydon @paulharris and all, I could discuss a lot of things in this thread, but I’ll try to be short. The recent controversial items have been:
Everytime we have had to take one of these decisions, even when they were discussed in public, we have got just really strong push back. This also diminishes our work as maintainers. There have been instances where we have been told that we should just only approve and merge PRs if they are green, neglecting not only the expertise and way broader perspective of the team, but also the responsibility that the maintainers have with the wider community of Conan users. To summarize, I’d like to reiterate my acknowledgment, say a very big thank you to @ericLemanissier for the amazing contributions that you have made. I fully understand that you are not feeling aligned with the direction that ConanCenter needs to move, and you do not plan to contribute any further. Even if you don’t believe me, we have done our best, a humongous effort to try to serve you as well as possible, so while I am happy how we have joined efforts this time, I am really sad to see and listen to the hate and resentment that I appreciate in these comments and actions, I think it is not deserved, and I had hoped that we could part ways in a more friendly manner. I really wish you all the best. |
I see your work @memsharded, and commend your efforts. Like I said, I've been away for a while and I can see there are a lot of positive improvements in that time (conan, the command itself, is working a lot better for me today than it did before). On the 3 points you made:
|
Thank you all for the kind words and reactions. It's very much appreciated 🙏 . And thanks to the team for taking the time to write so detailed answers.
@memsharded There is absolutely no hate in me. I'll be explicit about the other side of the coin, hopefully sounding less childish and ungrateful than in my first message: Conan is a great project, and I know you (the team) are all putting in a tremendous amount of effort to make it live and improve it, both on conan and conan-center-index side. For Conan, new features like
To be clear, I do not agree with all what was said by the op on issue 17921 : CCI needs more reviews, not less. They are absolutely fundamental for the quality of recipes. I reacted to the suppression of automatic merge of bumps because it means the reviewers have even less time to review other pull requests.
@jcar87 This is a very strong and clear signal you are sending: the team can and will (and did) prevent technical discussions, without warning, even in the absence of spam, troll, disrespect, off-topic etc. I may be alone on this, but this is sufficient to drive me away from contributing for long. Code of conduct goes both ways. By the way, to everybody: feel free to reuse code from my closed PRs or archived repositories. If it's written (and if it's useful), it might as well be used. |
I'll also chime in, I haven't been super heavily involved as some of the other people here (thank you everyone who contributes!), but I've seen enough to form a few opinions:
Please note as with others, this comes from me wanting to see CCI thrive - I enjoy working with Conan and the people who work on and use it, but these are certainly things that should be addressed. |
I have to echo the comments on long delays in PR reviews having an impact on the engagement of contributors. #22997 has now been green for months with no further progress. I can maintain recipes for my own use in my own repositories but I'm becoming increasingly disillusioned with making further contributions to CCI which is a shame. |
Ditto for #24577 and related PRs that only get any attention only begrudgingly and semi-accidentally, it seems, despite the proposed solutions being polished and tested across tens of packages in my private fork (valgur/conan-center-index) for several months by now. Comments like
that imply that the few active CCI contributors somehow operate in a frivolous vacuum and don't actually count as real users (which is definitely not the case, I'm just not going to go into detail about the non-public uses of my contributions unnecessarily) is borderline insulting and really really does not help. I definitely understand that there's a finite number of hours available for the maintainers and there's a need to heavily prioritize the work. A honest timeframe for features that you don't consider urgent or revenue-adjacent would be sufficient and more helpful. I'm feeling quite close to revoking my CLA altogether, but I'm willing to give it another month or three. |
I really appreciate the contributions of all of the community contributors, who work really hard to make Conan better. Like, @valgur, I've done work to improve / add packages for my company's use case. Sometimes that work has simply stagnated over time while other times has been shutdown with no real recourse other than perhaps opening an issue that seems unlikely to go anywhere at all. It's been pretty disheartening to see some of the best community contributors stop contributing due to these similar kinds of frustrations. |
Conan-center-index has very regrettably become less and less welcoming to contributors in the passed months. Among other things: