Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opendis6: Update package name #24487

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

crhowell3
Copy link
Contributor

@crhowell3 crhowell3 commented Jul 1, 2024

Summary

Changes to recipe: opendis6/0.1.0 -> libsersi/0.1.0

Motivation

I am attempting to get this package published on vcpkg as well, but the current name is too easily confused with another package that has similar capabilities. I have since updated the repository name and the CMake package name from opendis6 to libsersi. As such, the package information that I previously published here will need to be updated for the sake of consistency; also, this change has broken the package information published here to conan, so in order to restore functionality, this change will need to get merged in.

Details

See above. This is really just a name change due to conflicts with another package.


@conan-center-bot

This comment has been minimized.

@crhowell3
Copy link
Contributor Author

crhowell3 commented Jul 1, 2024

Let me know as well if this type of change is possible. I'm just renaming my package to be compliant and consistent with changes I had to make to get this package published to microsoft/vcpkg.

@crhowell3 crhowell3 marked this pull request as ready for review July 1, 2024 19:27
@AbrilRBS AbrilRBS self-assigned this Jul 2, 2024
@AbrilRBS
Copy link
Member

AbrilRBS commented Jul 2, 2024

Hi @crhowell3 thanks a lot for taking the time to update the library in Conan Center, we appreciate it. I'll talk with the team on how to best deal with this, but as far as I can see, your approach is correct, will let you know more in a bit :)

@crhowell3
Copy link
Contributor Author

Hello @AbrilRBS, thanks for the comment! Have there been any updates regarding this issue?

@AbrilRBS
Copy link
Member

Hi @crhowell3 sorry for not communicating better, I usually compile some CCI issues for the week and bring them all at once - my next planned meeting is tomorrow, so I'll let you know once we come up with a conclussion :)

@uilianries
Copy link
Member

@crhowell3 Hello! After talking with Conan team, including @AbrilRBS we opened 2 PRs to solve your current case. The CI does not allow and is not prepared to rename a project, it may break internally.

This first PR adds attributes to mark the recipe as deprecated. As effect, anyone consuming the latest recipe revision, will receive a warning message about the deprecation and an advise about to use libdis6 instead. The CI should not fail to download the tar file, because we use source backup.

This new PR is based in yours, only a small fix in the test_package.cpp updating the included header name. It will close this PR as soon as it gets merged.

Regards!

@crhowell3
Copy link
Contributor Author

@uilianries Thank you for handling this! Before getting these merged in, I may have to make a couple more changes. I received some feedback from the vcpkg team, and they are requesting a different package name altogether. I am working on getting that approved, and when I do, I'll update those PRs with the changes that I have to make. I appreciate you and your team handling this issue!

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes so this does not get merged by accident - we'll wait for you to decide ona. final name, let us know once that's ready! :)

@crhowell3
Copy link
Contributor Author

@uilianries @AbrilRBS I have settled on a new name and have also gotten approval from the vcpkg team. The name for the library is now libsersi. I have made all appropriate updates to my upstream to accommodate this change.

With that in mind, do I need to contribute anything towards the 2 open PRs, or is that being handled internally by your team?

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Changes not allowed in build 3:

[libdis6, opendis6]

Only one library can be changed in the same PR.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Changes not allowed in build 3:

[libdis6, opendis6]

Only one library can be changed in the same PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants