Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmtime: add version 25.0.2 #24714

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

toge
Copy link
Contributor

@toge toge commented Jul 25, 2024

Summary

Changes to recipe: wasmtime/25.0.0

Motivation

Major version up.

Details

bytecodealliance/wasmtime@v21.0.0...v25.0.2


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 7aad1fd
wasmtime/23.0.1@#4b9b24feacbe80d04b306c6aeca6d636
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libwasmtime.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
wasmtime/18.0.3@#02227a02bb2fdc9bfa2ce8afd02838e9
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libwasmtime.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
wasmtime/20.0.1@#3ff8995a9ccfabbd85c9f2dd499af28d
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libwasmtime.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
wasmtime/21.0.0@#69fa2bc2d5ff9e487fc697f77d9064e5
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libwasmtime.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
wasmtime/19.0.2@#fde340713ae2411434b7ef48ea0d461a
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libwasmtime.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.

@perseoGI perseoGI self-assigned this Jul 26, 2024
perseoGI
perseoGI previously approved these changes Jul 26, 2024
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perseoGI perseoGI requested a review from uilianries July 26, 2024 08:46
@uilianries uilianries self-assigned this Jul 26, 2024
@toge toge changed the title wasmtime: add version 23.0.1 wasmtime: add new version 23.0.1 Jul 29, 2024
@toge toge changed the title wasmtime: add new version 23.0.1 wasmtime: add version 23.0.1 Aug 5, 2024
@toge
Copy link
Contributor Author

toge commented Aug 12, 2024

@uilianries
pr-merge in CI is a last piece.
Do you have any way to solve this problem?

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 07b18b1
wasmtime/23.0.1@#8179b88428dbccefd351b58468a4e7ee
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libwasmtime.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
wasmtime/20.0.1@#17f6c47087087edf2adedea19c528baa
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libwasmtime.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
wasmtime/18.0.3@#cb3f5f892958985de8f76e24a8bafefa
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libwasmtime.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
wasmtime/21.0.0@#04a0223ca0f44f1bfef58e7d435f984b
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libwasmtime.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.
wasmtime/19.0.2@#8ff246bf2c8bab9c37cbe43dfd2ca1f0
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libwasmtime.dylib' links to system library 'CoreFoundation' but it is not in cpp_info.frameworks.

@conan-center-bot

This comment has been minimized.

perseoGI
perseoGI previously approved these changes Aug 13, 2024
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ErniGH
ErniGH previously approved these changes Aug 19, 2024
@toge toge dismissed stale reviews from ErniGH and perseoGI via ed01620 September 21, 2024 12:04
@toge toge changed the title wasmtime: add version 23.0.1 wasmtime: add version 25.0.0 Sep 21, 2024
@conan-center-bot

This comment has been minimized.

perseoGI
perseoGI previously approved these changes Sep 23, 2024
Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toge toge changed the title wasmtime: add version 25.0.0 wasmtime: add version 25.0.2 Oct 9, 2024
@conan-center-bot

This comment has been minimized.

AbrilRBS
AbrilRBS previously approved these changes Oct 10, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toge can you remove the 6.0.1 from the config.yml? There is no corresponding entry in the conandata.yml file :)

@toge
Copy link
Contributor Author

toge commented Oct 10, 2024

@AbrilRBS
Thank you for your review!
I fixed.

sha256: "8cc68c43559c78e103bebf63ba16b768f7bb9c0ba164649279c1a09be690b416"
Android:
"armv8":
url: "https://github.com/bytecodealliance/wasmtime/releases/download/v25.0.2/wasmtime-v25.0.2-aarch64-linux-c-api.tar.xz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the linux release, but there seems to be a typo? The release contains Android files. Is this duplicatin in pourpose?

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking while we check

@jcar87
Copy link
Contributor

jcar87 commented Oct 10, 2024

As @AbrilRBS mentions, we just ran this PR in our new pipeline (which is still internal) and detected two issues:

Screenshot 2024-10-10 at 10 24 31

The first one is that the config.yaml and the conandata.yaml seem to have an inconsistency (there's a version in config.yml that is not present in conandata. This is not detected by the current linter, and it is not detected when the source() method is executed for the missing version - because that version is not built due to invalid configuration.

I suspect this issue predates this PR - the new pipeline would have stopped this at the PR that introduced the change.

On the other hand, there is a second issue where there are two duplicated checksums - this is already reported by the linter that we enabled yesterday (results here https://github.com/conan-io/conan-center-index/pull/24714/checks?check_run_id=31342639853)

The warning message needs improving - however it appears to be correct. The entry for android is the same as for Linux, but it seems upstream does have a separate package for Android: https://github.com/bytecodealliance/wasmtime/releases/
It's still within the realm of possibilities that since Android is Linux at the low level, the "c-package" is the same for Android and Linux, but it's worth checking this.

(the other warnings by the linter can be disregarded, we are working on improving the detection of mismatches between the version and the URL)

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 13 (204bce852bf167b2e47d3a20c851ab2bdfa69cd1):

  • wasmtime/21.0.0:
    Built 16 packages out of 22 (All logs)

  • wasmtime/25.0.2:
    Built 8 packages out of 22 (All logs)

  • wasmtime/19.0.2:
    Built 16 packages out of 22 (All logs)

  • wasmtime/18.0.3:
    Built 16 packages out of 22 (All logs)

  • wasmtime/20.0.1:
    Built 16 packages out of 22 (All logs)

  • wasmtime/16.0.0:
    Built 16 packages out of 22 (All logs)

  • wasmtime/9.0.1:
    Built 16 packages out of 22 (All logs)

  • wasmtime/12.0.2:
    Built 16 packages out of 22 (All logs)

  • wasmtime/7.0.0:
    Built 16 packages out of 22 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 9 (204bce852bf167b2e47d3a20c851ab2bdfa69cd1):

  • wasmtime/25.0.2:
    Built 6 packages out of 10 (All logs)

  • wasmtime/21.0.0:
    Built 8 packages out of 10 (All logs)

  • wasmtime/16.0.0:
    Built 8 packages out of 10 (All logs)

  • wasmtime/20.0.1:
    Built 8 packages out of 10 (All logs)

  • wasmtime/18.0.3:
    Built 8 packages out of 10 (All logs)

  • wasmtime/12.0.2:
    Built 8 packages out of 10 (All logs)

  • wasmtime/7.0.0:
    Built 8 packages out of 10 (All logs)

  • wasmtime/9.0.1:
    Built 8 packages out of 10 (All logs)

  • wasmtime/19.0.2:
    Built 8 packages out of 10 (All logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants