-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasmtime: add version 25.0.2 #24714
base: master
Are you sure you want to change the base?
wasmtime: add version 25.0.2 #24714
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 7aad1fdwasmtime/23.0.1@#4b9b24feacbe80d04b306c6aeca6d636
wasmtime/18.0.3@#02227a02bb2fdc9bfa2ce8afd02838e9
wasmtime/20.0.1@#3ff8995a9ccfabbd85c9f2dd499af28d
wasmtime/21.0.0@#69fa2bc2d5ff9e487fc697f77d9064e5
wasmtime/19.0.2@#fde340713ae2411434b7ef48ea0d461a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@uilianries |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 07b18b1wasmtime/23.0.1@#8179b88428dbccefd351b58468a4e7ee
wasmtime/20.0.1@#17f6c47087087edf2adedea19c528baa
wasmtime/18.0.3@#cb3f5f892958985de8f76e24a8bafefa
wasmtime/21.0.0@#04a0223ca0f44f1bfef58e7d435f984b
wasmtime/19.0.2@#8ff246bf2c8bab9c37cbe43dfd2ca1f0
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@toge can you remove the 6.0.1 from the config.yml? There is no corresponding entry in the conandata.yml file :)
@AbrilRBS |
sha256: "8cc68c43559c78e103bebf63ba16b768f7bb9c0ba164649279c1a09be690b416" | ||
Android: | ||
"armv8": | ||
url: "https://github.com/bytecodealliance/wasmtime/releases/download/v25.0.2/wasmtime-v25.0.2-aarch64-linux-c-api.tar.xz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the linux release, but there seems to be a typo? The release contains Android files. Is this duplicatin in pourpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking while we check
As @AbrilRBS mentions, we just ran this PR in our new pipeline (which is still internal) and detected two issues: The first one is that the config.yaml and the conandata.yaml seem to have an inconsistency (there's a version in I suspect this issue predates this PR - the new pipeline would have stopped this at the PR that introduced the change. On the other hand, there is a second issue where there are two duplicated checksums - this is already reported by the linter that we enabled yesterday (results here https://github.com/conan-io/conan-center-index/pull/24714/checks?check_run_id=31342639853) The warning message needs improving - however it appears to be correct. The entry for android is the same as for Linux, but it seems upstream does have a separate package for Android: https://github.com/bytecodealliance/wasmtime/releases/ (the other warnings by the linter can be disregarded, we are working on improving the detection of mismatches between the version and the URL) |
Conan v1 pipeline ✔️Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. All green in build 13 (
Conan v2 pipeline ✔️
All green in build 9 (
|
Summary
Changes to recipe: wasmtime/25.0.0
Motivation
Major version up.
Details
bytecodealliance/wasmtime@v21.0.0...v25.0.2