-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sfml: Test suport for SFML 3 rc1 #25305
base: master
Are you sure you want to change the base?
Conversation
This reverts commit 9fb2cf0.
This comment has been minimized.
This comment has been minimized.
Here are some traces of the
Everything works good 🚀 |
I'm now also trying Windows ARM build after backporting SFML/SFML#3229
Static builds can run the win32 example but I'm finding compilation issues in shared builds:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 4b81904sfml/3.0.0-rc.1@#6aa0eb396136914932df587135e54750
|
This comment has been minimized.
This comment has been minimized.
Seems like they are improving the vendored libraries situation in SFML/SFML#3141 with a clear |
Conan v1 pipeline ✔️Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. All green in build 14 (
Conan v2 pipeline ✔️
All green in build 14 (
|
Summary
Changes to recipe: sfml/3
Motivation
They recently released the first RC for 3.0, and wanted to get ahead of the curve with it. This probably won't get merged until the official 3.0 release, but it can't hurt to do the work now
Details
The
2.X
changes are just the moved files from the oldall
, I screwed the moving and Git thinks they are new files. Theall
recipe for version 3 is better reviewed without a diff, as it's a new recipeThings to note:
graphic
dependant tests when-o="*:shared=False"
, help is appreciatedisland
example:window
example also fails in macos withindow/Window.cpp:9:10: fatal error: 'gl.h' file not found
, not sure if a setup issue or a real recipe buguse_drm
option onwindow
, contributions are welcomedextlibs
opengl
option forwindow
has not been tested fully, I lack the necessary insight for that. In fact, opengl support in general might be lacking, both in those that require it, and those which the system provides it, for example these lines are somewhat of a guess, but Android seems to still be working :)system_libs
is enough, but can't be sureCMakeDeps
withcheck_components_exist=True
if using the official names (ie,Graphics
component is namedSFML::Graphics
for now)All in all, it was a pleasant experience, kudos to the SFML team for their release and having a super readeable CMakeLists!
Thanks to @ErniGH @perseoGI & @czoido for their additional help in testing in different platforms