-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PcapPlusPlus: add version 24.09 #25348
PcapPlusPlus: add version 24.09 #25348
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@AbrilRBS can you please take a look at this PR? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work now, sorry for the noise!
This comment has been minimized.
This comment has been minimized.
@AbrilRBS unfortunately CI still fails 😢 |
This seems like a real compilation issue when compiling with msvc as a shared library. Do you have any insight into those actual errors? |
@AbrilRBS Yes, compiling with MSVC as a shared library doesn't work and it's a known issue: seladb/PcapPlusPlus#1396 |
@seladb I've pushed some changes in I'm being conservative and just added the check for the current versions, so when we add a new version in the future, the same compilation issue will pop up and we'll need to update the recipe. This is on pourpose so that once/if you fix this upstream, we don't inadvertedly miss on out on it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, thanks a lot for your patience :)
Conan v1 pipeline ✔️Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. All green in build 12 (
Conan v2 pipeline ✔️
All green in build 13 ( |
Hooks produced the following warnings for commit 4485789pcapplusplus/23.09@#efb89b3ee6d2360da8039ba5c4f3dabb
pcapplusplus/24.09@#9373f5aaa1bb77660632aa57a403a4cb
|
Thank you so much @AbrilRBS for your help, much appreciated! 🙏 |
Summary
Changes to recipe: pcapplusplus/24.09
Motivation
This is a new version of PcapPlusPlus, released a year after the previous version. It contains a lot of updates and changes
Details
High level summary of the changes: https://github.com/seladb/PcapPlusPlus/releases/tag/v24.09
Full Changelog:
v23.09...v24.09