Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PcapPlusPlus: add version 24.09 #25348

Merged
merged 13 commits into from
Oct 11, 2024

Conversation

seladb
Copy link
Contributor

@seladb seladb commented Sep 21, 2024

Summary

Changes to recipe: pcapplusplus/24.09

Motivation

This is a new version of PcapPlusPlus, released a year after the previous version. It contains a lot of updates and changes

Details

High level summary of the changes: https://github.com/seladb/PcapPlusPlus/releases/tag/v24.09
Full Changelog: v23.09...v24.09


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@toge toge mentioned this pull request Sep 21, 2024
3 tasks
@AbrilRBS AbrilRBS self-assigned this Sep 23, 2024
@seladb
Copy link
Contributor Author

seladb commented Sep 30, 2024

@AbrilRBS can you please take a look at this PR?

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

AbrilRBS
AbrilRBS previously approved these changes Oct 9, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work now, sorry for the noise!

@AbrilRBS AbrilRBS requested a review from valgur October 9, 2024 21:58
@conan-center-bot

This comment has been minimized.

@seladb
Copy link
Contributor Author

seladb commented Oct 10, 2024

@AbrilRBS unfortunately CI still fails 😢

@AbrilRBS
Copy link
Member

This seems like a real compilation issue when compiling with msvc as a shared library. Do you have any insight into those actual errors?

@seladb
Copy link
Contributor Author

seladb commented Oct 11, 2024

This seems like a real compilation issue when compiling with msvc as a shared library. Do you have any insight into those actual errors?

@AbrilRBS Yes, compiling with MSVC as a shared library doesn't work and it's a known issue: seladb/PcapPlusPlus#1396
We should not allow it in the Conan recipe

@AbrilRBS
Copy link
Member

@seladb I've pushed some changes in cf6a752 (#25348) that tell Conan to not compile for that configuration.

I'm being conservative and just added the check for the current versions, so when we add a new version in the future, the same compilation issue will pop up and we'll need to update the recipe. This is on pourpose so that once/if you fix this upstream, we don't inadvertedly miss on out on it :)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks a lot for your patience :)

@AbrilRBS AbrilRBS self-requested a review October 11, 2024 07:25
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 12 (4485789287073c3f1cd0b1845f5033f3213567c5):

  • pcapplusplus/23.09:
    Built 18 packages out of 22 (All logs)

  • pcapplusplus/24.09:
    Built 18 packages out of 22 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 13 (4485789287073c3f1cd0b1845f5033f3213567c5):

  • pcapplusplus/24.09:
    Built 7 packages out of 10 (All logs)

  • pcapplusplus/23.09:
    Built 7 packages out of 10 (All logs)

Copy link
Contributor

Hooks produced the following warnings for commit 4485789
pcapplusplus/23.09@#efb89b3ee6d2360da8039ba5c4f3dabb
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libPacket++.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libPcap++.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libCommon++.so' links to system library 'm' but it is not in cpp_info.system_libs.
pcapplusplus/24.09@#9373f5aaa1bb77660632aa57a403a4cb
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libPacket++.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libPcap++.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libCommon++.so' links to system library 'm' but it is not in cpp_info.system_libs.

@seladb
Copy link
Contributor Author

seladb commented Oct 11, 2024

Looks good now, thanks a lot for your patience :)

Thank you so much @AbrilRBS for your help, much appreciated! 🙏

@AbrilRBS AbrilRBS requested review from czoido and removed request for valgur October 11, 2024 08:48
@conan-center-bot conan-center-bot merged commit 9f61a4f into conan-io:master Oct 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants