openjdk license: combine the 2 expressions into one for SBOM generator compatibility #25367
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow the license to be valid when using Conan's SBOM generator extension, we have to use only one element when using SPDX expressions. I'm unsure whether multiple WITH operators are valid, so I propose to use a AND operator.
|
|
Conan v1 pipeline ❌Sorry, the build is only launched for Access Request users. You can request access writing in this issue. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping Sorry, the build is only launched for Access Request users. You can request access writing in this issue. |
valgur
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: openjdk all versions, licence attribute
Motivation
When using the Conan SBOM generator extension, the CycloneDX library rejects the licence information because it's using SPDX expressions, and in this case, there can be only one element.
Details
To allow the license to be valid when using Conan's SBOM generator extension, we have to use only one element when using SPDX expressions. I'm unsure whether multiple WITH operators are valid, so I propose to use a AND operator. WITH has precedence over AND, so no parenthesis is needed.
NOTICE: I didn't read any of the CLA text I signed, nor did I read the contributing guidelines.