Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost: don't modify user-config.jam in-source #25826

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Nov 4, 2024

Summary

Changes to recipe: boost/[*]

Motivation

user-config.jam, which contains the necessary build info about the toolchain and external libs, is currently being modified in-place at <source_folder>/tools/build/user-config.jam. This is a pretty bad idea given that the recipe is using no_copy_source=True and that the location of the user-config.jam file is provided via a CLI argument anyway.

Details

This PR moves the user-config.jam generation from build() to generate() and stores the file in self.generators_folder.

A few other minor cosmetic changes to the recipe as well.

/cc @AbrilRBS, since you were recently adding warnings for source modifications with no_copy_source=True.


This is bug-prone due to no_copy_source=True.
It can safely be written to the generators folder instead.
@valgur
Copy link
Contributor Author

valgur commented Nov 4, 2024

Here's an example of what the user-config.jam contents look like for the default config:

using zlib : 1.3.1 : <include>"/home/martin/.conan2/p/b/zlib6e767fad2584e/p/include" <search>"/home/martin/.conan2/p/b/zlib6e767fad2584e/p/lib" <name>z ;
using bzip2 : 1.0.8 : <include>"/home/martin/.conan2/p/b/bzip2196a3629ff437/p/include" <search>"/home/martin/.conan2/p/b/bzip2196a3629ff437/p/lib" <name>bz2 ;
using "clang-linux" :  :  "/usr/bin/clang++-18" : 
<compileflags>"-I/home/martin/.conan2/p/b/libbacfc60a05f6f20/p/include" <linkflags>"-L/home/martin/.conan2/p/b/libbacfc60a05f6f20/p/lib"  ;

@AbrilRBS AbrilRBS self-assigned this Nov 4, 2024
@valgur valgur changed the title boost: don't modify user-config.jam inside the source tree boost: don't modify user-config.jam in-source, simplify cppstd handling Nov 6, 2024
@valgur valgur changed the title boost: don't modify user-config.jam in-source, simplify cppstd handling boost: don't modify user-config.jam in-source Nov 13, 2024
@valgur
Copy link
Contributor Author

valgur commented Nov 13, 2024

Regarding

A job has not been automatically scheduled because author has too many pull requests open.

Should I close about 200 out of my 214 currently open PRs to see any kind of CI activity at all? I doubt you're keen on keeping manually triggering these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants