Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Boost::ext].UT / μt #3997

Merged
merged 23 commits into from
Dec 29, 2020
Merged

[Boost::ext].UT / μt #3997

merged 23 commits into from
Dec 29, 2020

Conversation

jwillikers
Copy link
Contributor

Specify library name and version: ut/1.1.8

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

This PR adds the C++20 header only unit-testing framework, [Boost::ext].μt.
This library belongs to the unofficial Boost libraries in Boost-ext.

@CLAassistant
Copy link

CLAassistant commented Dec 26, 2020

CLA assistant check
All committers have signed the CLA.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'ut/1.1.8' failed in build 1 (ae75eac4368b7cf5f12eb455adeb592e6ef2d485):

@conan-center-bot
Copy link
Collaborator

Recipe syntax error in build 2:

WARN: Remotes registry file missing, creating default one in /home/conan/w/cci_PR-3997/2/ad552836-986a-497b-9db1-771c96b74715/.conan/remotes.json
ERROR: Error loading conanfile at '/home/conan/w/cci_PR-3997/recipes/ut/all/conanfile.py': Unable to load conanfile in /home/conan/w/cci_PR-3997/recipes/ut/all/conanfile.py
  File "/opt/pyenv/versions/3.7.5/lib/python3.7/site-packages/conans/model/ref.py", line 197, in loads
    name, version, user, channel, revision = get_reference_fields(text)
  File "/opt/pyenv/versions/3.7.5/lib/python3.7/site-packages/conans/model/ref.py", line 66, in get_reference_fields
    el1, el2 = _split_pair(arg_reference, "/") or (arg_reference, None)
  File "/opt/pyenv/versions/3.7.5/lib/python3.7/site-packages/conans/model/ref.py", line 18, in _split_pair
    raise ConanException("The reference has too many '{}'".format(split_char))
conans.errors.ConanException: The reference has too many '/'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/pyenv/versions/3.7.5/lib/python3.7/site-packages/conans/client/loader.py", line 382, in _parse_conanfile
    loaded = imp.load_source(module_id, conan_file_path)
  File "/opt/pyenv/versions/3.7.5/lib/python3.7/imp.py", line 171, in load_source
    module = _load(spec)
  File "<frozen importlib._bootstrap>", line 696, in _load
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 724, in exec_module
  File "<frozen importlib._bootstrap_external>", line 860, in get_code
  File "<frozen importlib._bootstrap_external>", line 791, in source_to_code
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/cci_PR-3997/recipes/ut/all/conanfile.py", line 51
    if self.settings.compiler == compiler
                                        ^
SyntaxError: invalid syntax


@conan-center-bot
Copy link
Collaborator

Failure in build 3 (6f1b230b9275c1bba35884f41f31325470481ed8):

  • ut/1.1.8:
    • Zero packages generated. Looks like all configurations have been discarded by ConanInvalidConfiguration exceptions

@conan-center-bot
Copy link
Collaborator

Failure in build 4 (54aa6bb183dc6ead3370f9b72742718d3113d030):

  • ut/1.1.8
    • 'conan export' command failed (ref 'ut/1.1.8'):

WARN: Remotes registry file missing, creating default one in /home/conan/w/cci_PR-3997/4/0e5f69b2-1738-43a8-b543-392b72e13c3f/.conan/remotes.json
ERROR: Package recipe with name ut!=boost-ext-ut

@conan-center-bot
Copy link
Collaborator

Failure in build 5 (320bd594eaedc21f3892d7449de91c1d2a587fbb):

  • ut/1.1.8
    • 'conan export' command failed (ref 'ut/1.1.8'):

WARN: Remotes registry file missing, creating default one in /home/conan/w/cci_PR-3997/5/b4e5034e-bd09-4587-9088-d0674df858e2/.conan/remotes.json
ERROR: Package recipe with name ut!=boost-ext-ut

@conan-center-bot
Copy link
Collaborator

Failure in build 6 (19ecb9f12ea22c43b0832ed57a11e552c42f0d1b):

  • ut/1.1.8
    • 'conan export' command failed (ref 'ut/1.1.8'):

WARN: Remotes registry file missing, creating default one in /home/conan/w/cci_PR-3997/6/4e20c768-df52-4851-b093-b374422b0846/.conan/remotes.json
ERROR: Package recipe with name ut!=boost-ext-ut

@conan-center-bot
Copy link
Collaborator

Failure in build 7 (f538c8236074f1770cde5635960773b010d26f0e):

  • Error processing recipe (ref 'boost-ext-ut/1.1.8'): Linux x86_64, Release, gcc 4.9, libstdc++
    Unexpected error happened:
ERROR: boost-ext-ut/1.1.8: Error in configure() method, line 39
	raise ConanInvalidConfiguration("{} requires C++{} support. The current compiler {} {} does not support it.".format(
	NameError: name 'ConanInvalidConfiguration' is not defined

Previously, the minimum C++ standard was 20, but only 17 is required.
@conan-center-bot
Copy link
Collaborator

Failure in build 8 (c251685f9442cdd0b2ca481ca038bd4ce8e44818):

  • Error processing recipe (ref 'boost-ext-ut/1.1.8'): Linux x86_64, Release, gcc 4.9, libstdc++
    Unexpected error happened:
ERROR: boost-ext-ut/1.1.8: Error in configure() method, line 39
	raise ConanInvalidConfiguration("{} requires C++{} support. The current compiler {} {} does not support it.".format(
	NameError: name 'ConanInvalidConfiguration' is not defined

@conan-center-bot
Copy link
Collaborator

All green in build 9 (6e5ca512de1be37f1f42b4f8c33c1575f794cc36)! 😊

The behavior now models [Boost-ext].UT's current find_package behavior.
A CMake config file is provided with the name ut.
The library can be found with find_package(ut) as expected.
The CMake target, boost::ut, is also provided as expected.
I'm not sure how to remove the global target boost::boost.
I'd hate for this to conflict with the Boost library.
@conan-center-bot
Copy link
Collaborator

All green in build 11 (a71d8a51ac88e320f9334db8c3647e7f3b76a065)! 😊

Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇absolutely incredible work.

two tiny details and this will be ready for merging!

recipes/boost-ext-ut/all/conanfile.py Outdated Show resolved Hide resolved
recipes/boost-ext-ut/all/conanfile.py Outdated Show resolved Hide resolved
recipes/boost-ext-ut/all/conanfile.py Show resolved Hide resolved
The glob import was carried over from another header-only package.
Since it is not used here, it has been removed.
@conan-center-bot
Copy link
Collaborator

All green in build 12 (2fab1b92a01948ac26de7f35855c3550bef5246a)! 😊

The license was previously "Boost".
This commit switches the license to proper identifier for this license.
The short identifier for the Boost license is BSL-1.0.
This comes from the SPDX specification:
https://spdx.org/licenses/BSL-1.0.html
@conan-center-bot
Copy link
Collaborator

All green in build 13 (1b76ce4ec4e45596282b9cf6f1ced3bb9ea0ed4e)! 😊

@conan-center-bot conan-center-bot merged commit bcfa8a2 into conan-io:master Dec 29, 2020
@jwillikers jwillikers deleted the boost-ext-ut branch December 29, 2020 19:35
@claremacrae
Copy link
Contributor

This is brilliant news - thanks very much for implementing this @jwillikers !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants