Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[boost] debug_level=0 should emit -d0 #4121

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

garethsb
Copy link
Contributor

@garethsb garethsb commented Jan 6, 2021

Specify library name and version: boost/all

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@ghost
Copy link

ghost commented Jan 6, 2021

Comment on lines +607 to 608
if "debug_level" in self.options:
command += " -d%d" % self.options.debug_level
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on the docs I think this would be fine too https://boostorg.github.io/build/manual/develop/index.html#bbv2.overview.invocation.options

-d0
Suppress all informational messages.
-d N
Enable cumulative debugging levels from 1 to n. Values are: +

It's unclear if a space is required

Suggested change
if "debug_level" in self.options:
command += " -d%d" % self.options.debug_level
command += " -d%d" % self.options.get_safe("debug_level", 0)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @prince-chrismc.

For least surprise, should we default to the same value as b2 does itself, which I understand from that linked document to be level 1?

I'm pretty sure that the space is not required.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I picked the default for the recipe which was already accepted 🤷 we'll see what the CCI team and community say

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from my experience, space isn't required
using b2 default as recipe default matches the expectation for the most of users

@SSE4 SSE4 closed this Jan 24, 2021
@SSE4 SSE4 requested a review from uilianries January 24, 2021 04:09
@SSE4 SSE4 reopened this Jan 24, 2021
@SSE4 SSE4 closed this Jan 24, 2021
@SSE4 SSE4 reopened this Jan 24, 2021
@ghost ghost mentioned this pull request Jan 25, 2021
4 tasks
@SSE4 SSE4 closed this Feb 2, 2021
@SSE4 SSE4 reopened this Feb 2, 2021
@SSE4 SSE4 closed this Feb 2, 2021
@SSE4 SSE4 reopened this Feb 2, 2021
@conan-center-bot
Copy link
Collaborator

All green in build 4 (e309342a372587f2d466d3ddb9a68b4b160d00f9)! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants