-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[boost] debug_level=0 should emit -d0 #4121
Conversation
I detected other pull requests that are modifying boost/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
if "debug_level" in self.options: | ||
command += " -d%d" % self.options.debug_level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
based on the docs I think this would be fine too https://boostorg.github.io/build/manual/develop/index.html#bbv2.overview.invocation.options
-d0
Suppress all informational messages.
-d N
Enable cumulative debugging levels from 1 to n. Values are: +
It's unclear if a space is required
if "debug_level" in self.options: | |
command += " -d%d" % self.options.debug_level | |
command += " -d%d" % self.options.get_safe("debug_level", 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @prince-chrismc.
For least surprise, should we default to the same value as b2
does itself, which I understand from that linked document to be level 1
?
I'm pretty sure that the space is not required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I picked the default for the recipe which was already accepted 🤷 we'll see what the CCI team and community say
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from my experience, space isn't required
using b2 default as recipe default matches the expectation for the most of users
All green in build 4 (
|
Specify library name and version: boost/all
conan-center hook activated.