tesseract/4.1.1: libarchive dep and portable build #4278

theirix · 2021-01-16T12:13:16Z

Specify library name and version: tesseract/4.1.1

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

Changes:

Add dependency to libarchive
Made a build portable. No SSE autodetection and march=native. But end-user can use options to enable optimizations.
Modernized recipe
Moved out patches
Added components
Test with target
Preparing for 5.x

conan-center-bot · 2021-01-16T12:15:01Z

Failure in build 1 (12814708329c6a54de97a3c7c65861f0a7dc3897):

Error processing recipe (ref 'tesseract/4.1.1'): Linux x86_64, Release, gcc 4.9, libstdc++ . Options: tesseract:shared-False
Unexpected error happened:

ERROR: tesseract/4.1.1: Error in configure() method, line 69
	raise ConanInvalidConfiguration("%s requires a {} version >= {}" % (self.name, compiler, compiler_version))
	TypeError: not all arguments converted during string formatting

conan-center-bot · 2021-01-16T12:49:12Z

Some configurations of 'tesseract/4.1.1' failed in build 2 (392d195ca9c6b95847225802ba9ec950ff3e8575):

Windows x86_64, Debug, Visual Studio 16, MTd. Options: tesseract:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 14, MT. Options: tesseract:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 16, MT. Options: tesseract:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 16, MD. Options: tesseract:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MTd. Options: tesseract:shared-False
Access to all the logs

conan-center-bot · 2021-01-16T13:21:21Z

Some configurations of 'tesseract/4.1.1' failed in build 3 (c57ba0ce21c2f38a81147089400fde44f529e18c):

Windows x86_64, Release, Visual Studio 16, MD. Options: tesseract:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 16, MTd. Options: tesseract:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 14, MT. Options: tesseract:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 16, MT. Options: tesseract:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 14, MD. Options: tesseract:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 14, MTd. Options: tesseract:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MT. Options: tesseract:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MTd. Options: tesseract:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 14, MDd. Options: tesseract:shared-False
Access to all the logs

This reverts commit c57ba0c.

conan-center-bot · 2021-01-16T14:04:53Z

All green in build 4 (e63627e078792ee4103416eb0dd390b64d757272)! 😊

tesseract/4.1.1: Generated 116 packages. All logs here

recipes/tesseract/all/conanfile.py

prince-chrismc · 2021-01-16T15:02:13Z

recipes/tesseract/all/conanfile.py

+        # required for 5.0
+        tools.rmdir(os.path.join(self.package_folder, 'lib', 'cmake'))


there's no 5.0 🤔

I was experimenting in packaging 5.0.x-alpha. Of course, I can drop it now and add for the final version.

recipes/tesseract/all/conanfile.py

Co-authored-by: Chris Mc <[email protected]>

conan-center-bot · 2021-01-16T15:49:53Z

All green in build 5 (e6844ee7747b34cf85c0a5e9aa6e56e35bdeab23)! 😊

tesseract/4.1.1: Generated 116 packages. All logs here

conan-center-bot · 2021-01-16T16:27:22Z

All green in build 6 (ba82888459b25f35efc4a9fa34120d4cd2b012a8)! 😊

tesseract/4.1.1: Generated 116 packages. All logs here

dmn-star · 2021-01-16T16:37:32Z

I was just wondering why the tesseract lib can be compiled at all on CCI for macOS (CCI uses all apple-clang versions in C++03 mode 🤨). https://github.com/tesseract-ocr/tesseract/pull/643/files

It's really a matter of luck with which c++ standard the libs are built.

theirix · 2021-01-16T16:46:34Z

I was just wondering why the tesseract lib can be compiled at all on CCI for macOS (CCI uses all apple-clang versions in C++03 mode 🤨). https://github.com/tesseract-ocr/tesseract/pull/643/files

It's really a matter of luck with which c++ standard the libs are built.

tesseract uses a clever introspection for C++ 11/14/17 and uses the latest supported standard supported by a compiler. There is no minimum required standard anywhere. If a compiler has C++-XY features, they will be enabled via CMAKE_CXX_STANDARD

conan-center-bot · 2021-01-16T17:09:58Z

All green in build 7 (7460bc5612958c925025deb3dcf96a23247dc96d)! 😊

tesseract/4.1.1: Generated 116 packages. All logs here

theirix added 10 commits January 16, 2021 12:28

Move out patching from recipe

2d43d3f

Reformat recipe

210b2bd

Refactor compiler version check

1b410d5

Drop fPIC on shared

3c49b6c

Bump leptonica dep, add libarchive dep

ee0621a

Drop cmake dirs for 5.x

22ad404

Add options for portable build

a24c3eb

Drop tweak for omitting libarchive

1a5ec09

Use 3.1 cmake version

543a680

Link with target in test_package

1281470

conan-center-bot added the Failed label Jan 16, 2021

Fix error message

392d195

Omit version from library name on Windows

c57ba0c

theirix added 2 commits January 16, 2021 16:31

Revert "Omit version from library name on Windows"

881e4ee

This reverts commit c57ba0c.

Autodetect versioned library name

e63627e

conan-center-bot removed the Failed label Jan 16, 2021

github-actions bot mentioned this pull request Jan 16, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

prince-chrismc reviewed Jan 16, 2021

View reviewed changes

recipes/tesseract/all/conanfile.py Show resolved Hide resolved

prince-chrismc reviewed Jan 16, 2021

View reviewed changes

recipes/tesseract/all/conanfile.py Outdated Show resolved Hide resolved

prince-chrismc reviewed Jan 16, 2021

View reviewed changes

recipes/tesseract/all/conanfile.py Outdated Show resolved Hide resolved

Link ws2_32 on shared

e6844ee

Co-authored-by: Chris Mc <[email protected]>

Warn about unknown compilers

ba82888

Move options checks to configure

7460bc5

prince-chrismc approved these changes Jan 16, 2021

View reviewed changes

SSE4 requested a review from uilianries January 17, 2021 04:52

uilianries approved these changes Jan 18, 2021

View reviewed changes

SSE4 approved these changes Jan 19, 2021

View reviewed changes

conan-center-bot merged commit 75a3b6c into conan-io:master Jan 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tesseract/4.1.1: libarchive dep and portable build #4278

tesseract/4.1.1: libarchive dep and portable build #4278

theirix commented Jan 16, 2021

conan-center-bot commented Jan 16, 2021

conan-center-bot commented Jan 16, 2021

conan-center-bot commented Jan 16, 2021

conan-center-bot commented Jan 16, 2021

prince-chrismc Jan 16, 2021

theirix Jan 16, 2021

conan-center-bot commented Jan 16, 2021

conan-center-bot commented Jan 16, 2021

dmn-star commented Jan 16, 2021 •

edited

Loading

theirix commented Jan 16, 2021

conan-center-bot commented Jan 16, 2021

		# required for 5.0
		tools.rmdir(os.path.join(self.package_folder, 'lib', 'cmake'))

tesseract/4.1.1: libarchive dep and portable build #4278

tesseract/4.1.1: libarchive dep and portable build #4278

Conversation

theirix commented Jan 16, 2021

conan-center-bot commented Jan 16, 2021

conan-center-bot commented Jan 16, 2021

conan-center-bot commented Jan 16, 2021

conan-center-bot commented Jan 16, 2021

prince-chrismc Jan 16, 2021

Choose a reason for hiding this comment

theirix Jan 16, 2021

Choose a reason for hiding this comment

conan-center-bot commented Jan 16, 2021

conan-center-bot commented Jan 16, 2021

dmn-star commented Jan 16, 2021 • edited Loading

theirix commented Jan 16, 2021

conan-center-bot commented Jan 16, 2021

dmn-star commented Jan 16, 2021 •

edited

Loading