gn: add initial gn recipe #5433

madebr · 2021-05-05T00:45:05Z

Specify library name and version: gn/cci.20210429

gn is a build system developed by google, used for google produces (chromium)

I've tested this on Linux (gcc + clang) and Windows.
~~TODO's: Windows + Macos~~

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

recipes/gn/all/conanfile.py

ericriff · 2021-05-05T01:37:37Z

recipes/gn/all/conandata.yml

@@ -0,0 +1,3 @@
+sources:
+  "cci.20210429":
+    url: "https://gn.googlesource.com/gn/+archive/6771ce569fb4803dad7a427aa2e2c23e960b917e.tar.gz"


Why no sha256?

It changes all the time.
Some time stamp is probably spoiling the fun.

yep, their servers produce tarballs on fly, and sha256 is always different, it's pain to package. if someone can help how to get stable tarball URL for gn, help is welcome.

I'm wondering if we could mirror this repo on github and have it sync itself automatically using actions.

Something like this actions/checkout#24
But it looks like it only works to sync repos on the same domain.

It's completely possible.
But somebody/organization should invest some time setting it up...

ericriff · 2021-05-05T01:41:20Z

recipes/gn/all/conanfile.py

+        self.copy("gn.exe", src=os.path.join(self._source_subfolder, "out"), dst="bin")
+
+    def package_info(self):
+        bin_path = os.path.join(self.package_folder, "bin")


Are these lines really necessary? It is my understanding that conan exposes self.cpp_info.binpath to PATH automatically when a package is listed as a build requirement.

It's not needed when doing crossbuilds (-pr:h hostprofile -pr:b buildprofile).
But when using the single profile approach (when your profile contains os_build or arch_build, I think the PATH environment variable is not automatically set.

ericriff · 2021-05-06T01:29:06Z

recipes/gn/all/conanfile.py

+        if self.settings.compiler.cppstd:
+            tools.check_min_cppstd(self, 17)
+        else:
+            if self._minimum_compiler_version_supporting_cxx17:


I've seen this pattern over and over, I'm wondering if this should be a conan built in tool.
It would remove boilerplate code and eliminate the need from the recipe creator of knowing which c++ std supports each compiler.

Some util functions would be nice.
But looking at the support matrix at https://en.cppreference.com/w/cpp/compiler_support,
the minimum required compiler version depends on what c++ features a project desires..

-> conan-io/conan#8002

Thanks. One day... 😄

The C++ standard is not enough since the STL support changes between some minor versions it's a manual process for many projects

ericriff · 2021-05-06T02:14:02Z

I'm testing this locally to see how it behaves with the crashpad recipe.
I decided to crosscompile it just for the sake of testing and for my aarch64 platform it fails during linking with:

[208/281] LINK gn
FAILED: gn 
aarch64-oe-linux-g++ --sysroot=/home/eric/.conan/data/SDKdev/1.0/eric/stable/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/sysroots/aarch64-oe-linux -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed --sysroot=home/eric/.conan/data/SDKdev/1.0/eric/stable/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/sysroots/aarch64-oe-linux -O3 -fdata-sections -ffunction-sections -Wl,--gc-sections -Wl,-strip-all -Wl,--as-needed -static-libstdc++ -pthread -o gn -Wl,--start-group src/gn/gn_main.o base.a gn_lib.a -Wl,--end-group -ldl
home/eric/.conan/data/SDKdev/1.0/eric/stable/package/5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9/sysroots/x86_64-oesdk-linux/usr/libexec/aarch64-oe-linux/gcc/aarch64-oe-linux/8.2.0/real-ld: cannot find -lstdc++
collect2: error: ld returned 1 exit status

Looking into my sysroots it looks like I only have the shared version of libstdc++:

find -name \*stdc\*
./usr/lib/libstdc++.so.6.0.25-gdb.py
./usr/lib/libstdc++.so.6.0.25
./usr/lib/libstdc++.so.6
./usr/lib/libstdc++.so
./usr/lib/.debug/libstdc++.so.6.0.25
./usr/include/curl/stdcheaders.h
./usr/include/c++/8.2.0/aarch64-oe-linux/bits/stdc++.h
./usr/include/readline/rlstdc.h
./usr/include/stdc-predef.h

There is a --no-static-libstdc++ option for gen.py that makes it link correctly. I'm wondering if we should add it as a conan option.

madebr · 2021-05-06T11:14:54Z

There is a --no-static-libstdc++ option for gen.py that makes it link correctly. I'm wondering if we should add it as a conan option.

On my Fedora Linux box, the static library is provided by libstdc++-static.
Probably, there exists a similar package for your arm system.

Linking to the static library makes the executable more robust/workable on more machines.
gn consists of a single executable, so we don't care about other libraries/executables linking to it.

When using the shared libstdc++, then we cannot remove self.info.settings.compiler in package_id.
For gcc/clang, the version of the standard library depends on the compiler version. (cfr the latest c++ weekly video about breaking ABI)

recipes/gn/all/conanfile.py

madebr · 2021-05-07T14:55:01Z

@SpaceIm
Can I get an initial review please?

SpaceIm · 2021-05-09T20:48:07Z

recipes/gn/all/conanfile.py

+                ]
+                if self.settings.build_type == "Debug":
+                    conf_args.append("-d")
+                self.run("python build/gen.py {}".format(" ".join(conf_args)), run_environment=True)


Would it require cpython in build requirement when packaged? Maybe add a TODO?

Yes, I'll add a todo.

recipes/gn/all/conanfile.py

prince-chrismc · 2021-05-08T15:46:31Z

recipes/gn/all/conanfile.py

+    def build(self):
+        with tools.chdir(self._source_subfolder):
+            with self._build_context():
+                tools.save(os.path.join("src", "gn", "last_commit_position.h"),


Can you add a comment about what this is for?

prince-chrismc · 2021-05-08T15:49:30Z

recipes/gn/all/test_package/conanfile.py

+        self.build_requires("ninja/1.10.2")
+
+    @contextmanager
+    def _build_context(self):


Could this not be re-used some how, I hate duplication like this

These environment variables are closely coupled with the .gn sources in the test package.
This is my first encounter with gn, so I don't really know a better way to let the build system know of another compiler.

recipes/gn/all/conanfile.py

conan-center-bot · 2021-05-09T22:44:24Z

All green in build 12 (f0988c29e2e8127af3e631eaad85e13946463f23):

gn/cci.20210429@:
All packages built successfully! (All logs)

gn: add initial gn recipe

831003f

madebr mentioned this pull request May 5, 2021

Add crashpad [Draft] [Help Needed] #5419

Closed

4 tasks

madebr marked this pull request as draft May 5, 2021 00:46

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label May 5, 2021

This comment has been minimized.

Sign in to view

madebr force-pushed the gn_recipe branch from 4352eaf to 3eae52d Compare May 5, 2021 00:59

This comment has been minimized.

Sign in to view

gn: requires a c++17 capable compiler

07411a6

madebr force-pushed the gn_recipe branch from 3eae52d to 07411a6 Compare May 5, 2021 01:07

This comment has been minimized.

Sign in to view

ericriff reviewed May 5, 2021

View reviewed changes

madebr added 2 commits May 5, 2021 23:41

gn: fix topics

b341e5e

ng: try sleep between config and build to avoid time skew

e5e5f59

This comment has been minimized.

Sign in to view

madebr added 2 commits May 6, 2021 01:55

gn: add MSVC support to test_package

14bbf05

gn: remove prints

e8b5e78

This comment has been minimized.

Sign in to view

madebr added 2 commits May 6, 2021 02:30

gn: print build/host/target info + pass win for Windows

b502038

gn: pass os=mac for apple

9a38b25

This comment has been minimized.

Sign in to view

conan-center-bot removed the Failed label May 6, 2021

ericriff previously approved these changes May 6, 2021

View reviewed changes

SSE4 requested a review from uilianries May 6, 2021 08:00

gn: toolchain reformat + .obj msvc object extension

9af7ada

madebr dismissed ericriff’s stale review via 9af7ada May 6, 2021 11:38

This comment has been minimized.

Sign in to view

madebr marked this pull request as ready for review May 6, 2021 13:54

madebr commented May 6, 2021

View reviewed changes

recipes/gn/all/conanfile.py Outdated Show resolved Hide resolved

gn: fix license

bf76d8d

This comment has been minimized.

Sign in to view

SpaceIm reviewed May 9, 2021

View reviewed changes

madebr commented May 9, 2021

View reviewed changes

recipes/gn/all/conanfile.py Show resolved Hide resolved

gn: add FIXME for adding cpython build requirement

abe0ec1

prince-chrismc reviewed May 9, 2021

View reviewed changes

madebr commented May 9, 2021

View reviewed changes

recipes/gn/all/conanfile.py Show resolved Hide resolved

This comment has been minimized.

Sign in to view

gn: add comment about header creation

f0988c2

prince-chrismc approved these changes May 10, 2021

View reviewed changes

github-actions bot mentioned this pull request May 10, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

SpaceIm approved these changes May 10, 2021

View reviewed changes

uilianries approved these changes May 10, 2021

View reviewed changes

conan-center-bot merged commit b5a9d42 into conan-io:master May 10, 2021

madebr deleted the gn_recipe branch May 10, 2021 20:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gn: add initial gn recipe #5433

gn: add initial gn recipe #5433

madebr commented May 5, 2021 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ericriff May 5, 2021

madebr May 5, 2021

SSE4 May 6, 2021

ericriff May 6, 2021

ericriff May 6, 2021

madebr May 6, 2021

ericriff May 5, 2021

madebr May 5, 2021 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ericriff May 6, 2021

madebr May 6, 2021

Croydon May 7, 2021

madebr May 7, 2021

prince-chrismc May 8, 2021

ericriff commented May 6, 2021

madebr commented May 6, 2021

This comment has been minimized.

madebr commented May 7, 2021

This comment has been minimized.

This comment has been minimized.

SpaceIm May 9, 2021

madebr May 9, 2021

prince-chrismc May 8, 2021

prince-chrismc May 8, 2021

madebr May 9, 2021

This comment has been minimized.

conan-center-bot commented May 9, 2021

gn: add initial gn recipe #5433

gn: add initial gn recipe #5433

Conversation

madebr commented May 5, 2021 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

madebr May 5, 2021 • edited Loading

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ericriff commented May 6, 2021

madebr commented May 6, 2021

This comment has been minimized.

madebr commented May 7, 2021

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

conan-center-bot commented May 9, 2021

madebr commented May 5, 2021 •

edited

Loading

madebr May 5, 2021 •

edited

Loading