Add tinyobjloader recipe

[flostellbrink]

Specify library name and version: tinyobjloader/1.0.6, tinyobjloader/2.0-rc1

• I've read the guidelines for contributing.
• I've followed the PEP8 style guides for Python code in the recipes.
• I've used the latest Conan client version.
• I've tried at least one configuration locally with the
  conan-center hook activated.

[CLAassistant]

All committers have signed the CLA.

[uilianries]

I see no difference between 1.x and 2.x maybe we can re-use the same recipe for both.

[flostellbrink]

The only difference between 1.x and 2.x is the API, so the test case is different.
Is there a way to deduplicate the rest of the code?

[uilianries]

I need to check if we can customize the test_package name. Let me see it.

[uilianries]

unfortunately we don't have such feature, but we can re-use the same test_package folder for both tests. Using cmake features we can detect the package reference and build the correct test. Lemme check some good approach.

[uilianries]

BTW the CI is under maintenance right now, that's why we don't have CI status on this PR.

[flostellbrink]

Good to know

[conan-center-bot]

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

[flostellbrink]

@uilianries Any idea why the bot won't build the pull request?
I kind of thought that your thumbs up on my request (#4 (comment)_) was a confirmation that I got in.

[uilianries]

@flostellbrink unfortunately I have no power to add users in beta group. We need to wait for admin, which will be done soon.

[flostellbrink]

Ahh okay, thanks for all the help!

[conan-center-bot]

The config.yml file is invalid: Only one library can be changed in the same PR: [tinyobjloader/1.x, tinyobjloader/2.x]

[danimtb]

Please @flostellbrink, include just one library version per PR. This reduces a lot the build service time and pipeline and helps with the revision of the new files 😄

[uilianries]

@danimtb I think we can use both versions with same recipe, I'm checking some way to do it.

[flostellbrink]

@danimtb I failed at combining the test cases.
I think it might be useful to pass the version to the test case conanfile.
Another nice approach would be something like the config.yml to map versions to test cases.

@uilianries Please keep me updated. I'd be perfectly happy with splitting this into two pull requests if combining them doesn't work out :)

[uilianries]

@flostellbrink take a look: https://github.com/flostellbrink/conan-center-index/pull/1

[flostellbrink]

That's clever!

[conan-center-bot]

tinyobjloader/1.0.6@:

'conan export' command failed:

ERROR: Conanfile not found at /tmp/c3ipr/info_pr_58_3/conanfile.py

[conan-center-bot]

Some configurations of 'tinyobjloader/1.0.6' have failed:

• Linux x86_64, Release, gcc 5, libstdc++ . Options: tinyobjloader:shared:True
  • Hooks errors detected:
    • [HOOK - conan-center.py] post_package(): ERROR: [SHARED ARTIFACTS (KB-H015)] Package with 'shared' option did not contains any shared artifact (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H015)
  • Log download
  • Log error Download
  • Profile
• Access to all the logs

[flostellbrink]

Huh, I thought that was a windows only issue.
Gonna look into it later.

[uilianries]

@flostellbrink you need to add the follow statement:

cmake.definitions["TINYOBJLOADER_COMPILATION_SHARED"] = self.options.shared

[flostellbrink]

Well that was painfully obvious in hindsight. Thanks a lot @uilianries !

[conan-center-bot]

Some configurations of 'tinyobjloader/1.0.6' have failed:

• Windows x86_64, Release, Visual Studio 15, MD. Options: tinyobjloader:shared:True
  • Log download
  • Log error Download
  • Profile
• Access to all the logs
• Windows x86_64, Debug, Visual Studio 15, MDd. Options: tinyobjloader:shared:True
  • Log download
  • Log error Download
  • Profile
• Access to all the logs

[conan-center-bot]

An unexpected error happened and has been reported. Help is on its way! 🏇

[uilianries]

Seems like Jenkins is in trouble. I gonna restart the CI job by closing/opening your PR.

[conan-center-bot]

All green! 😊

• tinyobjloader/1.0.6: Generated 2 packages. All logs here
• tinyobjloader/2.0-rc1: Generated 105 packages. All logs here

[Croydon]

I'm wondering if having pre-releases is a desirable goal for the CCI? 🤔

[uilianries]

I'm wondering if having pre-releases is a desirable goal for the CCI? thinking

Good question. Some time ago we agreed in accept only stable versions. WDYT @lasote @danimtb ?

[danimtb]

I'd say it is not the goal for this repository to have release candidates... But we need to agree on the conditions and post them as guidelines for new contributions

[flostellbrink]

There are some in between versions too. 1.0.7 and 1.4.1, but they are not marked as latest release on GitHub and have a partially changed API.

So I was hesitant to include them.

I'll remove the pre-release and we can wait for a proper release.

[conan-center-bot]

All green! 😊

• tinyobjloader/1.0.6: Generated 122 packages. All logs here