-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meson: remove outdated versions #5815
Conversation
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying meson/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks. I agree with this PR. I'm not approving right away because I want other reviewers to have a look at it and we would like to hear anyone that has something to say about it.
Recipes and packages for the removed versions will always be available in ConanCenter. Using or not revisions, a consumer will always be able to consume meson/0.51.0
, the server will resolve to the latest revision of that recipe.
I agree too. |
I would find it much more appealing when the version information would stay in the I understand that these versions would not be tested anymore, but honestly, there are tons of configurations we never test and which can still be built without any modification. Maybe we need a way to dynamically add/"trigger" the Or again something like #2813 |
Until a solution is found for #2813, maybe we could simply comment out lines in .yml files, instead of removing them, so at least the information is not lost in git history |
I agree, it's better to implement something like:
and if CI reads |
I feel like this information would be better placed in config.yml. conandata.yml is used during the build itself, so it seems conceptually to late to abort the build. Also, conandata.yml ends up in the local cache of consumers, so it'd better be free of CCI specificities. |
If we want to keep that information easily accessible to the future, IMHO I would prefer to comment out those lines. At least the user will get an error, will have a look to |
yes, definetely, |
0bb9b0c
All green in build 2 (
|
as per #2813 (comment)
Specify library name and version: meson/*
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
conan-center hook activated.