add the marked-up object compiler, moc, package to conan center #5832

zuut · 2021-06-09T14:22:26Z

Specify library name and version: moc/0.9.3

Moc, for marked-up object compiler, is an IDL-like code generator developed in the early 1990s and is used to generate code, sql and other text files from annotated data model. see: https://github.com/zuut/moc

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

recipes/moc/all/conandata.yml

recipes/moc/all/.gitignore

recipes/moc/all/conanfile.py

recipes/moc/all/check_recipe.sh

recipes/moc/all/conanfile.py

recipes/moc/all/test_package/conanfile.py

recipes/moc/all/conanfile.py

Co-authored-by: SpaceIm <[email protected]>

SpaceIm · 2021-06-09T19:22:33Z

Now you need to properly set cpp_info.names in package_info()

zuut · 2021-06-09T19:40:11Z

Failure in build 6 (dc45d53bfdfe70247127faccdc0eaea7ef1eacc8):

* **moc/0.9.401@:**
  CI failed to create some packages ([All logs](https://c3i.jfrog.io/c3i/misc/summary.html?json=https://c3i.jfrog.io/c3i/misc/logs/pr/5832/6/moc/0.9.401//summary.json))
  Logs for packageID `66743291b51336759c453bb6d0a93c24731a4cd0`:
  ```
  [settings]
  arch=x86_64
  arch_build=x86_64
  build_type=Debug
  compiler=apple-clang
  compiler.libcxx=libc++
  compiler.version=10.0
  os=Macos
  os_build=Macos
  ```
  
  
      
        
      
  
        
      
  
      
    
  ```
  [...]
  ----Running------
  > cmake --build '/Users/jenkins/w/BuildSingleReference@6/conan-center-index/recipes/moc/all/test_package/build/d5dd16198951de31b02637187662ccfc77c7f43e' '--' '-j4'
  -----------------
  [ 33%] /Users/jenkins/w/BuildSingleReference@6/conan-center-index/recipes/moc/all/test_package
  CMake Warning at CMakeLists.txt:8 (find_package):
    By not providing "FindMoc.cmake" in CMAKE_MODULE_PATH this project has
    asked CMake to find a package configuration file provided by "Moc", but
    CMake did not find one.
  
    Could not find a package configuration file provided by "Moc" with any of
    the following names:
  
      MocConfig.cmake
      moc-config.cmake
  
    Add the installation prefix of "Moc" to CMAKE_PREFIX_PATH or set "Moc_DIR"
    to a directory containing one of the above files.  If "Moc" provides a
    separate development package or SDK, be sure it has been installed.
  
  
  CONAN_MOC_ROOT: /Users/jenkins/w/BuildSingleReference@6/.conan/data/moc/0.9.401/_/_/package/66743291b51336759c453bb6d0a93c24731a4cd0
  MOC_TOOL: /Users/jenkins/w/BuildSingleReference@6/.conan/data/moc/0.9.401/_/_/package/66743291b51336759c453bb6d0a93c24731a4cd0/bin/moc
  CMake Warning:
    Manually-specified variables were not used by the project:
  
      CMAKE_EXPORT_NO_PACKAGE_REGISTRY
      CMAKE_INSTALL_BINDIR
      CMAKE_INSTALL_DATAROOTDIR
      CMAKE_INSTALL_INCLUDEDIR
      CMAKE_INSTALL_LIBDIR
      CMAKE_INSTALL_LIBEXECDIR
      CMAKE_INSTALL_OLDINCLUDEDIR
      CMAKE_INSTALL_SBINDIR
      MOC_ROOT
  
  
  /Users/jenkins/w/BuildSingleReference@6/conan-center-index/recipes/moc/all/test_package/test_app.moc:4: Error in /Users/jenkins/w/BuildSingleReference@6/.conan/data/moc/0.9.401/_/_/package/66743291b51336759c453bb6d0a93c24731a4cd0/bin/moc input: processing input Class("Address")
  /Users/jenkins/w/BuildSingleReference@6/conan-center-index/recipes/moc/all/test_package/test_app.tpl:79: ERROR: Expected variable of the form @(name) in input '6/conan-center-index/recipes/moc/all/test_package/build/d5dd16198951de31b02637187662ccfc77c7f43e/genSrc/include/bizobj/address/Address.h'
  /Users/jenkins/w/BuildSingleReference@6/conan-center-index/recipes/moc/all/test_package/test_app.moc:4: Error in /Users/jenkins/w/BuildSingleReference@6/.conan/data/moc/0.9.401/_/_/package/66743291b51336759c453bb6d0a93c24731a4cd0/bin/moc input: processing input Class("Address")
  /Users/jenkins/w/BuildSingleReference@6/conan-center-index/recipes/moc/all/test_package/test_app.tpl:149: ERROR: Expected variable of the form @(name) in input '6/conan-center-index/recipes/moc/all/test_package/build/d5dd16198951de31b02637187662ccfc77c7f43e/genSrc/src/bizobj/address/Address.cpp'
  /Users/jenkins/w/BuildSingleReference@6/conan-center-index/recipes/moc/all/test_package/test_app.moc:4: Error in /Users/jenkins/w/BuildSingleReference@6/.conan/data/moc/0.9.401/_/_/package/66743291b51336759c453bb6d0a93c24731a4cd0/bin/moc input: processing input Class("Address")
  /Users/jenkins/w/BuildSingleReference@6/conan-center-index/recipes/moc/all/test_package/test_app.tpl:176: ERROR: Expected variable of the form @(name) in input '6/conan-center-index/recipes/moc/all/test_package/build/d5dd16198951de31b02637187662ccfc77c7f43e/genSrc/src/bizobj/address/Address.ddl.sample'
  /Users/jenkins/w/BuildSingleReference@6/.conan/data/moc/0.9.401/_/_/package/66743291b51336759c453bb6d0a93c24731a4cd0/bin/moc detected 3 errors during output generation
  make[2]: *** [genSrc/test_app.sequence] Error 15
  make[1]: *** [CMakeFiles/test_package.dir/all] Error 2
  make: *** [all] Error 2
  m4/1.4.18: WARN: Lib folder doesn't exist, can't collect libraries: /Users/jenkins/w/BuildSingleReference@6/.conan/data/m4/1.4.18/_/_/package/907cb07dbeb8f7bacd51a5119560f14986d21b20/lib
  ERROR: moc/0.9.401 (test package): Error in build() method, line 37
  	cmake.build()
  	ConanException: Error 2 while executing cmake --build '/Users/jenkins/w/BuildSingleReference@6/conan-center-index/recipes/moc/all/test_package/build/d5dd16198951de31b02637187662ccfc77c7f43e' '--' '-j4'
  ```

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Now you need to properly set cpp_info.names in package_info()
@SpaceIm - can you tell me what is incorrect?

…e the issue

…ndex into add-moc-package

recipes/moc/all/conanfile.py

Co-authored-by: Yoann Potinet <[email protected]>

recipes/moc/all/conanfile.py

recipes/moc/all/test_package/test_app.tpl

recipes/moc/all/conanfile.py

ghost · 2021-06-13T18:43:44Z

I detected other pull requests that are modifying moc/all recipe:

debug macos errors #5874

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

Co-authored-by: Chris Mc <[email protected]>

recipes/moc/all/conanfile.py

…p.tpl

prince-chrismc

Required comments:

https://github.com/conan-io/conan-center-index/pull/5832/files#r648796555
https://github.com/conan-io/conan-center-index/pull/5832/files#r650434016
https://github.com/conan-io/conan-center-index/pull/5832/files#r648796124

recipes/moc/all/conanfile.py

SpaceIm · 2021-06-17T15:57:53Z

recipes/moc/all/test_package/main.cpp

+typedef char* String;
+typedef int integer;
+typedef long Long;
+
+#include "bizobj/address/Address.h"
+
+int main(int argc, char **argv) {
+    Address address;
+}


Does it test link to uf library? It's the only one I see under lib/uf folder. Since this folder was not added to of cpp_info.libdirs, I'm wondering if cpp_info.libs is not empty...

Why upstream CMakeLists install this library in this subfolder instead of lib folder directly?

SpaceIm · 2021-06-17T15:58:56Z

recipes/moc/all/conanfile.py

+        self.cpp_info.builddirs.append(join("lib", "moc"))
+        self.cpp_info.builddirs.append(join("lib", "uf"))


Suggested change

self.cpp_info.builddirs.append(join("lib", "moc"))

self.cpp_info.builddirs.append(join("lib", "uf"))

Those folders contain CMake target files, they shouldn't be packaged

SpaceIm · 2021-06-17T16:00:30Z

recipes/moc/all/conanfile.py

+    def package(self):
+        cmake = self._configure_cmake()
+        cmake.install()
+        tools.remove_files_by_mask(join(self.package_folder, "lib"), "*-config.cmake")


Suggested change

tools.remove_files_by_mask(join(self.package_folder, "lib"), "*-config.cmake")

tools.rmdir(join(self.package_folder, "lib", "moc"))

tools.remove_files_by_mask(join(self.package_folder, "lib", "uf"), "*.cmake")

From what I see in installation layout:

-- Install configuration: "Debug" -- Installing: /home/conan/w/BuildSingleReference/.conan/data/moc/0.9.401/_/_/package/5ab7aa3bc61b93e1b46714a0ee54d9a856dbe3b6/bin/moc -- Installing: /home/conan/w/BuildSingleReference/.conan/data/moc/0.9.401/_/_/package/5ab7aa3bc61b93e1b46714a0ee54d9a856dbe3b6/lib/moc/moc-targets.cmake -- Installing: /home/conan/w/BuildSingleReference/.conan/data/moc/0.9.401/_/_/package/5ab7aa3bc61b93e1b46714a0ee54d9a856dbe3b6/lib/moc/moc-targets-debug.cmake -- Installing: /home/conan/w/BuildSingleReference/.conan/data/moc/0.9.401/_/_/package/5ab7aa3bc61b93e1b46714a0ee54d9a856dbe3b6/lib/moc/moc-config.cmake -- Installing: /home/conan/w/BuildSingleReference/.conan/data/moc/0.9.401/_/_/package/5ab7aa3bc61b93e1b46714a0ee54d9a856dbe3b6/lib/cmake/Moc.cmake -- Installing: /home/conan/w/BuildSingleReference/.conan/data/moc/0.9.401/_/_/package/5ab7aa3bc61b93e1b46714a0ee54d9a856dbe3b6/lib/cmake/BisonFlex.cmake -- Installing: /home/conan/w/BuildSingleReference/.conan/data/moc/0.9.401/_/_/package/5ab7aa3bc61b93e1b46714a0ee54d9a856dbe3b6/lib/uf/libuf.a -- Installing: /home/conan/w/BuildSingleReference/.conan/data/moc/0.9.401/_/_/package/5ab7aa3bc61b93e1b46714a0ee54d9a856dbe3b6/lib/uf/uf-targets.cmake -- Installing: /home/conan/w/BuildSingleReference/.conan/data/moc/0.9.401/_/_/package/5ab7aa3bc61b93e1b46714a0ee54d9a856dbe3b6/lib/uf/uf-targets-debug.cmake -- Installing: /home/conan/w/BuildSingleReference/.conan/data/moc/0.9.401/_/_/package/5ab7aa3bc61b93e1b46714a0ee54d9a856dbe3b6/include/generic.h -- Installing: /home/conan/w/BuildSingleReference/.conan/data/moc/0.9.401/_/_/package/5ab7aa3bc61b93e1b46714a0ee54d9a856dbe3b6/include/ufAll.h -- Installing: /home/conan/w/BuildSingleReference/.conan/data/moc/0.9.401/_/_/package/5ab7aa3bc61b93e1b46714a0ee54d9a856dbe3b6/include/ufDate.h -- Installing: /home/conan/w/BuildSingleReference/.conan/data/moc/0.9.401/_/_/package/5ab7aa3bc61b93e1b46714a0ee54d9a856dbe3b6/include/ufDef.h -- Installing: /home/conan/w/BuildSingleReference/.conan/data/moc/0.9.401/_/_/package/5ab7aa3bc61b93e1b46714a0ee54d9a856dbe3b6/include/ufFileNm.h -- Installing: /home/conan/w/BuildSingleReference/.conan/data/moc/0.9.401/_/_/package/5ab7aa3bc61b93e1b46714a0ee54d9a856dbe3b6/include/ufIHshT.h -- Installing: /home/conan/w/BuildSingleReference/.conan/data/moc/0.9.401/_/_/package/5ab7aa3bc61b93e1b46714a0ee54d9a856dbe3b6/include/ufList.h -- Installing: /home/conan/w/BuildSingleReference/.conan/data/moc/0.9.401/_/_/package/5ab7aa3bc61b93e1b46714a0ee54d9a856dbe3b6/include/ufPtr.h -- Installing: /home/conan/w/BuildSingleReference/.conan/data/moc/0.9.401/_/_/package/5ab7aa3bc61b93e1b46714a0ee54d9a856dbe3b6/include/ufSHshT.h -- Installing: /home/conan/w/BuildSingleReference/.conan/data/moc/0.9.401/_/_/package/5ab7aa3bc61b93e1b46714a0ee54d9a856dbe3b6/include/ufString.h

conan-center-bot · 2021-06-28T18:31:41Z

All green in build 20 (350e450285702466ea9028d65f886fe34af6b78f):

moc/0.9.401@:
All packages built successfully! (All logs)

stale · 2021-07-28T20:37:32Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2021-08-27T21:10:21Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

add moc package to conan center

7867567

This comment has been minimized.

Sign in to view

github-actions bot mentioned this pull request Jun 9, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

intelligide suggested changes Jun 9, 2021

View reviewed changes

respond to comments

567a96c

This comment has been minimized.

Sign in to view

respond to more comments

2aff6f3

SpaceIm reviewed Jun 9, 2021

View reviewed changes

recipes/moc/all/conanfile.py Outdated Show resolved Hide resolved

SpaceIm reviewed Jun 9, 2021

View reviewed changes

recipes/moc/all/conanfile.py Outdated Show resolved Hide resolved

SpaceIm reviewed Jun 9, 2021

View reviewed changes

recipes/moc/all/test_package/conanfile.py Outdated Show resolved Hide resolved

SpaceIm reviewed Jun 9, 2021

View reviewed changes

recipes/moc/all/conanfile.py Outdated Show resolved Hide resolved

SpaceIm reviewed Jun 9, 2021

View reviewed changes

recipes/moc/all/conanfile.py Outdated Show resolved Hide resolved

SpaceIm reviewed Jun 9, 2021

View reviewed changes

recipes/moc/all/conanfile.py Outdated Show resolved Hide resolved

SpaceIm reviewed Jun 9, 2021

View reviewed changes

recipes/moc/all/conanfile.py Show resolved Hide resolved

SpaceIm reviewed Jun 9, 2021

View reviewed changes

recipes/moc/all/conanfile.py Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

zuut added 2 commits June 9, 2021 11:22

respond to more comments

7b91d2a

respond to more comments

3baf2ec

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Jun 9, 2021

SpaceIm reviewed Jun 9, 2021

View reviewed changes

recipes/moc/all/conanfile.py Outdated Show resolved Hide resolved

Update recipes/moc/all/conanfile.py

dc45d53

Co-authored-by: SpaceIm <[email protected]>

This comment has been minimized.

Sign in to view

zuut added 3 commits June 9, 2021 12:43

removing macos apple-clang as I am uncertain how to fix it or recreat…

4f6966e

…e the issue

Merge branch 'add-moc-package' of github-zuut.com:zuut/conan-center-i…

265ab70

…ndex into add-moc-package

specify name in build_modules

7e5e9a4

This comment has been minimized.

Sign in to view

conan-center-bot removed the Failed label Jun 9, 2021

intelligide reviewed Jun 10, 2021

View reviewed changes

conan-center-bot requested a review from SSE4 June 10, 2021 11:57

Update recipes/moc/all/conanfile.py

30a4a98

Co-authored-by: Yoann Potinet <[email protected]>

This comment has been minimized.

Sign in to view

prince-chrismc suggested changes Jun 12, 2021

View reviewed changes

This was referenced Jun 13, 2021

[service] Potentially conflicting recipes #3571

Closed

debug macos errors #5874

Closed

zuut and others added 2 commits June 13, 2021 19:05

print warning about missing /usr/lib/cpp

7aaff90

Update recipes/moc/all/conanfile.py

cdfd621

Co-authored-by: Chris Mc <[email protected]>

This comment has been minimized.

Sign in to view

remove unused import. add mac back to list

04370c7

This comment has been minimized.

Sign in to view

prince-chrismc reviewed Jun 14, 2021

View reviewed changes

recipes/moc/all/conanfile.py Outdated Show resolved Hide resolved

move compiler checks in configure to validate. Reduce size of test_ap…

350e450

…p.tpl

This comment has been minimized.

Sign in to view

conan-center-bot requested a review from memsharded June 15, 2021 11:58

prince-chrismc suggested changes Jun 17, 2021

View reviewed changes

recipes/moc/all/conanfile.py Show resolved Hide resolved

recipes/moc/all/conanfile.py Show resolved Hide resolved

recipes/moc/all/conanfile.py Show resolved Hide resolved

SpaceIm reviewed Jun 17, 2021

View reviewed changes

conan-center-bot requested review from uilianries, jgsogo and danimtb June 21, 2021 11:59

stale bot added the stale label Jul 28, 2021

stale bot closed this Aug 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add the marked-up object compiler, moc, package to conan center #5832

add the marked-up object compiler, moc, package to conan center #5832

zuut commented Jun 9, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

SpaceIm commented Jun 9, 2021

zuut commented Jun 9, 2021

This comment has been minimized.

This comment has been minimized.

ghost commented Jun 13, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

prince-chrismc left a comment

SpaceIm Jun 17, 2021 •

edited

Loading

SpaceIm Jun 17, 2021

SpaceIm Jun 17, 2021

conan-center-bot commented Jun 28, 2021

stale bot commented Jul 28, 2021

stale bot commented Aug 27, 2021

		self.cpp_info.builddirs.append(join("lib", "moc"))
		self.cpp_info.builddirs.append(join("lib", "uf"))

	tools.remove_files_by_mask(join(self.package_folder, "lib"), "*-config.cmake")
	tools.rmdir(join(self.package_folder, "lib", "moc"))
	tools.remove_files_by_mask(join(self.package_folder, "lib", "uf"), "*.cmake")

add the marked-up object compiler, moc, package to conan center #5832

add the marked-up object compiler, moc, package to conan center #5832

Conversation

zuut commented Jun 9, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

SpaceIm commented Jun 9, 2021

zuut commented Jun 9, 2021

This comment has been minimized.

This comment has been minimized.

ghost commented Jun 13, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

prince-chrismc left a comment

Choose a reason for hiding this comment

SpaceIm Jun 17, 2021 • edited Loading

Choose a reason for hiding this comment

SpaceIm Jun 17, 2021

Choose a reason for hiding this comment

SpaceIm Jun 17, 2021

Choose a reason for hiding this comment

conan-center-bot commented Jun 28, 2021

stale bot commented Jul 28, 2021

stale bot commented Aug 27, 2021

SpaceIm Jun 17, 2021 •

edited

Loading